Re: [PATCH v2 0/2] virtio/vhost: fix alignment requirements
"Michael S. Tsirkin" writes: > On Thu, Dec 25, 2014 at 05:05:01PM +0200, Michael S. Tsirkin wrote: >> vhost incorrectly asked for 8 byte alignment for >> used ring pointer, it should be 4 byte. >> >> Let's add explicit macros for ring element alignment, >> this makes it easier to make sure our requirements >> match the spec. >> >> Rusty, OK to merge this through my vhost tree, or do you >> prefer merging this through yours? > > Just to clarify, this is needed in 3.19. Sure, please take this via the vhost tree. Acked-by: Rusty Russell Thanks, Rusty. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 0/2] virtio/vhost: fix alignment requirements
Michael S. Tsirkin m...@redhat.com writes: On Thu, Dec 25, 2014 at 05:05:01PM +0200, Michael S. Tsirkin wrote: vhost incorrectly asked for 8 byte alignment for used ring pointer, it should be 4 byte. Let's add explicit macros for ring element alignment, this makes it easier to make sure our requirements match the spec. Rusty, OK to merge this through my vhost tree, or do you prefer merging this through yours? Just to clarify, this is needed in 3.19. Sure, please take this via the vhost tree. Acked-by: Rusty Russell ru...@rustcorp.com.au Thanks, Rusty. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 0/2] virtio/vhost: fix alignment requirements
On Thu, Dec 25, 2014 at 05:05:01PM +0200, Michael S. Tsirkin wrote: > vhost incorrectly asked for 8 byte alignment for > used ring pointer, it should be 4 byte. > > Let's add explicit macros for ring element alignment, > this makes it easier to make sure our requirements > match the spec. > > Rusty, OK to merge this through my vhost tree, or do you > prefer merging this through yours? Just to clarify, this is needed in 3.19. > Michael S. Tsirkin (2): > virtio_ring: document alignment requirements > vhost: relax used address alignment > > include/uapi/linux/virtio_ring.h | 7 +++ > drivers/vhost/vhost.c| 10 +++--- > 2 files changed, 14 insertions(+), 3 deletions(-) > > -- > MST > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 0/2] virtio/vhost: fix alignment requirements
On Thu, Dec 25, 2014 at 05:05:01PM +0200, Michael S. Tsirkin wrote: vhost incorrectly asked for 8 byte alignment for used ring pointer, it should be 4 byte. Let's add explicit macros for ring element alignment, this makes it easier to make sure our requirements match the spec. Rusty, OK to merge this through my vhost tree, or do you prefer merging this through yours? Just to clarify, this is needed in 3.19. Michael S. Tsirkin (2): virtio_ring: document alignment requirements vhost: relax used address alignment include/uapi/linux/virtio_ring.h | 7 +++ drivers/vhost/vhost.c| 10 +++--- 2 files changed, 14 insertions(+), 3 deletions(-) -- MST -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/