Re: [PATCH v2 0/6] correct load_balance()
On Mon, Apr 22, 2013 at 02:01:18PM +0200, Peter Zijlstra wrote: > On Mon, 2013-04-22 at 17:01 +0900, Joonsoo Kim wrote: > > > Hello, Ingo and Peter. > > > > Just ping for this patchset. > > The patches look fine -- except a few cosmetic changes. I'm fine with > Ingo taking them now and merging a 7/6 patch that clears up the > cosmetic issues or you can repost with them taken care of. > > I'll leave that up to you and Ingo. I sent v3 which reflect all Peter's comments. Here is the link for v3. https://lkml.org/lkml/2013/4/23/88 > > Otherwise: > > Acked-by: Peter Zijlstra Thanks! > > Thanks! > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 0/6] correct load_balance()
On Mon, Apr 22, 2013 at 01:07:07PM -0700, Davidlohr Bueso wrote: > On Mon, 2013-04-22 at 14:01 +0200, Peter Zijlstra wrote: > > On Mon, 2013-04-22 at 17:01 +0900, Joonsoo Kim wrote: > > > > > Hello, Ingo and Peter. > > > > > > Just ping for this patchset. > > > > The patches look fine -- except a few cosmetic changes. I'm fine with > > Ingo taking them now and merging a 7/6 patch that clears up the > > cosmetic issues or you can repost with them taken care of. > > > > I'll leave that up to you and Ingo. > > > > Otherwise: > > > > Acked-by: Peter Zijlstra > > On behalf of Jason who has been testing this patchset: > > Tested-by: Jason Low Hello, Jason and Davidlohr. Thanks for testing! > > Thanks, > Jason & Davidlohr > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 0/6] correct load_balance()
On Mon, Apr 22, 2013 at 01:07:07PM -0700, Davidlohr Bueso wrote: On Mon, 2013-04-22 at 14:01 +0200, Peter Zijlstra wrote: On Mon, 2013-04-22 at 17:01 +0900, Joonsoo Kim wrote: Hello, Ingo and Peter. Just ping for this patchset. The patches look fine -- except a few cosmetic changes. I'm fine with Ingo taking them now and merging a 7/6 patch that clears up the cosmetic issues or you can repost with them taken care of. I'll leave that up to you and Ingo. Otherwise: Acked-by: Peter Zijlstra a.p.zijls...@chello.nl On behalf of Jason who has been testing this patchset: Tested-by: Jason Low jason.l...@hp.com Hello, Jason and Davidlohr. Thanks for testing! Thanks, Jason Davidlohr -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 0/6] correct load_balance()
On Mon, Apr 22, 2013 at 02:01:18PM +0200, Peter Zijlstra wrote: On Mon, 2013-04-22 at 17:01 +0900, Joonsoo Kim wrote: Hello, Ingo and Peter. Just ping for this patchset. The patches look fine -- except a few cosmetic changes. I'm fine with Ingo taking them now and merging a 7/6 patch that clears up the cosmetic issues or you can repost with them taken care of. I'll leave that up to you and Ingo. I sent v3 which reflect all Peter's comments. Here is the link for v3. https://lkml.org/lkml/2013/4/23/88 Otherwise: Acked-by: Peter Zijlstra a.p.zijls...@chello.nl Thanks! Thanks! -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 0/6] correct load_balance()
On Mon, 2013-04-22 at 14:01 +0200, Peter Zijlstra wrote: > On Mon, 2013-04-22 at 17:01 +0900, Joonsoo Kim wrote: > > > Hello, Ingo and Peter. > > > > Just ping for this patchset. > > The patches look fine -- except a few cosmetic changes. I'm fine with > Ingo taking them now and merging a 7/6 patch that clears up the > cosmetic issues or you can repost with them taken care of. > > I'll leave that up to you and Ingo. > > Otherwise: > > Acked-by: Peter Zijlstra On behalf of Jason who has been testing this patchset: Tested-by: Jason Low Thanks, Jason & Davidlohr -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 0/6] correct load_balance()
On Mon, 2013-04-22 at 17:01 +0900, Joonsoo Kim wrote: > Hello, Ingo and Peter. > > Just ping for this patchset. The patches look fine -- except a few cosmetic changes. I'm fine with Ingo taking them now and merging a 7/6 patch that clears up the cosmetic issues or you can repost with them taken care of. I'll leave that up to you and Ingo. Otherwise: Acked-by: Peter Zijlstra Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 0/6] correct load_balance()
On Tue, Mar 26, 2013 at 03:01:34PM +0900, Joonsoo Kim wrote: > Commit 88b8dac0 makes load_balance() consider other cpus in its group. > But, there are some missing parts for this feature to work properly. > This patchset correct these things and make load_balance() robust. > > Others are related to LBF_ALL_PINNED. This is fallback functionality > when all tasks can't be moved as cpu affinity. But, currently, > if imbalance is not large enough to task's load, we leave LBF_ALL_PINNED > flag and 'redo' is triggered. This is not our intention, so correct it. > > These are based on v3.9-rc4. > > Changelog > v1->v2: Changes from Peter's suggestion > [4/6]: don't include a code to evaluate load value in can_migrate_task() > [5/6]: rename load_balance_tmpmask to load_balance_mask > [6/6]: not use one more cpumasks, use env's cpus for prevent to re-select > > Joonsoo Kim (6): > sched: change position of resched_cpu() in load_balance() > sched: explicitly cpu_idle_type checking in rebalance_domains() > sched: don't consider other cpus in our group in case of NEWLY_IDLE > sched: move up affinity check to mitigate useless redoing overhead > sched: rename load_balance_tmpmask to load_balance_mask > sched: prevent to re-select dst-cpu in load_balance() > > kernel/sched/core.c |4 +-- > kernel/sched/fair.c | 67 > +++ > 2 files changed, 38 insertions(+), 33 deletions(-) Hello, Ingo and Peter. Just ping for this patchset. Please let me know what I have to do for merging this patchset. Thanks. > > -- > 1.7.9.5 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 0/6] correct load_balance()
On Tue, Mar 26, 2013 at 03:01:34PM +0900, Joonsoo Kim wrote: Commit 88b8dac0 makes load_balance() consider other cpus in its group. But, there are some missing parts for this feature to work properly. This patchset correct these things and make load_balance() robust. Others are related to LBF_ALL_PINNED. This is fallback functionality when all tasks can't be moved as cpu affinity. But, currently, if imbalance is not large enough to task's load, we leave LBF_ALL_PINNED flag and 'redo' is triggered. This is not our intention, so correct it. These are based on v3.9-rc4. Changelog v1-v2: Changes from Peter's suggestion [4/6]: don't include a code to evaluate load value in can_migrate_task() [5/6]: rename load_balance_tmpmask to load_balance_mask [6/6]: not use one more cpumasks, use env's cpus for prevent to re-select Joonsoo Kim (6): sched: change position of resched_cpu() in load_balance() sched: explicitly cpu_idle_type checking in rebalance_domains() sched: don't consider other cpus in our group in case of NEWLY_IDLE sched: move up affinity check to mitigate useless redoing overhead sched: rename load_balance_tmpmask to load_balance_mask sched: prevent to re-select dst-cpu in load_balance() kernel/sched/core.c |4 +-- kernel/sched/fair.c | 67 +++ 2 files changed, 38 insertions(+), 33 deletions(-) Hello, Ingo and Peter. Just ping for this patchset. Please let me know what I have to do for merging this patchset. Thanks. -- 1.7.9.5 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 0/6] correct load_balance()
On Mon, 2013-04-22 at 17:01 +0900, Joonsoo Kim wrote: Hello, Ingo and Peter. Just ping for this patchset. The patches look fine -- except a few cosmetic changes. I'm fine with Ingo taking them now and merging a 7/6 patch that clears up the cosmetic issues or you can repost with them taken care of. I'll leave that up to you and Ingo. Otherwise: Acked-by: Peter Zijlstra a.p.zijls...@chello.nl Thanks! -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 0/6] correct load_balance()
On Mon, 2013-04-22 at 14:01 +0200, Peter Zijlstra wrote: On Mon, 2013-04-22 at 17:01 +0900, Joonsoo Kim wrote: Hello, Ingo and Peter. Just ping for this patchset. The patches look fine -- except a few cosmetic changes. I'm fine with Ingo taking them now and merging a 7/6 patch that clears up the cosmetic issues or you can repost with them taken care of. I'll leave that up to you and Ingo. Otherwise: Acked-by: Peter Zijlstra a.p.zijls...@chello.nl On behalf of Jason who has been testing this patchset: Tested-by: Jason Low jason.l...@hp.com Thanks, Jason Davidlohr -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
