Re: [PATCH v2 06/10] crypto: AF_ALG: make setkey optional
Am Dienstag, 18. November 2014, 22:10:13 schrieb Herbert Xu: Hi Herbert, > On Sun, Nov 16, 2014 at 03:26:58AM +0100, Stephan Mueller wrote: > > The current AF_ALG implementation requires that a userspace interface > > implementation must provide a callback for setkey. Such a call is not > > appliable to random number generators. > > > > To prepare AF_ALG for the addition of a random number generator user > > space interface, this function callback invocation is made optional. > > > > Signed-off-by: Stephan Mueller > > Did you actually try this? AFAICS setkey is already optional. You are correct. I tested the kernel without my patch and the setkey on the RNG handle is rejected. I now also see the check already present in the alg_setkey function. This patch will be removed from a new patchset. > > Cheers, -- Ciao Stephan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 06/10] crypto: AF_ALG: make setkey optional
On Sun, Nov 16, 2014 at 03:26:58AM +0100, Stephan Mueller wrote: > The current AF_ALG implementation requires that a userspace interface > implementation must provide a callback for setkey. Such a call is not > appliable to random number generators. > > To prepare AF_ALG for the addition of a random number generator user > space interface, this function callback invocation is made optional. > > Signed-off-by: Stephan Mueller Did you actually try this? AFAICS setkey is already optional. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 06/10] crypto: AF_ALG: make setkey optional
Am Dienstag, 18. November 2014, 22:10:13 schrieb Herbert Xu: Hi Herbert, On Sun, Nov 16, 2014 at 03:26:58AM +0100, Stephan Mueller wrote: The current AF_ALG implementation requires that a userspace interface implementation must provide a callback for setkey. Such a call is not appliable to random number generators. To prepare AF_ALG for the addition of a random number generator user space interface, this function callback invocation is made optional. Signed-off-by: Stephan Mueller smuel...@chronox.de Did you actually try this? AFAICS setkey is already optional. You are correct. I tested the kernel without my patch and the setkey on the RNG handle is rejected. I now also see the check already present in the alg_setkey function. This patch will be removed from a new patchset. Cheers, -- Ciao Stephan -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 06/10] crypto: AF_ALG: make setkey optional
On Sun, Nov 16, 2014 at 03:26:58AM +0100, Stephan Mueller wrote: The current AF_ALG implementation requires that a userspace interface implementation must provide a callback for setkey. Such a call is not appliable to random number generators. To prepare AF_ALG for the addition of a random number generator user space interface, this function callback invocation is made optional. Signed-off-by: Stephan Mueller smuel...@chronox.de Did you actually try this? AFAICS setkey is already optional. Cheers, -- Email: Herbert Xu herb...@gondor.apana.org.au Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
