Re: [PATCH v2 09/10] fs/ntfs3: Add NTFS3 in fs/Kconfig and fs/Makefile
Hi Konstantin, Thank you for the patch! Yet something to improve: [auto build test ERROR on linux/master] [also build test ERROR on linus/master v5.9-rc1 next-20200821] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Konstantin-Komarov/fs-NTFS-read-write-driver-GPL-implementation-by-Paragon-Software/20200822-003353 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git bcf876870b95592b52519ed4aafcf9d95999bc9c config: h8300-allyesconfig (attached as .config) compiler: h8300-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=h8300 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All error/warnings (new ones prefixed by >>): In file included from include/asm-generic/bug.h:5, from arch/h8300/include/asm/bug.h:8, from include/linux/bug.h:5, from include/linux/thread_info.h:12, from include/asm-generic/current.h:5, from ./arch/h8300/include/generated/asm/current.h:1, from include/linux/sched.h:12, from include/linux/blkdev.h:5, from fs/ntfs3/fslog.c:9: include/linux/scatterlist.h: In function 'sg_set_buf': include/asm-generic/page.h:93:50: warning: ordered comparison of pointer with null pointer [-Wextra] 93 | #define virt_addr_valid(kaddr) (((void *)(kaddr) >= (void *)PAGE_OFFSET) && \ | ^~ include/linux/compiler.h:78:42: note: in definition of macro 'unlikely' 78 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ include/linux/scatterlist.h:143:2: note: in expansion of macro 'BUG_ON' 143 | BUG_ON(!virt_addr_valid(buf)); | ^~ include/linux/scatterlist.h:143:10: note: in expansion of macro 'virt_addr_valid' 143 | BUG_ON(!virt_addr_valid(buf)); | ^~~ fs/ntfs3/fslog.c: In function 'log_replay': fs/ntfs3/fslog.c:3895:7: warning: variable 'vbo_to_clear' set but not used [-Wunused-but-set-variable] 3895 | u32 vbo_to_clear = page_size * 2; | ^~~~ fs/ntfs3/fslog.c:3894:8: warning: variable 'clear_log' set but not used [-Wunused-but-set-variable] 3894 | bool clear_log = true; |^ fs/ntfs3/fslog.c:3780:17: warning: variable 'clst_off' set but not used [-Wunused-but-set-variable] 3780 | u32 saved_len, clst_off, rec_len, transact_id; | ^~~~ fs/ntfs3/fslog.c: In function 'last_log_lsn': >> fs/ntfs3/fslog.c:2241:1: warning: the frame size of 1044 bytes is larger >> than 1024 bytes [-Wframe-larger-than=] 2241 | } | ^ -- h8300-linux-ld: fs/ntfs3/file.o: in function `ntfs_setattr': >> file.c:(.text+0x3ca0): multiple definition of `ntfs_setattr'; >> fs/ntfs/inode.o:inode.c:(.text+0x9000): first defined here --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip
Re: [PATCH v2 09/10] fs/ntfs3: Add NTFS3 in fs/Kconfig and fs/Makefile
Hi Konstantin,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linux/master]
[also build test WARNING on linus/master v5.9-rc1 next-20200821]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Konstantin-Komarov/fs-NTFS-read-write-driver-GPL-implementation-by-Paragon-Software/20200822-003353
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
bcf876870b95592b52519ed4aafcf9d95999bc9c
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sh
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
All warnings (new ones prefixed by >>):
fs/ntfs3/inode.c: In function 'ntfs_read_mft':
>> fs/ntfs3/inode.c:40:7: warning: variable 'is_encrypted' set but not used
>> [-Wunused-but-set-variable]
40 | bool is_encrypted = false;
| ^~~~
--
fs/ntfs3/fsntfs.c: In function 'ntfs_extend_init':
>> fs/ntfs3/fsntfs.c:171:14: warning: variable 'ni' set but not used
>> [-Wunused-but-set-variable]
171 | ntfs_inode *ni;
| ^~
fs/ntfs3/fsntfs.c: In function 'ntfs_loadlog_and_replay':
>> fs/ntfs3/fsntfs.c:241:11: warning: variable 'log_size' set but not used
>> [-Wunused-but-set-variable]
241 | u32 idx, log_size;
| ^~~~
fs/ntfs3/fsntfs.c: In function 'ntfs_insert_security':
>> fs/ntfs3/fsntfs.c:1764:6: warning: variable 'used' set but not used
>> [-Wunused-but-set-variable]
1764 | u32 used, next, left;
| ^~~~
--
fs/ntfs3/frecord.c: In function 'ni_ins_attr_ext':
>> fs/ntfs3/frecord.c:670:11: warning: variable 'rec' set but not used
>> [-Wunused-but-set-variable]
670 | MFT_REC *rec;
| ^~~
--
fs/ntfs3/index.c: In function 'indx_find_sort':
>> fs/ntfs3/index.c:1148:6: warning: variable 'err' set but not used
>> [-Wunused-but-set-variable]
1148 | int err;
| ^~~
--
fs/ntfs3/attrib.c: In function 'attr_set_size':
>> fs/ntfs3/attrib.c:478:10: warning: variable 'cnt' set but not used
>> [-Wunused-but-set-variable]
478 | size_t cnt, free;
| ^~~
fs/ntfs3/attrib.c: In function 'attr_data_get_block':
>> fs/ntfs3/attrib.c:769:28: warning: variable 'new_alloc' set but not used
>> [-Wunused-but-set-variable]
769 | u64 new_size, total_size, new_alloc;
|^
--
fs/ntfs3/super.c: In function 'ntfs_fill_super':
>> fs/ntfs3/super.c:831:16: warning: unsigned conversion from 'long long int'
>> to 'long unsigned int' changes value from '220979426414' to '1936094318'
>> [-Woverflow]
831 | sb->s_magic = 0x337366746e; // "ntfs3"
|^~~~
--
fs/ntfs3/fslog.c: In function 'log_replay':
>> fs/ntfs3/fslog.c:3895:7: warning: variable 'vbo_to_clear' set but not used
>> [-Wunused-but-set-variable]
3895 | u32 vbo_to_clear = page_size * 2;
| ^~~~
>> fs/ntfs3/fslog.c:3894:8: warning: variable 'clear_log' set but not used
>> [-Wunused-but-set-variable]
3894 | bool clear_log = true;
|^
>> fs/ntfs3/fslog.c:3780:17: warning: variable 'clst_off' set but not used
>> [-Wunused-but-set-variable]
3780 | u32 saved_len, clst_off, rec_len, transact_id;
| ^~~~
#
https://github.com/0day-ci/linux/commit/cc8413bd463338b0ad2b6369a619196d5b77798a
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Konstantin-Komarov/fs-NTFS-read-write-driver-GPL-implementation-by-Paragon-Software/20200822-003353
git checkout cc8413bd463338b0ad2b6369a619196d5b77798a
vim +/is_encrypted +40 fs/ntfs3/inode.c
9106c639ce09ddc Konstantin Komarov 2020-08-21 22
9106c639ce09ddc Konstantin Komarov 2020-08-21 23 /*
9106c639ce09ddc Konstantin Komarov 2020-08-21 24 * ntfs_read_mft
9106c639ce09ddc Konstantin Komarov 2020-08-21 25 *
9106c639ce09ddc Konstantin Komarov 2020-08-21 26 * reads record and parses
MFT
9106c639ce09ddc Konstantin Komarov 2020-08-21 27 */
9106c639ce09ddc Konstantin Komarov 2020-08-21 28 static struct inode
*ntfs_read_mft(struct inode *inode,
9106c639ce09ddc Konstantin Komarov 2020-08-21 29
const struct cpu_str *name,
9106c639ce09ddc Konstantin Komarov 2020-08-21 30
const MFT_REF *ref)
9106c639ce09ddc Konstantin Komarov 2020-08-21 31 {
9106c639ce09ddc
