Re: [PATCH v2 1/2] HID: logitech-hidpp: fix negated returns
On Mon, 3 Nov 2014, Benjamin Tissoires wrote: > Reported by Dan Carpenter: > > drivers/hid/hid-logitech-hidpp.c:359 hidpp_root_get_protocol_version() warn: > should this return really be negated? > drivers/hid/hid-logitech-hidpp.c:398 hidpp_devicenametype_get_count() warn: > should this return really be negated? > drivers/hid/hid-logitech-hidpp.c:417 hidpp_devicenametype_get_device_name() > warn: should this return really be negated? > drivers/hid/hid-logitech-hidpp.c:524 hidpp_touchpad_get_raw_info() warn: > should this return really be negated? > > The problem lies in hidpp_send_message_sync() which can return 2 types of > errors depending of their sign. Adding a comment there to clarify what is > happening. > > To solve that, print an error in case of a protocol problem, and raise > -EPROTO instead. > > Reported-by: Dan Carpenter > Signed-off-by: Benjamin Tissoires > --- > > Changes in v2: > - also return if the ret code is negative Applied. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 1/2] HID: logitech-hidpp: fix negated returns
On Mon, 3 Nov 2014, Benjamin Tissoires wrote: Reported by Dan Carpenter: drivers/hid/hid-logitech-hidpp.c:359 hidpp_root_get_protocol_version() warn: should this return really be negated? drivers/hid/hid-logitech-hidpp.c:398 hidpp_devicenametype_get_count() warn: should this return really be negated? drivers/hid/hid-logitech-hidpp.c:417 hidpp_devicenametype_get_device_name() warn: should this return really be negated? drivers/hid/hid-logitech-hidpp.c:524 hidpp_touchpad_get_raw_info() warn: should this return really be negated? The problem lies in hidpp_send_message_sync() which can return 2 types of errors depending of their sign. Adding a comment there to clarify what is happening. To solve that, print an error in case of a protocol problem, and raise -EPROTO instead. Reported-by: Dan Carpenter dan.carpen...@oracle.com Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com --- Changes in v2: - also return if the ret code is negative Applied. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 1/2] HID: logitech-hidpp: fix negated returns
Looks good. Thanks! regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 1/2] HID: logitech-hidpp: fix negated returns
Looks good. Thanks! regards, dan carpenter -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
