Re: [PATCH v2 1/4] selftests/livepatch: simplify test-klp-callbacks busy target tests

2020-06-08 Thread Petr Mladek 
On Fri 2020-06-05 15:05:55, Miroslav Benes wrote:
> On Wed, 3 Jun 2020, Yannick Cote wrote:
> 
> > From: Joe Lawrence 
> > 
> > The test-klp-callbacks script includes a few tests which rely on kernel
> > task timings that may not always execute as expected under system load.
> > These may generate out of sequence kernel log messages that result in
> > test failure.
> > 
> > Instead of using sleep timing windows to orchestrate these tests, add a
> > block_transition module parameter to communicate the test purpose and
> > utilize flush_queue() to serialize the test module's task output.
> > 
> > Suggested-by: Petr Mladek 
> > Signed-off-by: Joe Lawrence 
> 
> Acked-by: Miroslav Benes 

JFYI, this patchset is committed in livepatching.git, branch
for-5.9/selftests-cleanup.

Best Regards,
Petr

Re: [PATCH v2 1/4] selftests/livepatch: simplify test-klp-callbacks busy target tests

2020-06-05 Thread Miroslav Benes 
On Wed, 3 Jun 2020, Yannick Cote wrote:

> From: Joe Lawrence 
> 
> The test-klp-callbacks script includes a few tests which rely on kernel
> task timings that may not always execute as expected under system load.
> These may generate out of sequence kernel log messages that result in
> test failure.
> 
> Instead of using sleep timing windows to orchestrate these tests, add a
> block_transition module parameter to communicate the test purpose and
> utilize flush_queue() to serialize the test module's task output.
> 
> Suggested-by: Petr Mladek 
> Signed-off-by: Joe Lawrence 

Acked-by: Miroslav Benes 

M

Re: [PATCH v2 1/4] selftests/livepatch: simplify test-klp-callbacks busy target tests

2020-06-05 Thread Petr Mladek 
On Wed 2020-06-03 14:20:55, Yannick Cote wrote:
> From: Joe Lawrence 
> 
> The test-klp-callbacks script includes a few tests which rely on kernel
> task timings that may not always execute as expected under system load.
> These may generate out of sequence kernel log messages that result in
> test failure.
> 
> Instead of using sleep timing windows to orchestrate these tests, add a
> block_transition module parameter to communicate the test purpose and
> utilize flush_queue() to serialize the test module's task output.
> 
> Suggested-by: Petr Mladek 

I am not sure if I deserve this. I suggested only few implementation details.

> Signed-off-by: Joe Lawrence 

Looks good now:

Reviewed-by: Petr Mladek 

Best Regards,
Petr