Re: [PATCH v2 1/8] mm/zsmalloc: modify zs compact trace interface

[Ganesh Mahendran]

2016-07-06 10:32 GMT+08:00 Minchan Kim :
> Hi Ganesh,
>
> On Mon, Jul 04, 2016 at 02:49:52PM +0800, Ganesh Mahendran wrote:
>> This patch changes trace_zsmalloc_compact_start[end] to
>> trace_zs_compact_start[end] to keep function naming consistent
>> with others in zsmalloc
>>
>> Also this patch remove pages_total_compacted information which
>> may not really needed.
>>
>> Signed-off-by: Ganesh Mahendran 
>
> Once we decide to add event trace, I prefer getting more detailed
> information which is hard to get it via /sys/block/zram/.
> So, we can add trace __zs_compact as well as zs_compact with
> some changes.
>
> IOW,
>
> zs_compact
> trace_zs_compact_start(pool->name)
> __zs_compact
> trace_zs_compact(class, scanned_obj, freed_pages)
> trace_zs_compact_end(pool->name)

Thanks, I will do it.

Re: [PATCH v2 1/8] mm/zsmalloc: modify zs compact trace interface

[Ganesh Mahendran]

2016-07-06 10:32 GMT+08:00 Minchan Kim :
> Hi Ganesh,
>
> On Mon, Jul 04, 2016 at 02:49:52PM +0800, Ganesh Mahendran wrote:
>> This patch changes trace_zsmalloc_compact_start[end] to
>> trace_zs_compact_start[end] to keep function naming consistent
>> with others in zsmalloc
>>
>> Also this patch remove pages_total_compacted information which
>> may not really needed.
>>
>> Signed-off-by: Ganesh Mahendran 
>
> Once we decide to add event trace, I prefer getting more detailed
> information which is hard to get it via /sys/block/zram/.
> So, we can add trace __zs_compact as well as zs_compact with
> some changes.
>
> IOW,
>
> zs_compact
> trace_zs_compact_start(pool->name)
> __zs_compact
> trace_zs_compact(class, scanned_obj, freed_pages)
> trace_zs_compact_end(pool->name)

Thanks, I will do it.

Re: [PATCH v2 1/8] mm/zsmalloc: modify zs compact trace interface

[Minchan Kim]

Hi Ganesh,

On Mon, Jul 04, 2016 at 02:49:52PM +0800, Ganesh Mahendran wrote:
> This patch changes trace_zsmalloc_compact_start[end] to
> trace_zs_compact_start[end] to keep function naming consistent
> with others in zsmalloc
> 
> Also this patch remove pages_total_compacted information which
> may not really needed.
> 
> Signed-off-by: Ganesh Mahendran 

Once we decide to add event trace, I prefer getting more detailed
information which is hard to get it via /sys/block/zram/.
So, we can add trace __zs_compact as well as zs_compact with
some changes.

IOW,

zs_compact
trace_zs_compact_start(pool->name)
__zs_compact
trace_zs_compact(class, scanned_obj, freed_pages)
trace_zs_compact_end(pool->name)

Re: [PATCH v2 1/8] mm/zsmalloc: modify zs compact trace interface

[Minchan Kim]

Hi Ganesh,

On Mon, Jul 04, 2016 at 02:49:52PM +0800, Ganesh Mahendran wrote:
> This patch changes trace_zsmalloc_compact_start[end] to
> trace_zs_compact_start[end] to keep function naming consistent
> with others in zsmalloc
> 
> Also this patch remove pages_total_compacted information which
> may not really needed.
> 
> Signed-off-by: Ganesh Mahendran 

Once we decide to add event trace, I prefer getting more detailed
information which is hard to get it via /sys/block/zram/.
So, we can add trace __zs_compact as well as zs_compact with
some changes.

IOW,

zs_compact
trace_zs_compact_start(pool->name)
__zs_compact
trace_zs_compact(class, scanned_obj, freed_pages)
trace_zs_compact_end(pool->name)

Re: [PATCH v2 1/8] mm/zsmalloc: modify zs compact trace interface

[Steven Rostedt]

On Mon,  4 Jul 2016 14:49:52 +0800
Ganesh Mahendran  wrote:

> This patch changes trace_zsmalloc_compact_start[end] to
> trace_zs_compact_start[end] to keep function naming consistent
> with others in zsmalloc
> 
> Also this patch remove pages_total_compacted information which
> may not really needed.
> 
> Signed-off-by: Ganesh Mahendran 

This looks fine to me, as long as the zs maintainers are OK with the
tracepoint changes (it is visible from user space).

-- Steve

Re: [PATCH v2 1/8] mm/zsmalloc: modify zs compact trace interface

[Steven Rostedt]

On Mon,  4 Jul 2016 14:49:52 +0800
Ganesh Mahendran  wrote:

> This patch changes trace_zsmalloc_compact_start[end] to
> trace_zs_compact_start[end] to keep function naming consistent
> with others in zsmalloc
> 
> Also this patch remove pages_total_compacted information which
> may not really needed.
> 
> Signed-off-by: Ganesh Mahendran 

This looks fine to me, as long as the zs maintainers are OK with the
tracepoint changes (it is visible from user space).

-- Steve