Re: [PATCH v2 2/4] clk: qcom: clk-rpmh: Convert to parent data scheme

[Vinod Koul]

On 19-08-19, 22:08, Bjorn Andersson wrote:
> On Mon 19 Aug 00:39 PDT 2019, Vinod Koul wrote:
> 
> > Convert the rpmh clock driver to use the new parent data scheme by
> > specifying the parent data for board clock.
> > 
> > Signed-off-by: Vinod Koul 
> > ---
> >  drivers/clk/qcom/clk-rpmh.c | 10 --
> >  1 file changed, 8 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/clk/qcom/clk-rpmh.c b/drivers/clk/qcom/clk-rpmh.c
> > index c3fd632af119..16d689e5bb3c 100644
> > --- a/drivers/clk/qcom/clk-rpmh.c
> > +++ b/drivers/clk/qcom/clk-rpmh.c
> > @@ -95,7 +95,10 @@ static DEFINE_MUTEX(rpmh_clk_lock);
> > .hw.init = &(struct clk_init_data){ \
> > .ops = _rpmh_ops,   \
> > .name = #_name, \
> > -   .parent_names = (const char *[]){ "xo_board" }, \
> > +   .parent_data =  &(const struct clk_parent_data){ \
> > +   .fw_name = "xo",\
> > +   .name = "xo",   \
> 
> Shouldn't .name be "xo_board" to retain backwards compatibility?

Yes I have updated that

Thanks
-- 
~Vinod

Re: [PATCH v2 2/4] clk: qcom: clk-rpmh: Convert to parent data scheme

[Bjorn Andersson]

On Mon 19 Aug 00:39 PDT 2019, Vinod Koul wrote:

> Convert the rpmh clock driver to use the new parent data scheme by
> specifying the parent data for board clock.
> 
> Signed-off-by: Vinod Koul 
> ---
>  drivers/clk/qcom/clk-rpmh.c | 10 --
>  1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/clk/qcom/clk-rpmh.c b/drivers/clk/qcom/clk-rpmh.c
> index c3fd632af119..16d689e5bb3c 100644
> --- a/drivers/clk/qcom/clk-rpmh.c
> +++ b/drivers/clk/qcom/clk-rpmh.c
> @@ -95,7 +95,10 @@ static DEFINE_MUTEX(rpmh_clk_lock);
>   .hw.init = &(struct clk_init_data){ \
>   .ops = _rpmh_ops,   \
>   .name = #_name, \
> - .parent_names = (const char *[]){ "xo_board" }, \
> + .parent_data =  &(const struct clk_parent_data){ \
> + .fw_name = "xo",\
> + .name = "xo",   \

Shouldn't .name be "xo_board" to retain backwards compatibility?

Regards,
Bjorn

> + },  \
>   .num_parents = 1,   \
>   },  \
>   };  \
> @@ -110,7 +113,10 @@ static DEFINE_MUTEX(rpmh_clk_lock);
>   .hw.init = &(struct clk_init_data){ \
>   .ops = _rpmh_ops,   \
>   .name = #_name_active,  \
> - .parent_names = (const char *[]){ "xo_board" }, \
> + .parent_data =  &(const struct clk_parent_data){ \
> + .fw_name = "xo",\
> + .name = "xo",   \
> + },  \
>   .num_parents = 1,   \
>   },  \
>   }
> -- 
> 2.20.1
>