Re: [PATCH v2 3/4] ARM: dts: exynos: add initial data for coupled regulators for Exynos5422/5800

[Bartlomiej Zolnierkiewicz]

On 7/16/19 11:22 AM, Krzysztof Kozlowski wrote:
> On Mon, 15 Jul 2019 at 14:04, Kamil Konieczny
>  wrote:
>>
>> Declare Exynos5422/5800 voltage ranges for opp points for big cpu core and
>> bus wcore and couple their voltage supllies as vdd_arm and vdd_int should
>> be in 300mV range.
>>
>> Signed-off-by: Marek Szyprowski 
>> Signed-off-by: Kamil Konieczny 
> 
> This one was previously from Marek, now it is from you. Any changes here?

Hmmm, it seems that "From:" tag somehow got lost in v2 compared to v1?

Also the note about adding patch description (which was the only update to
original Marek's patch IIRC) should be added, something like:

...
Signed-off-by: Marek Szyprowski 
[k.konieczny: add missing patch description]
Signed-off-by: Kamil Konieczny 

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R Institute Poland
Samsung Electronics

Re: [PATCH v2 3/4] ARM: dts: exynos: add initial data for coupled regulators for Exynos5422/5800

[Krzysztof Kozlowski]

On Mon, 15 Jul 2019 at 14:04, Kamil Konieczny
 wrote:
>
> Declare Exynos5422/5800 voltage ranges for opp points for big cpu core and
> bus wcore and couple their voltage supllies as vdd_arm and vdd_int should
> be in 300mV range.
>
> Signed-off-by: Marek Szyprowski 
> Signed-off-by: Kamil Konieczny 

This one was previously from Marek, now it is from you. Any changes here?

Best regards,
Krzysztof

Re: [PATCH v2 3/4] ARM: dts: exynos: add initial data for coupled regulators for Exynos5422/5800

[Chanwoo Choi]

Hi,

On 19. 7. 15. 오후 9:04, Kamil Konieczny wrote:
> Declare Exynos5422/5800 voltage ranges for opp points for big cpu core and
> bus wcore and couple their voltage supllies as vdd_arm and vdd_int should
> be in 300mV range.
> 
> Signed-off-by: Marek Szyprowski 
> Signed-off-by: Kamil Konieczny 
> ---
>  arch/arm/boot/dts/exynos5420.dtsi | 34 +--
>  arch/arm/boot/dts/exynos5422-odroid-core.dtsi |  4 +++
>  arch/arm/boot/dts/exynos5800-peach-pi.dts |  4 +++
>  arch/arm/boot/dts/exynos5800.dtsi | 32 -
>  4 files changed, 41 insertions(+), 33 deletions(-)

Reviewed-by: Chanwoo Choi 

> 
> diff --git a/arch/arm/boot/dts/exynos5420.dtsi 
> b/arch/arm/boot/dts/exynos5420.dtsi
> index 5fb2326875dc..0cbf74750553 100644
> --- a/arch/arm/boot/dts/exynos5420.dtsi
> +++ b/arch/arm/boot/dts/exynos5420.dtsi
> @@ -48,62 +48,62 @@
>   opp-shared;
>   opp-18 {
>   opp-hz = /bits/ 64 <18>;
> - opp-microvolt = <125>;
> + opp-microvolt = <125 125 150>;
>   clock-latency-ns = <14>;
>   };
>   opp-17 {
>   opp-hz = /bits/ 64 <17>;
> - opp-microvolt = <1212500>;
> + opp-microvolt = <1212500 1212500 150>;
>   clock-latency-ns = <14>;
>   };
>   opp-16 {
>   opp-hz = /bits/ 64 <16>;
> - opp-microvolt = <1175000>;
> + opp-microvolt = <1175000 1175000 150>;
>   clock-latency-ns = <14>;
>   };
>   opp-15 {
>   opp-hz = /bits/ 64 <15>;
> - opp-microvolt = <1137500>;
> + opp-microvolt = <1137500 1137500 150>;
>   clock-latency-ns = <14>;
>   };
>   opp-14 {
>   opp-hz = /bits/ 64 <14>;
> - opp-microvolt = <1112500>;
> + opp-microvolt = <1112500 1112500 150>;
>   clock-latency-ns = <14>;
>   };
>   opp-13 {
>   opp-hz = /bits/ 64 <13>;
> - opp-microvolt = <1062500>;
> + opp-microvolt = <1062500 1062500 150>;
>   clock-latency-ns = <14>;
>   };
>   opp-12 {
>   opp-hz = /bits/ 64 <12>;
> - opp-microvolt = <1037500>;
> + opp-microvolt = <1037500 1037500 150>;
>   clock-latency-ns = <14>;
>   };
>   opp-11 {
>   opp-hz = /bits/ 64 <11>;
> - opp-microvolt = <1012500>;
> + opp-microvolt = <1012500 1012500 150>;
>   clock-latency-ns = <14>;
>   };
>   opp-10 {
>   opp-hz = /bits/ 64 <10>;
> - opp-microvolt = < 987500>;
> + opp-microvolt = < 987500 987500 150>;
>   clock-latency-ns = <14>;
>   };
>   opp-9 {
>   opp-hz = /bits/ 64 <9>;
> - opp-microvolt = < 962500>;
> + opp-microvolt = < 962500 962500 150>;
>   clock-latency-ns = <14>;
>   };
>   opp-8 {
>   opp-hz = /bits/ 64 <8>;
> - opp-microvolt = < 937500>;
> + opp-microvolt = < 937500 937500 150>;
>   clock-latency-ns = <14>;
>   };
>   opp-7 {
>   opp-hz = /bits/ 64 <7>;
> - opp-microvolt = < 912500>;
> + opp-microvolt = < 912500 912500 150>;
>   clock-latency-ns = <14>;
>   };
>   };
> @@ -1100,23 +1100,23 @@
>  
>   opp00 {
>   opp-hz = /bits/ 64 <8400>;
> -