Re: [PATCH v2 3/7] Documentation: bindings: document the Alpine MSIX driver

[Marc Zyngier]

On 10/02/16 13:22, Antoine Tenart wrote:
> Following the addition of the Alpine MSIX driver, this patch adds the
> corresponding bindings documentation.
> 
> Signed-off-by: Antoine Tenart 
> Signed-off-by: Tsahee Zidenberg 
> ---
>  .../interrupt-controller/al,alpine-msix.txt| 24 
> ++
>  1 file changed, 24 insertions(+)
>  create mode 100644 
> Documentation/devicetree/bindings/interrupt-controller/al,alpine-msix.txt
> 
> diff --git 
> a/Documentation/devicetree/bindings/interrupt-controller/al,alpine-msix.txt 
> b/Documentation/devicetree/bindings/interrupt-controller/al,alpine-msix.txt
> new file mode 100644
> index ..c7d3d0192f5d
> --- /dev/null
> +++ 
> b/Documentation/devicetree/bindings/interrupt-controller/al,alpine-msix.txt
> @@ -0,0 +1,24 @@
> +Alpine MSIX controller
> +
> +Required properties:
> +
> +- compatible: should be "al,alpine-msix"
> +- reg: physical base address and size of the registers
> +- interrupt-parent: specifies the parent interrupt controller.
> +- interrupt-controller: identifies the node as an interrupt controller
> +- msi-controller: identifies the node as an PCI Message Signaled Interrupt
> +   controller
> +- al,msi-base-spi: SPI base of the MSI frame
> +- al,msi-num-spis: number of SPIs assigned to the MSI frame

It would probably be good to reference the GIC bindings so that the
"SPI" acronym makes actual sense. It will also disambiguate the "base"
aspect (is this number relative to IRQ0? or SPI0? - I assume the latter,
but that's by looking at the code).

> +
> +Example:
> +
> +msix: msix {
> + compatible = "al,alpine-msix";
> + reg = <0x0 0xfbe0 0x0 0x10>;
> + interrupt-parent = <>;
> + interrupt-controller;
> + msi-controller;
> + al,msi-base-spi = <160>;
> + al,msi-num-spis = <160>;
> +};
> 

Otherwise looks good to me.

M.
-- 
Jazz is not dead. It just smells funny...

Re: [PATCH v2 3/7] Documentation: bindings: document the Alpine MSIX driver

[Marc Zyngier]

On 10/02/16 13:22, Antoine Tenart wrote:
> Following the addition of the Alpine MSIX driver, this patch adds the
> corresponding bindings documentation.
> 
> Signed-off-by: Antoine Tenart 
> Signed-off-by: Tsahee Zidenberg 
> ---
>  .../interrupt-controller/al,alpine-msix.txt| 24 
> ++
>  1 file changed, 24 insertions(+)
>  create mode 100644 
> Documentation/devicetree/bindings/interrupt-controller/al,alpine-msix.txt
> 
> diff --git 
> a/Documentation/devicetree/bindings/interrupt-controller/al,alpine-msix.txt 
> b/Documentation/devicetree/bindings/interrupt-controller/al,alpine-msix.txt
> new file mode 100644
> index ..c7d3d0192f5d
> --- /dev/null
> +++ 
> b/Documentation/devicetree/bindings/interrupt-controller/al,alpine-msix.txt
> @@ -0,0 +1,24 @@
> +Alpine MSIX controller
> +
> +Required properties:
> +
> +- compatible: should be "al,alpine-msix"
> +- reg: physical base address and size of the registers
> +- interrupt-parent: specifies the parent interrupt controller.
> +- interrupt-controller: identifies the node as an interrupt controller
> +- msi-controller: identifies the node as an PCI Message Signaled Interrupt
> +   controller
> +- al,msi-base-spi: SPI base of the MSI frame
> +- al,msi-num-spis: number of SPIs assigned to the MSI frame

It would probably be good to reference the GIC bindings so that the
"SPI" acronym makes actual sense. It will also disambiguate the "base"
aspect (is this number relative to IRQ0? or SPI0? - I assume the latter,
but that's by looking at the code).

> +
> +Example:
> +
> +msix: msix {
> + compatible = "al,alpine-msix";
> + reg = <0x0 0xfbe0 0x0 0x10>;
> + interrupt-parent = <>;
> + interrupt-controller;
> + msi-controller;
> + al,msi-base-spi = <160>;
> + al,msi-num-spis = <160>;
> +};
> 

Otherwise looks good to me.

M.
-- 
Jazz is not dead. It just smells funny...