Re: [PATCH v2 4/5] arm64: dts: qcom: sdm845: remove macro from unit name

2019-07-24 Thread Stephen Boyd
Quoting Vinod Koul (2019-07-23 21:49:05)
> Unit name is supposed to be a number, using a macro with hex value is
> not recommended, so add the value in unit name.
> 
> arch/arm64/boot/dts/qcom/pm8998.dtsi:81.18-84.6: Warning 
> (unit_address_format): /soc/spmi@c44/pmic@0/adc@3100/adc-chan@0x06: unit 
> name should not have leading "0x"
> arch/arm64/boot/dts/qcom/pm8998.dtsi:81.18-84.6: Warning 
> (unit_address_format): /soc/spmi@c44/pmic@0/adc@3100/adc-chan@0x06: unit 
> name should not have leading 0s
> 
> Signed-off-by: Vinod Koul 
> ---

Reviewed-by: Stephen Boyd 



Re: [PATCH v2 4/5] arm64: dts: qcom: sdm845: remove macro from unit name

2019-07-23 Thread Amit Kucheria
On Wed, Jul 24, 2019 at 10:20 AM Vinod Koul  wrote:
>
> Unit name is supposed to be a number, using a macro with hex value is
> not recommended, so add the value in unit name.
>
> arch/arm64/boot/dts/qcom/pm8998.dtsi:81.18-84.6: Warning 
> (unit_address_format): /soc/spmi@c44/pmic@0/adc@3100/adc-chan@0x06: unit 
> name should not have leading "0x"
> arch/arm64/boot/dts/qcom/pm8998.dtsi:81.18-84.6: Warning 
> (unit_address_format): /soc/spmi@c44/pmic@0/adc@3100/adc-chan@0x06: unit 
> name should not have leading 0s
>
> Signed-off-by: Vinod Koul 

Reviewed-by: Amit Kucheria 


> ---
>  arch/arm64/boot/dts/qcom/pm8998.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/pm8998.dtsi 
> b/arch/arm64/boot/dts/qcom/pm8998.dtsi
> index 051a52df80f9..dc2ce23cde05 100644
> --- a/arch/arm64/boot/dts/qcom/pm8998.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pm8998.dtsi
> @@ -78,7 +78,7 @@
> #size-cells = <0>;
> #io-channel-cells = <1>;
>
> -   adc-chan@ADC5_DIE_TEMP {
> +   adc-chan@6 {
> reg = ;
> label = "die_temp";
> };
> --
> 2.20.1
>