Re: [PATCH v2 4/5] net: dsa: mv88e6xxx: implement watchdog_ops for mv88e6250

2019-05-24 Thread Vivien Didelot 
On Fri, 24 May 2019 09:00:29 +, Rasmus Villemoes 
 wrote:
> The MV88E6352_G2_WDOG_CTL_* bits almost, but not quite, describe the
> watchdog control register on the mv88e6250. Among those actually
> referenced in the code, only QC_ENABLE differs (bit 6 rather than bit
> 5).
> 
> Signed-off-by: Rasmus Villemoes 

Clean patch,

Reviewed-by: Vivien Didelot 

Thanks,
Vivien

Re: [PATCH v2 4/5] net: dsa: mv88e6xxx: implement watchdog_ops for mv88e6250

2019-05-24 Thread Andrew Lunn 
On Fri, May 24, 2019 at 09:00:29AM +, Rasmus Villemoes wrote:
> The MV88E6352_G2_WDOG_CTL_* bits almost, but not quite, describe the
> watchdog control register on the mv88e6250. Among those actually
> referenced in the code, only QC_ENABLE differs (bit 6 rather than bit
> 5).

Marvell hardware engineers do like to keep software engineers busy :-(

> Signed-off-by: Rasmus Villemoes 

Reviewed-by: Andrew Lunn 

Andrew