Re: [PATCH v2 4/5] watchdog: hpwdt: Module paramerter alias.

[Guenter Roeck]

On 08/08/2018 12:13 PM, Jerry Hoemann wrote:

Add module parameter "timeout" as an alias to "soft_margin."
This aligns hpwdt usage more closely with other WDT while
retaining backwards compatibility.

Signed-off-by: Jerry Hoemann <jerry.hoem...@hpe.com>

Reviewed-by: Guenter Roeck <li...@roeck-us.net>

---
  drivers/watchdog/hpwdt.c | 3 +++
  1 file changed, 3 insertions(+)

diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c
index 69a88b1..eb947bc 100644
--- a/drivers/watchdog/hpwdt.c
+++ b/drivers/watchdog/hpwdt.c
@@ -367,6 +367,9 @@ static void hpwdt_exit(struct pci_dev *dev)
  module_param(soft_margin, int, 0);
  MODULE_PARM_DESC(soft_margin, "Watchdog timeout in seconds");

+module_param_named(timeout, soft_margin, int, 0);

+MODULE_PARM_DESC(timeout, "Alias of soft_margin");
+
  module_param(nowayout, bool, 0);
  MODULE_PARM_DESC(nowayout, "Watchdog cannot be stopped once started (default="
                __MODULE_STRING(WATCHDOG_NOWAYOUT) ")");