Re: [PATCH v3] netconsole: Add tty driver
On Wed, 2 Apr 2014 19:59:04 +0100 Struan Bartlett wrote: > Adds tty driver to netconsole module. NAK You don't need to add a tty driver to any console to do this. We have a ttyprintk driver that works with *any* console today. Alan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v3] netconsole: Add tty driver
On Wed, 2 Apr 2014 19:59:04 +0100 Struan Bartlett struan.bartl...@gmail.com wrote: Adds tty driver to netconsole module. NAK You don't need to add a tty driver to any console to do this. We have a ttyprintk driver that works with *any* console today. Alan -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v3] netconsole: Add tty driver
Struan Bartlett :
[...]
> --- a/drivers/net/netconsole.c2014-03-31 04:40:15.0 +0100
> +++ b/drivers/net/netconsole.c2014-04-01 11:58:50.0 +0100
> @@ -15,6 +15,7 @@
> * generic card hooks
> * works non-modular
> * 2003-09-07rewritten with netpoll api
> + * 2014-03-31tty driver by Struan Bartlett
Useless.
[...]
> +static int netconsole_tty_put_char(struct tty_struct *tty, unsigned char ch)
> +{
> + char temp[2] = { ch, 0 };
> + _write_msg(temp, 1);
Please add an empty line after declaration.
[...]
> @@ -802,11 +857,39 @@ static int __init init_netconsole(void)
> if (err)
> goto undonotifier;
>
> + netconsole_tty_driver = alloc_tty_driver(1);
alloc_tty_driver is said deprecated in include/linux/tty_driver.h
http://marc.info/?l=linux-netdev=139629339513575 may delay things a bit.
If so please be patient.
--
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v3] netconsole: Add tty driver
Struan Bartlett struan.bartl...@gmail.com :
[...]
--- a/drivers/net/netconsole.c2014-03-31 04:40:15.0 +0100
+++ b/drivers/net/netconsole.c2014-04-01 11:58:50.0 +0100
@@ -15,6 +15,7 @@
* generic card hooks
* works non-modular
* 2003-09-07rewritten with netpoll api
+ * 2014-03-31tty driver by Struan Bartlett
Useless.
[...]
+static int netconsole_tty_put_char(struct tty_struct *tty, unsigned char ch)
+{
+ char temp[2] = { ch, 0 };
+ _write_msg(temp, 1);
Please add an empty line after declaration.
[...]
@@ -802,11 +857,39 @@ static int __init init_netconsole(void)
if (err)
goto undonotifier;
+ netconsole_tty_driver = alloc_tty_driver(1);
alloc_tty_driver is said deprecated in include/linux/tty_driver.h
http://marc.info/?l=linux-netdevm=139629339513575 may delay things a bit.
If so please be patient.
--
Ueimor
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
