Re: [PATCH v3] sched: Provide USF for the portable equipment.

2020-08-03 Thread Randy Dunlap
On 8/3/20 7:31 AM, Dongdong Yang wrote:
> diff --git a/drivers/staging/Kconfig b/drivers/staging/Kconfig
> index 4ec5528..05b231e 100644
> --- a/drivers/staging/Kconfig
> +++ b/drivers/staging/Kconfig
> @@ -120,4 +120,6 @@ source "drivers/staging/qlge/Kconfig"
>  
>  source "drivers/staging/wfx/Kconfig"
>  
> +source "drivers/staging/fbsched/Kconfig"

where is this fbsched/Kconfig and its associated source files?

> +
>  endif # STAGING


-- 
~Randy



Re: [PATCH v3] sched: Provide USF for the portable equipment.

2020-08-03 Thread Greg KH
On Mon, Aug 03, 2020 at 10:31:15PM +0800, Dongdong Yang wrote:
> + /*
> +  * create a sched_usf in cpu_subsys:
> +  * /sys/devices/system/cpu/sched_usf/...

I thought I asked you not to use a "raw" kobject, you are making this
much harder than it has to be.

Just use a normal struct device.

Also you failed to document your new sysfs files in Documentation/ABI/
like is required :(

Because of both of those things, this isn't ok as-is, sorry.

greg k-h