Re: [PATCH v3 0/9] Migrate Tegra to common clock framework
On 01/04/2013 02:40 AM, Prashant Gaikwad wrote: > This patchset does following: > 1. Decompose single tegra clock structure into multiple clocks. > 2. Try to use standard clock types supported by common clock framework. > 3. Use dynamic initialization. > 4. Move all clock code to drivers/clk/tegra from mach-tegra. > 5. Add device tree support for Tegra20 and Tegra30 clocks. > 6. Remove all legacy clock code from mach-tegra. I think there are bugs here. I applied all your clock patches on top of Tegra's for-next (see list below), and found that the following don't work on Springbank: * HDMI display * Audio playback * WiFi I imagine the same issue would be seen on Harmony or Ventana since they're very similar. All of those functions work fine with Tegra's for-next branch (commit 5e30b49 "Merge branch 'for-3.9/defconfig' into for-next"). I didn't try Tegra30. I assume you'll test both SoCs... 864e964 clk: vexpress: Use common of_clk_init() function c4e8389 clk: zynq: Use common of_clk_init() function 2c9ff0c clk: vt8500: Use common of_clk_init() function db9c59c clk: highbank: Use common of_clk_init() function b40949b clk: sunxi: Use common of_clk_init() function f6d1492 clk: tegra: Use common of_clk_init() function f6fd2eb clk: add common of_clk_init() function 70a8ea3 clk: tegra30: remove unused TEGRA_CLK_DUPLICATE()s 3945e4f clk: tegra20: remove unused TEGRA_CLK_DUPLICATE()s 587bcca arm: tegra30: remove auxdata 52b982f arm: tegra20: remove auxdata 3381359 ASoC: tegra: remove auxdata d31ea1b ARM: dt: tegra30: Add clock information 542ddb5 ARM: dt: tegra20: Add clock information dd19f5f arm: tegra: Remove legacy clock code aaf17b6 arm: tegra: Migrate to new clock code 458a3ae clk: tegra: add clock support for tegra30 edb65f1 clk: tegra: add clock support for tegra20 1786e1f ARM: Tegra: Define Tegra30 CAR binding 7d77415 ARM: tegra: Define Tegra20 CAR binding a4798fa arm: tegra: Move tegra_cpu_car.h to linux/clk/tegra.h df05a02 clk: tegra: Add tegra specific clocks ad00a81 ARM: tegra: Add function to read chipid -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v3 0/9] Migrate Tegra to common clock framework
On Fri, 2013-01-04 at 17:40 +0800, Prashant Gaikwad wrote: > This patchset does following: > 1. Decompose single tegra clock structure into multiple clocks. > 2. Try to use standard clock types supported by common clock framework. > 3. Use dynamic initialization. > 4. Move all clock code to drivers/clk/tegra from mach-tegra. > 5. Add device tree support for Tegra20 and Tegra30 clocks. > 6. Remove all legacy clock code from mach-tegra. > > Tested on Tegra30 (Cardhu) and Tegra20 (Ventana). > > Changes from v2: > Removed APB MISC node. > Fixed some issues reported by Joseph Lo. > Added function to read chip id revision register. > > Changes from v1: > Rebased on linux-next for 20121224. > > Prashant Gaikwad (8): > ARM: tegra: Add function to read chipid > clk: tegra: Add tegra specific clocks > arm: tegra: Move tegra_cpu_car.h to linux/clk/tegra.h > ARM: Tegra: Define Tegra30 CAR binding > clk: tegra: add clock support for tegra20 > clk: tegra: add clock support for tegra30 > arm: tegra: Migrate to new clock code > arm: tegra: Remove legacy clock code > > Stephen Warren (1): > ARM: tegra: Define Tegra20 CAR binding > Good job, Prashant. :-) This series : Tested-by: Joseph Lo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/