Re: [PATCH v3 00/16] slab accounting for memcg
On 09/22/2012 12:46 AM, Tejun Heo wrote: > Hello, > > On Tue, Sep 18, 2012 at 06:11:54PM +0400, Glauber Costa wrote: >> This is a followup to the previous kmem series. I divided them logically >> so it gets easier for reviewers. But I believe they are ready to be merged >> together (although we can do a two-pass merge if people would prefer) >> >> Throwaway git tree found at: >> >> git://git.kernel.org/pub/scm/linux/kernel/git/glommer/memcg.git >> kmemcg-slab >> >> There are mostly bugfixes since last submission. >> >> For a detailed explanation about this series, please refer to my previous >> post >> (Subj: [PATCH v3 00/13] kmem controller for memcg.) > > In general, things look good to me. I think the basic approach is > manageable and does a decent job of avoiding introducing complications > on the usual code paths. > > Pekka seems generally happy with the approach too. Christoph, what do > you think? > > Thanks. > I myself think that while the approach is okay, this would need one or two more versions for us to sort out some issues that are still remaining. I'd very much like to have the kmemcg-stack series seeing its way forward first. Mel Gorman said he would try his best to review it his week, and I don't plan to resubmit anything before that. After that, I plan to rebase at least this one again. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v3 00/16] slab accounting for memcg
On Fri, Sep 21, 2012 at 01:46:19PM -0700, Tejun Heo wrote: > In general, things look good to me. I think the basic approach is > manageable and does a decent job of avoiding introducing complications > on the usual code paths. > > Pekka seems generally happy with the approach too. Christoph, what do > you think? Ooh, also, why aren't Andrew and Michal not cc'd? -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v3 00/16] slab accounting for memcg
Hello, On Tue, Sep 18, 2012 at 06:11:54PM +0400, Glauber Costa wrote: > This is a followup to the previous kmem series. I divided them logically > so it gets easier for reviewers. But I believe they are ready to be merged > together (although we can do a two-pass merge if people would prefer) > > Throwaway git tree found at: > > git://git.kernel.org/pub/scm/linux/kernel/git/glommer/memcg.git > kmemcg-slab > > There are mostly bugfixes since last submission. > > For a detailed explanation about this series, please refer to my previous post > (Subj: [PATCH v3 00/13] kmem controller for memcg.) In general, things look good to me. I think the basic approach is manageable and does a decent job of avoiding introducing complications on the usual code paths. Pekka seems generally happy with the approach too. Christoph, what do you think? Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v3 00/16] slab accounting for memcg
On 09/21/2012 01:40 PM, Pekka Enberg wrote: > Hi Glauber, > > On Tue, Sep 18, 2012 at 5:11 PM, Glauber Costa wrote: >> This is a followup to the previous kmem series. I divided them logically >> so it gets easier for reviewers. But I believe they are ready to be merged >> together (although we can do a two-pass merge if people would prefer) >> >> Throwaway git tree found at: >> >> git://git.kernel.org/pub/scm/linux/kernel/git/glommer/memcg.git >> kmemcg-slab >> >> There are mostly bugfixes since last submission. > > Overall, I like this series a lot. However, I don't really see this as a > v3.7 material because we already have largeish pending updates to the > slab allocators. I also haven't seen any performance numbers for this > which is a problem. > > So what I'd really like to see is this series being merged early in the > v3.8 development cycle to maximize the number of people eyeballing the > code and looking at performance impact. > > Does this sound reasonable to you Glauber? Absolutely. As I've stated before, I actually believe the kmemcg-stack and kmemcg-slab (this one) portions should be merged separately. (So we can sort out issues more easily, and point to the right place) The first one is a lot more stable and got a lot more love. The goal of this one is to get it reviewed so we can merge as soon as we can - but not sooner. early v3.8 sounds perfect to me. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v3 00/16] slab accounting for memcg
Hi Glauber, On Tue, Sep 18, 2012 at 5:11 PM, Glauber Costa wrote: > This is a followup to the previous kmem series. I divided them logically > so it gets easier for reviewers. But I believe they are ready to be merged > together (although we can do a two-pass merge if people would prefer) > > Throwaway git tree found at: > > git://git.kernel.org/pub/scm/linux/kernel/git/glommer/memcg.git > kmemcg-slab > > There are mostly bugfixes since last submission. Overall, I like this series a lot. However, I don't really see this as a v3.7 material because we already have largeish pending updates to the slab allocators. I also haven't seen any performance numbers for this which is a problem. So what I'd really like to see is this series being merged early in the v3.8 development cycle to maximize the number of people eyeballing the code and looking at performance impact. Does this sound reasonable to you Glauber? Pekka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
