Re: [PATCH v3 01/18] coresight replicator: Cleanup programmable replicator naming
On 17/07/17 18:45, Mathieu Poirier wrote: On Fri, Jul 14, 2017 at 02:04:06PM +0100, Suzuki K Poulose wrote: The Linux coresight drivers define the programmable ATB replicator as Qualcomm replicator, while this is designed by ARM. This can cause confusion to a user selecting the driver. Cleanup all references to make it explicitly clear. This patch : 1) Replace the compatible string for the replicator : qcom,coresight-replicator1x => arm,coresight-dynamic-replicator 2) Changes the Kconfig symbol (since this is not part of any defconfigs) CORESIGHT_QCOM_REPLICATOR => CORESIGHT_DYNAMIC_REPLICATOR 3) Improves the help message in the Kconfig. 4) Changes the name of the driver and the file : coresight-replicator-qcom => coresight-dynamic-replicator Cc: Pratik Patel Cc: Ivan T. Ivanov Cc: Mathieu Poirier Cc: devicet...@vger.kernel.org Cc: Mark Rutland Acked-by: Rob Herring Signed-off-by: Suzuki K Poulose --- Changes since V1: - Since the driver doesn't use the compatible string, change the recommended compatible string. - Rename the driver file to coresight-dynamic-replicator.c --- .../devicetree/bindings/arm/coresight.txt | 4 +- drivers/hwtracing/coresight/Kconfig| 10 +- drivers/hwtracing/coresight/Makefile | 2 +- .../coresight/coresight-dynamic-replicator.c | 195 .../coresight/coresight-replicator-qcom.c | 196 - 5 files changed, 203 insertions(+), 204 deletions(-) create mode 100644 drivers/hwtracing/coresight/coresight-dynamic-replicator.c delete mode 100644 drivers/hwtracing/coresight/coresight-replicator-qcom.c diff --git a/Documentation/devicetree/bindings/arm/coresight.txt b/Documentation/devicetree/bindings/arm/coresight.txt index fcbae6a..15ac8e8 100644 --- a/Documentation/devicetree/bindings/arm/coresight.txt +++ b/Documentation/devicetree/bindings/arm/coresight.txt @@ -34,8 +34,8 @@ its hardware characteristcs. - Embedded Trace Macrocell (version 4.x): "arm,coresight-etm4x", "arm,primecell"; - - Qualcomm Configurable Replicator (version 1.x): - "qcom,coresight-replicator1x", "arm,primecell"; + - Coresight programmable Replicator : + "arm,coresight-dynamic-replicator", "arm,primecell"; - System Trace Macrocell: "arm,coresight-stm", "arm,primecell"; [1] diff --git a/drivers/hwtracing/coresight/Kconfig b/drivers/hwtracing/coresight/Kconfig index 8d55d6d..ef9cb3c 100644 --- a/drivers/hwtracing/coresight/Kconfig +++ b/drivers/hwtracing/coresight/Kconfig @@ -70,13 +70,13 @@ config CORESIGHT_SOURCE_ETM4X for instruction level tracing. Depending on the implemented version data tracing may also be available. -config CORESIGHT_QCOM_REPLICATOR - bool "Qualcomm CoreSight Replicator driver" +config CORESIGHT_DYNAMIC_REPLICATOR + bool "CoreSight Programmable Replicator driver" depends on CORESIGHT_LINKS_AND_SINKS help - This enables support for Qualcomm CoreSight link driver. The - programmable ATB replicator sends the ATB trace stream from the - ETB/ETF to the TPIUi and ETR. + This enables support for dynamic CoreSight replicator link driver. + The programmable ATB replicator allows independent filtering of the + trace data based on the traceid. config CORESIGHT_STM bool "CoreSight System Trace Macrocell driver" diff --git a/drivers/hwtracing/coresight/Makefile b/drivers/hwtracing/coresight/Makefile index 433d590..5bae90ce 100644 --- a/drivers/hwtracing/coresight/Makefile +++ b/drivers/hwtracing/coresight/Makefile @@ -14,6 +14,6 @@ obj-$(CONFIG_CORESIGHT_SOURCE_ETM3X) += coresight-etm3x.o coresight-etm-cp14.o \ coresight-etm3x-sysfs.o obj-$(CONFIG_CORESIGHT_SOURCE_ETM4X) += coresight-etm4x.o \ coresight-etm4x-sysfs.o -obj-$(CONFIG_CORESIGHT_QCOM_REPLICATOR) += coresight-replicator-qcom.o +obj-$(CONFIG_CORESIGHT_DYNAMIC_REPLICATOR) += coresight-dynamic-replicator.o obj-$(CONFIG_CORESIGHT_STM) += coresight-stm.o obj-$(CONFIG_CORESIGHT_CPU_DEBUG) += coresight-cpu-debug.o diff --git a/drivers/hwtracing/coresight/coresight-dynamic-replicator.c b/drivers/hwtracing/coresight/coresight-dynamic-replicator.c new file mode 100644 index 000..1675031 --- /dev/null +++ b/drivers/hwtracing/coresight/coresight-dynamic-replicator.c @@ -0,0 +1,195 @@ +/* + * Copyright (c) 2011-2015, The Linux Foundation. All rights reserved. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 and + * only version 2 as published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY;
Re: [PATCH v3 01/18] coresight replicator: Cleanup programmable replicator naming
On Fri, Jul 14, 2017 at 02:04:06PM +0100, Suzuki K Poulose wrote: > The Linux coresight drivers define the programmable ATB replicator as > Qualcomm replicator, while this is designed by ARM. This can cause confusion > to a user selecting the driver. Cleanup all references to make it > explicitly clear. This patch : > > 1) Replace the compatible string for the replicator : > qcom,coresight-replicator1x => arm,coresight-dynamic-replicator > 2) Changes the Kconfig symbol (since this is not part of any defconfigs) >CORESIGHT_QCOM_REPLICATOR => CORESIGHT_DYNAMIC_REPLICATOR > 3) Improves the help message in the Kconfig. > 4) Changes the name of the driver and the file : > coresight-replicator-qcom => coresight-dynamic-replicator > > Cc: Pratik Patel > Cc: Ivan T. Ivanov > Cc: Mathieu Poirier > Cc: devicet...@vger.kernel.org > Cc: Mark Rutland > Acked-by: Rob Herring > Signed-off-by: Suzuki K Poulose > --- > Changes since V1: > - Since the driver doesn't use the compatible string, change the >recommended compatible string. > - Rename the driver file to coresight-dynamic-replicator.c > --- > .../devicetree/bindings/arm/coresight.txt | 4 +- > drivers/hwtracing/coresight/Kconfig| 10 +- > drivers/hwtracing/coresight/Makefile | 2 +- > .../coresight/coresight-dynamic-replicator.c | 195 > .../coresight/coresight-replicator-qcom.c | 196 > - > 5 files changed, 203 insertions(+), 204 deletions(-) > create mode 100644 drivers/hwtracing/coresight/coresight-dynamic-replicator.c > delete mode 100644 drivers/hwtracing/coresight/coresight-replicator-qcom.c > > diff --git a/Documentation/devicetree/bindings/arm/coresight.txt > b/Documentation/devicetree/bindings/arm/coresight.txt > index fcbae6a..15ac8e8 100644 > --- a/Documentation/devicetree/bindings/arm/coresight.txt > +++ b/Documentation/devicetree/bindings/arm/coresight.txt > @@ -34,8 +34,8 @@ its hardware characteristcs. > - Embedded Trace Macrocell (version 4.x): > "arm,coresight-etm4x", "arm,primecell"; > > - - Qualcomm Configurable Replicator (version 1.x): > - "qcom,coresight-replicator1x", "arm,primecell"; > + - Coresight programmable Replicator : > + "arm,coresight-dynamic-replicator", "arm,primecell"; > > - System Trace Macrocell: > "arm,coresight-stm", "arm,primecell"; [1] > diff --git a/drivers/hwtracing/coresight/Kconfig > b/drivers/hwtracing/coresight/Kconfig > index 8d55d6d..ef9cb3c 100644 > --- a/drivers/hwtracing/coresight/Kconfig > +++ b/drivers/hwtracing/coresight/Kconfig > @@ -70,13 +70,13 @@ config CORESIGHT_SOURCE_ETM4X > for instruction level tracing. Depending on the implemented version > data tracing may also be available. > > -config CORESIGHT_QCOM_REPLICATOR > - bool "Qualcomm CoreSight Replicator driver" > +config CORESIGHT_DYNAMIC_REPLICATOR > + bool "CoreSight Programmable Replicator driver" > depends on CORESIGHT_LINKS_AND_SINKS > help > - This enables support for Qualcomm CoreSight link driver. The > - programmable ATB replicator sends the ATB trace stream from the > - ETB/ETF to the TPIUi and ETR. > + This enables support for dynamic CoreSight replicator link driver. > + The programmable ATB replicator allows independent filtering of the > + trace data based on the traceid. > > config CORESIGHT_STM > bool "CoreSight System Trace Macrocell driver" > diff --git a/drivers/hwtracing/coresight/Makefile > b/drivers/hwtracing/coresight/Makefile > index 433d590..5bae90ce 100644 > --- a/drivers/hwtracing/coresight/Makefile > +++ b/drivers/hwtracing/coresight/Makefile > @@ -14,6 +14,6 @@ obj-$(CONFIG_CORESIGHT_SOURCE_ETM3X) += coresight-etm3x.o > coresight-etm-cp14.o \ > coresight-etm3x-sysfs.o > obj-$(CONFIG_CORESIGHT_SOURCE_ETM4X) += coresight-etm4x.o \ > coresight-etm4x-sysfs.o > -obj-$(CONFIG_CORESIGHT_QCOM_REPLICATOR) += coresight-replicator-qcom.o > +obj-$(CONFIG_CORESIGHT_DYNAMIC_REPLICATOR) += coresight-dynamic-replicator.o > obj-$(CONFIG_CORESIGHT_STM) += coresight-stm.o > obj-$(CONFIG_CORESIGHT_CPU_DEBUG) += coresight-cpu-debug.o > diff --git a/drivers/hwtracing/coresight/coresight-dynamic-replicator.c > b/drivers/hwtracing/coresight/coresight-dynamic-replicator.c > new file mode 100644 > index 000..1675031 > --- /dev/null > +++ b/drivers/hwtracing/coresight/coresight-dynamic-replicator.c > @@ -0,0 +1,195 @@ > +/* > + * Copyright (c) 2011-2015, The Linux Foundation. All rights reserved. > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 and > + * only version 2 as published by the Free Software
