Re: [PATCH v3 06/27] gpio: replace devm_ioremap_nocache with devm_ioremap

[Linus Walleij]

On Wed, Jan 3, 2018 at 7:05 AM, Yisheng Xie  wrote:
> On 2018/1/2 16:41, Linus Walleij wrote:
>> On Sat, Dec 23, 2017 at 11:58 AM, Yisheng Xie  wrote:
>>
>>> Default ioremap is ioremap_nocache, so devm_ioremap has the same
>>> function with devm_ioremap_nocache, which can just be killed to
>>> save the size of devres.o
>>>
>>> This patch is to use use devm_ioremap instead of devm_ioremap_nocache,
>>> which should not have any function change but prepare for killing
>>> devm_ioremap_nocache.
>>>
>>> Cc: Linus Walleij 
>>> Cc: linux-g...@vger.kernel.org
>>> Signed-off-by: Yisheng Xie 
>
> Well, I list the ARCHs related to the change file, do not include 
> cris,ia64,mn10300
> and openrisc, which ioremap is not the same as ioremap_nocache, as discussed 
> in cover
> letter. So please let me know if I need update the comment.

I dropped the patch until it's figured out that none of these arches
are affected
by the change.

Please resend with a comment explaining why the change is harmless on the
architectures these drivers are for.

Yours,
Linus Walleij

Re: [PATCH v3 06/27] gpio: replace devm_ioremap_nocache with devm_ioremap

[Linus Walleij]

On Wed, Jan 3, 2018 at 7:05 AM, Yisheng Xie  wrote:
> On 2018/1/2 16:41, Linus Walleij wrote:
>> On Sat, Dec 23, 2017 at 11:58 AM, Yisheng Xie  wrote:
>>
>>> Default ioremap is ioremap_nocache, so devm_ioremap has the same
>>> function with devm_ioremap_nocache, which can just be killed to
>>> save the size of devres.o
>>>
>>> This patch is to use use devm_ioremap instead of devm_ioremap_nocache,
>>> which should not have any function change but prepare for killing
>>> devm_ioremap_nocache.
>>>
>>> Cc: Linus Walleij 
>>> Cc: linux-g...@vger.kernel.org
>>> Signed-off-by: Yisheng Xie 
>
> Well, I list the ARCHs related to the change file, do not include 
> cris,ia64,mn10300
> and openrisc, which ioremap is not the same as ioremap_nocache, as discussed 
> in cover
> letter. So please let me know if I need update the comment.

I dropped the patch until it's figured out that none of these arches
are affected
by the change.

Please resend with a comment explaining why the change is harmless on the
architectures these drivers are for.

Yours,
Linus Walleij

Re: [PATCH v3 06/27] gpio: replace devm_ioremap_nocache with devm_ioremap

[Yisheng Xie]

On 2018/1/2 16:41, Linus Walleij wrote:
> On Sat, Dec 23, 2017 at 11:58 AM, Yisheng Xie  wrote:
> 
>> Default ioremap is ioremap_nocache, so devm_ioremap has the same
>> function with devm_ioremap_nocache, which can just be killed to
>> save the size of devres.o
>>
>> This patch is to use use devm_ioremap instead of devm_ioremap_nocache,
>> which should not have any function change but prepare for killing
>> devm_ioremap_nocache.
>>
>> Cc: Linus Walleij 
>> Cc: linux-g...@vger.kernel.org
>> Signed-off-by: Yisheng Xie 

Well, I list the ARCHs related to the change file, do not include 
cris,ia64,mn10300
and openrisc, which ioremap is not the same as ioremap_nocache, as discussed in 
cover
letter. So please let me know if I need update the comment.

 change_fileARCH
 drivers/gpio/gpio-ath79.c | 3 +--  mips
 drivers/gpio/gpio-em.c| 6 ++   arm
 drivers/gpio/gpio-htc-egpio.c | 4 ++-- arm
 drivers/gpio/gpio-xgene.c | 3 +--  arm64

Thanks
Yisheng
> 
> Patch applied.
> 
> Yours,
> Linus Walleij
> 
> 

Re: [PATCH v3 06/27] gpio: replace devm_ioremap_nocache with devm_ioremap

[Yisheng Xie]

On 2018/1/2 16:41, Linus Walleij wrote:
> On Sat, Dec 23, 2017 at 11:58 AM, Yisheng Xie  wrote:
> 
>> Default ioremap is ioremap_nocache, so devm_ioremap has the same
>> function with devm_ioremap_nocache, which can just be killed to
>> save the size of devres.o
>>
>> This patch is to use use devm_ioremap instead of devm_ioremap_nocache,
>> which should not have any function change but prepare for killing
>> devm_ioremap_nocache.
>>
>> Cc: Linus Walleij 
>> Cc: linux-g...@vger.kernel.org
>> Signed-off-by: Yisheng Xie 

Well, I list the ARCHs related to the change file, do not include 
cris,ia64,mn10300
and openrisc, which ioremap is not the same as ioremap_nocache, as discussed in 
cover
letter. So please let me know if I need update the comment.

 change_fileARCH
 drivers/gpio/gpio-ath79.c | 3 +--  mips
 drivers/gpio/gpio-em.c| 6 ++   arm
 drivers/gpio/gpio-htc-egpio.c | 4 ++-- arm
 drivers/gpio/gpio-xgene.c | 3 +--  arm64

Thanks
Yisheng
> 
> Patch applied.
> 
> Yours,
> Linus Walleij
> 
> 

Re: [PATCH v3 06/27] gpio: replace devm_ioremap_nocache with devm_ioremap

[Linus Walleij]

On Sat, Dec 23, 2017 at 11:58 AM, Yisheng Xie  wrote:

> Default ioremap is ioremap_nocache, so devm_ioremap has the same
> function with devm_ioremap_nocache, which can just be killed to
> save the size of devres.o
>
> This patch is to use use devm_ioremap instead of devm_ioremap_nocache,
> which should not have any function change but prepare for killing
> devm_ioremap_nocache.
>
> Cc: Linus Walleij 
> Cc: linux-g...@vger.kernel.org
> Signed-off-by: Yisheng Xie 

Patch applied.

Yours,
Linus Walleij

Re: [PATCH v3 06/27] gpio: replace devm_ioremap_nocache with devm_ioremap

[Linus Walleij]

On Sat, Dec 23, 2017 at 11:58 AM, Yisheng Xie  wrote:

> Default ioremap is ioremap_nocache, so devm_ioremap has the same
> function with devm_ioremap_nocache, which can just be killed to
> save the size of devres.o
>
> This patch is to use use devm_ioremap instead of devm_ioremap_nocache,
> which should not have any function change but prepare for killing
> devm_ioremap_nocache.
>
> Cc: Linus Walleij 
> Cc: linux-g...@vger.kernel.org
> Signed-off-by: Yisheng Xie 

Patch applied.

Yours,
Linus Walleij