Re: [PATCH v3 1/2] audit: document /proc/PID/loginuid
Em Thu, 18 Mar 2021 15:19:10 -0400
Richard Guy Briggs escreveu:
> Describe the /proc/PID/loginuid interface in Documentation/ABI/stable that
> was added 2005-02-01 by commit 1e2d1492e178 ("[PATCH] audit: handle
> loginuid through proc")
>
> Signed-off-by: Richard Guy Briggs
> ---
> Documentation/ABI/stable/procfs-audit_loginuid | 15 +++
> 1 file changed, 15 insertions(+)
> create mode 100644 Documentation/ABI/stable/procfs-audit_loginuid
>
> diff --git a/Documentation/ABI/stable/procfs-audit_loginuid
> b/Documentation/ABI/stable/procfs-audit_loginuid
> new file mode 100644
> index ..e7c100b9ab18
> --- /dev/null
> +++ b/Documentation/ABI/stable/procfs-audit_loginuid
> @@ -0,0 +1,15 @@
> +What:Audit Login UID
> +Date:2005-02-01
> +KernelVersion: 2.6.11-rc2 1e2d1492e178 ("[PATCH] audit: handle
> loginuid through proc")
> +Contact: linux-au...@redhat.com
> +Format: %u
The ABI definition doesn't include a "Format:" symbol. See:
Documentation/ABI/README
For the valid ones.
This change causes a warning at the ABI parser:
$ ./scripts/get_abi.pl validate
Warning: file Documentation/ABI/stable/procfs-audit_loginuid#5:
tag 'contact' is invalid. Line
Format: %u
Warning: file Documentation/ABI/stable/procfs-audit_loginuid#21:
tag 'contact' is invalid. Line
Format: %u
You should either drop it or add it to the parser and to the README
file, if the ABI maintainers are ok with such new field.
Thanks,
Mauro
Re: [PATCH v3 1/2] audit: document /proc/PID/loginuid
On 2021-04-01 09:57, Paul Moore wrote:
> On Thu, Apr 1, 2021 at 9:48 AM Mauro Carvalho Chehab
> wrote:
> > Em Thu, 18 Mar 2021 15:19:10 -0400
> > Richard Guy Briggs escreveu:
> > > Describe the /proc/PID/loginuid interface in Documentation/ABI/stable that
> > > was added 2005-02-01 by commit 1e2d1492e178 ("[PATCH] audit: handle
> > > loginuid through proc")
> > >
> > > Signed-off-by: Richard Guy Briggs
> > > ---
> > > Documentation/ABI/stable/procfs-audit_loginuid | 15 +++
> > > 1 file changed, 15 insertions(+)
> > > create mode 100644 Documentation/ABI/stable/procfs-audit_loginuid
> > >
> > > diff --git a/Documentation/ABI/stable/procfs-audit_loginuid
> > > b/Documentation/ABI/stable/procfs-audit_loginuid
> > > new file mode 100644
> > > index ..e7c100b9ab18
> > > --- /dev/null
> > > +++ b/Documentation/ABI/stable/procfs-audit_loginuid
> > > @@ -0,0 +1,15 @@
> > > +What:Audit Login UID
> > > +Date:2005-02-01
> > > +KernelVersion: 2.6.11-rc2 1e2d1492e178 ("[PATCH] audit: handle
> > > loginuid through proc")
> > > +Contact: linux-au...@redhat.com
> > > +Format: %u
> >
> > The ABI definition doesn't include a "Format:" symbol. See:
> >
> > Documentation/ABI/README
> >
> > For the valid ones.
> >
> > This change causes a warning at the ABI parser:
> >
> >
> > $ ./scripts/get_abi.pl validate
> > Warning: file Documentation/ABI/stable/procfs-audit_loginuid#5:
> > tag 'contact' is invalid. Line
> > Format: %u
> > Warning: file Documentation/ABI/stable/procfs-audit_loginuid#21:
> > tag 'contact' is invalid. Line
> > Format: %u
> >
> > You should either drop it or add it to the parser and to the README
> > file, if the ABI maintainers are ok with such new field.
>
> Thanks Mauro, I didn't realize there were tools that parsed these files.
>
> Richard, please post a patch that drops the 'Format:' line from the
> newly added audit files as soon as possible so I can merge it into
> audit/next.
Ok. I'll roll it into the description so we don't lose that
information.
> paul moore
- RGB
--
Richard Guy Briggs
Sr. S/W Engineer, Kernel Security, Base Operating Systems
Remote, Ottawa, Red Hat Canada
IRC: rgb, SunRaycer
Voice: +1.647.777.2635, Internal: (81) 32635
Re: [PATCH v3 1/2] audit: document /proc/PID/loginuid
On Thu, Apr 1, 2021 at 9:48 AM Mauro Carvalho Chehab
wrote:
> Em Thu, 18 Mar 2021 15:19:10 -0400
> Richard Guy Briggs escreveu:
> > Describe the /proc/PID/loginuid interface in Documentation/ABI/stable that
> > was added 2005-02-01 by commit 1e2d1492e178 ("[PATCH] audit: handle
> > loginuid through proc")
> >
> > Signed-off-by: Richard Guy Briggs
> > ---
> > Documentation/ABI/stable/procfs-audit_loginuid | 15 +++
> > 1 file changed, 15 insertions(+)
> > create mode 100644 Documentation/ABI/stable/procfs-audit_loginuid
> >
> > diff --git a/Documentation/ABI/stable/procfs-audit_loginuid
> > b/Documentation/ABI/stable/procfs-audit_loginuid
> > new file mode 100644
> > index ..e7c100b9ab18
> > --- /dev/null
> > +++ b/Documentation/ABI/stable/procfs-audit_loginuid
> > @@ -0,0 +1,15 @@
> > +What:Audit Login UID
> > +Date:2005-02-01
> > +KernelVersion: 2.6.11-rc2 1e2d1492e178 ("[PATCH] audit: handle
> > loginuid through proc")
> > +Contact: linux-au...@redhat.com
> > +Format: %u
>
> The ABI definition doesn't include a "Format:" symbol. See:
>
> Documentation/ABI/README
>
> For the valid ones.
>
> This change causes a warning at the ABI parser:
>
>
> $ ./scripts/get_abi.pl validate
> Warning: file Documentation/ABI/stable/procfs-audit_loginuid#5:
> tag 'contact' is invalid. Line
> Format: %u
> Warning: file Documentation/ABI/stable/procfs-audit_loginuid#21:
> tag 'contact' is invalid. Line
> Format: %u
>
> You should either drop it or add it to the parser and to the README
> file, if the ABI maintainers are ok with such new field.
Thanks Mauro, I didn't realize there were tools that parsed these files.
Richard, please post a patch that drops the 'Format:' line from the
newly added audit files as soon as possible so I can merge it into
audit/next.
--
paul moore
www.paul-moore.com
Re: [PATCH v3 1/2] audit: document /proc/PID/loginuid
On Thu, Mar 18, 2021 at 3:19 PM Richard Guy Briggs wrote:
>
> Describe the /proc/PID/loginuid interface in Documentation/ABI/stable that
> was added 2005-02-01 by commit 1e2d1492e178 ("[PATCH] audit: handle
> loginuid through proc")
>
> Signed-off-by: Richard Guy Briggs
> ---
> Documentation/ABI/stable/procfs-audit_loginuid | 15 +++
> 1 file changed, 15 insertions(+)
> create mode 100644 Documentation/ABI/stable/procfs-audit_loginuid
Merged into audit/next, thanks.
--
paul moore
www.paul-moore.com
