Re: [PATCH v3 1/4] include: dt-bindings: add Performance Monitoring Unit for Exynos
On 5/1/19 12:33 AM, Rob Herring wrote: > On Fri, 19 Apr 2019 15:48:05 +0200, Lukasz Luba wrote: >> This patch add support of a new feature which can be used in DT: >> Performance Monitoring Unit with defined event data type. >> In this patch the event data types are defined for Exynos PPMU. >> The patch also updates the MAINTAINERS file accordingly and >> adds the header file to devfreq event subsystem. >> >> Signed-off-by: Lukasz Luba >> --- >> MAINTAINERS | 1 + >> include/dt-bindings/pmu/exynos_ppmu.h | 26 ++ >> 2 files changed, 27 insertions(+) >> create mode 100644 include/dt-bindings/pmu/exynos_ppmu.h >> > > Reviewed-by: Rob Herring > > Thank you, added to the commit message for the next patch set version. Regards, Lukasz
Re: [PATCH v3 1/4] include: dt-bindings: add Performance Monitoring Unit for Exynos
On Fri, 19 Apr 2019 15:48:05 +0200, Lukasz Luba wrote: > This patch add support of a new feature which can be used in DT: > Performance Monitoring Unit with defined event data type. > In this patch the event data types are defined for Exynos PPMU. > The patch also updates the MAINTAINERS file accordingly and > adds the header file to devfreq event subsystem. > > Signed-off-by: Lukasz Luba > --- > MAINTAINERS | 1 + > include/dt-bindings/pmu/exynos_ppmu.h | 26 ++ > 2 files changed, 27 insertions(+) > create mode 100644 include/dt-bindings/pmu/exynos_ppmu.h > Reviewed-by: Rob Herring
Re: [PATCH v3 1/4] include: dt-bindings: add Performance Monitoring Unit for Exynos
On 4/30/19 6:56 AM, Chanwoo Choi wrote: > Hi, > > I agree of this patch. But, I add the minor comments. > > If you edit them according to my comment, feel free to add my following tag: > Acked-by: Chanwoo Choi > > On 19. 4. 19. 오후 10:48, Lukasz Luba wrote: >> This patch add support of a new feature which can be used in DT: >> Performance Monitoring Unit with defined event data type. >> In this patch the event data types are defined for Exynos PPMU. >> The patch also updates the MAINTAINERS file accordingly and >> adds the header file to devfreq event subsystem. >> >> Signed-off-by: Lukasz Luba >> --- >> MAINTAINERS | 1 + >> include/dt-bindings/pmu/exynos_ppmu.h | 26 ++ >> 2 files changed, 27 insertions(+) >> create mode 100644 include/dt-bindings/pmu/exynos_ppmu.h >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index 3671fde..1ba4b9b 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -4560,6 +4560,7 @@ T: git >> git://git.kernel.org/pub/scm/linux/kernel/git/mzx/devfreq.git >> S: Supported >> F: drivers/devfreq/event/ >> F: drivers/devfreq/devfreq-event.c >> +F: include/dt-bindings/pmu/exynos_ppmu.h >> F: include/linux/devfreq-event.h >> F: Documentation/devicetree/bindings/devfreq/event/ >> >> diff --git a/include/dt-bindings/pmu/exynos_ppmu.h >> b/include/dt-bindings/pmu/exynos_ppmu.h >> new file mode 100644 >> index 000..08fdce9 >> --- /dev/null >> +++ b/include/dt-bindings/pmu/exynos_ppmu.h >> @@ -0,0 +1,26 @@ >> +/* SPDX-License-Identifier: GPL-2.0 */ >> +/* >> + * Samsung Exynos PPMU event types for counting in regs >> + * >> + * Copyright (c) 2019, Samsung > > Mabye, "Samsung Electronics" instead of 'Samsung'. ACK > >> + * Author: Lukasz Luba >> + */ >> + >> +#ifndef __DT_BINDINGS_PMU_EXYNOS_PPMU_H >> +#define __DT_BINDINGS_PMU_EXYNOS_PPMU_H >> + >> + > > Remove unneeded blank line. OK done. I will add your 'Acked-by' in the next version. Regards, Lukasz
Re: [PATCH v3 1/4] include: dt-bindings: add Performance Monitoring Unit for Exynos
Hi, I agree of this patch. But, I add the minor comments. If you edit them according to my comment, feel free to add my following tag: Acked-by: Chanwoo Choi On 19. 4. 19. 오후 10:48, Lukasz Luba wrote: > This patch add support of a new feature which can be used in DT: > Performance Monitoring Unit with defined event data type. > In this patch the event data types are defined for Exynos PPMU. > The patch also updates the MAINTAINERS file accordingly and > adds the header file to devfreq event subsystem. > > Signed-off-by: Lukasz Luba > --- > MAINTAINERS | 1 + > include/dt-bindings/pmu/exynos_ppmu.h | 26 ++ > 2 files changed, 27 insertions(+) > create mode 100644 include/dt-bindings/pmu/exynos_ppmu.h > > diff --git a/MAINTAINERS b/MAINTAINERS > index 3671fde..1ba4b9b 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -4560,6 +4560,7 @@ T: git > git://git.kernel.org/pub/scm/linux/kernel/git/mzx/devfreq.git > S: Supported > F: drivers/devfreq/event/ > F: drivers/devfreq/devfreq-event.c > +F: include/dt-bindings/pmu/exynos_ppmu.h > F: include/linux/devfreq-event.h > F: Documentation/devicetree/bindings/devfreq/event/ > > diff --git a/include/dt-bindings/pmu/exynos_ppmu.h > b/include/dt-bindings/pmu/exynos_ppmu.h > new file mode 100644 > index 000..08fdce9 > --- /dev/null > +++ b/include/dt-bindings/pmu/exynos_ppmu.h > @@ -0,0 +1,26 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * Samsung Exynos PPMU event types for counting in regs > + * > + * Copyright (c) 2019, Samsung Mabye, "Samsung Electronics" instead of 'Samsung'. > + * Author: Lukasz Luba > + */ > + > +#ifndef __DT_BINDINGS_PMU_EXYNOS_PPMU_H > +#define __DT_BINDINGS_PMU_EXYNOS_PPMU_H > + > + Remove unneeded blank line. > +#define PPMU_RO_BUSY_CYCLE_CNT 0x0 > +#define PPMU_WO_BUSY_CYCLE_CNT 0x1 > +#define PPMU_RW_BUSY_CYCLE_CNT 0x2 > +#define PPMU_RO_REQUEST_CNT 0x3 > +#define PPMU_WO_REQUEST_CNT 0x4 > +#define PPMU_RO_DATA_CNT 0x5 > +#define PPMU_WO_DATA_CNT 0x6 > +#define PPMU_RO_LATENCY 0x12 > +#define PPMU_WO_LATENCY 0x16 > +#define PPMU_V2_RO_DATA_CNT 0x4 > +#define PPMU_V2_WO_DATA_CNT 0x5 > +#define PPMU_V2_EVT3_RW_DATA_CNT 0x22 > + > +#endif > -- Best Regards, Chanwoo Choi Samsung Electronics
