Re: [PATCH v3 1/7] dt-bindings: net: Add bindings for Realtek PHYs
On Mon, Jul 08, 2019 at 01:01:36PM -0700, Matthias Kaehlcke wrote: > On Mon, Jul 08, 2019 at 09:46:15PM +0200, Andrew Lunn wrote: > > On Mon, Jul 08, 2019 at 12:24:53PM -0700, Matthias Kaehlcke wrote: > > > Add the 'realtek,eee-led-mode-disable' property to disable EEE > > > LED mode on Realtek PHYs that support it. > > > > > > Signed-off-by: Matthias Kaehlcke > > > --- > > > TODO: adapt PHY core to deal with optional compatible strings > > > > Yes. Does this even work at the moment? I would expect > > of_mdiobus_child_is_phy() to return false, indicating the device is > > not actually a PHY. > > Indeed, it currently doesn't work atm. I found that removing the check > for dev->of_node in of_mdiobus_link_mdiodev() helps, but I imagine > doing (only) this might have undesired side-effects. O.K. Please put RFC in patches like this which don't actually work and so should not be merged. We don't want David accidentally merging them! Andrew
Re: [PATCH v3 1/7] dt-bindings: net: Add bindings for Realtek PHYs
On Mon, Jul 08, 2019 at 09:46:15PM +0200, Andrew Lunn wrote: > On Mon, Jul 08, 2019 at 12:24:53PM -0700, Matthias Kaehlcke wrote: > > Add the 'realtek,eee-led-mode-disable' property to disable EEE > > LED mode on Realtek PHYs that support it. > > > > Signed-off-by: Matthias Kaehlcke > > --- > > TODO: adapt PHY core to deal with optional compatible strings > > Yes. Does this even work at the moment? I would expect > of_mdiobus_child_is_phy() to return false, indicating the device is > not actually a PHY. Indeed, it currently doesn't work atm. I found that removing the check for dev->of_node in of_mdiobus_link_mdiodev() helps, but I imagine doing (only) this might have undesired side-effects.
Re: [PATCH v3 1/7] dt-bindings: net: Add bindings for Realtek PHYs
On Mon, Jul 08, 2019 at 12:24:53PM -0700, Matthias Kaehlcke wrote: > Add the 'realtek,eee-led-mode-disable' property to disable EEE > LED mode on Realtek PHYs that support it. > > Signed-off-by: Matthias Kaehlcke > --- > TODO: adapt PHY core to deal with optional compatible strings Yes. Does this even work at the moment? I would expect of_mdiobus_child_is_phy() to return false, indicating the device is not actually a PHY. Andrew