Re: [PATCH v3 13/16] ARM: mmp: move cputype.h to include/linux/soc/
On Mon, Sep 2, 2019 at 10:16 AM kbuild test robot wrote: > > vim +5 include/linux/soc/mmp/cputype.h > > 49cbe78637eb05 arch/arm/mach-mmp/include/mach/cputype.h Eric Miao 2009-01-20 > 4 > 49cbe78637eb05 arch/arm/mach-mmp/include/mach/cputype.h Eric Miao 2009-01-20 > @5 #include > 49cbe78637eb05 arch/arm/mach-mmp/include/mach/cputype.h Eric Miao 2009-01-20 > 6 > You can probably do something like #ifdef CONFIG_ARM #include #else static inline read_cpuid_id(void) { return 0; } #endif Then again, ideally drivers don't even have to know about this, but would distinguish between devices based on the compatible string for the particular device. Arnd
Re: [PATCH v3 13/16] ARM: mmp: move cputype.h to include/linux/soc/
Hi Lubomir, I love your patch! Yet something to improve: [auto build test ERROR on arm/for-next] [cannot apply to v5.3-rc6 next-20190830] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Lubomir-Rintel/Initial-support-for-Marvell-MMP3-SoC/20190901-110305 base: git://git.armlinux.org.uk/~rmk/linux-arm.git for-next config: x86_64-randconfig-s2-09021304 (attached as .config) compiler: gcc-7 (Debian 7.4.0-11) 7.4.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 If you fix the issue, kindly add following tag Reported-by: kbuild test robot All errors (new ones prefixed by >>): In file included from :0:0: >> include/linux/soc/mmp/cputype.h:5:10: fatal error: asm/cputype.h: No such >> file or directory #include ^~~ compilation terminated. vim +5 include/linux/soc/mmp/cputype.h 49cbe78637eb05 arch/arm/mach-mmp/include/mach/cputype.h Eric Miao 2009-01-20 4 49cbe78637eb05 arch/arm/mach-mmp/include/mach/cputype.h Eric Miao 2009-01-20 @5 #include 49cbe78637eb05 arch/arm/mach-mmp/include/mach/cputype.h Eric Miao 2009-01-20 6 :: The code at line 5 was first introduced by commit :: 49cbe78637eb0503f45fc9b556ec08918a616534 [ARM] pxa: add base support for Marvell's PXA168 processor line :: TO: Eric Miao :: CC: Eric Miao --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip