Re: [PATCH v3 16/16] arm64: dts: sdm845: enable tsens thermal zones
On Fri, Oct 26, 2018 at 01:33:40AM +0530, Amit Kucheria wrote: > On Fri, Oct 26, 2018 at 12:55 AM Matthias Kaehlcke wrote: > > > > Hi Amit, > > > > vaguely related question, since you are working on SDM845 thermal > > stuff: Do you have plans to add CPU cooling devices? I raised the > > point during the review of the CPUfreq HW, however there was no > > clear answer: https://lore.kernel.org/patchwork/patch/966833/#1164748 > > The driver is still under development/review, but I wonder what the > > path forward is. > > > > Hi Matthias, > > I plan to Great! > but the OSM driver doesn't work well enough for me to send > out that patch yet. I responded with my findings on the v9 posting > where it seems to get stuck at the high OPP. It'd be nice if somebody > else could confirm (or refute) this behaviour. Ok, we aren't using the latest version yet, I'll try to repro and report back. Cheers Matthias
Re: [PATCH v3 16/16] arm64: dts: sdm845: enable tsens thermal zones
On Fri, Oct 26, 2018 at 01:33:40AM +0530, Amit Kucheria wrote: > On Fri, Oct 26, 2018 at 12:55 AM Matthias Kaehlcke wrote: > > > > Hi Amit, > > > > vaguely related question, since you are working on SDM845 thermal > > stuff: Do you have plans to add CPU cooling devices? I raised the > > point during the review of the CPUfreq HW, however there was no > > clear answer: https://lore.kernel.org/patchwork/patch/966833/#1164748 > > The driver is still under development/review, but I wonder what the > > path forward is. > > > > Hi Matthias, > > I plan to Great! > but the OSM driver doesn't work well enough for me to send > out that patch yet. I responded with my findings on the v9 posting > where it seems to get stuck at the high OPP. It'd be nice if somebody > else could confirm (or refute) this behaviour. Ok, we aren't using the latest version yet, I'll try to repro and report back. Cheers Matthias
Re: [PATCH v3 16/16] arm64: dts: sdm845: enable tsens thermal zones
On Fri, Oct 26, 2018 at 12:55 AM Matthias Kaehlcke wrote: > > Hi Amit, > > vaguely related question, since you are working on SDM845 thermal > stuff: Do you have plans to add CPU cooling devices? I raised the > point during the review of the CPUfreq HW, however there was no > clear answer: https://lore.kernel.org/patchwork/patch/966833/#1164748 > The driver is still under development/review, but I wonder what the > path forward is. > Hi Matthias, I plan to but the OSM driver doesn't work well enough for me to send out that patch yet. I responded with my findings on the v9 posting where it seems to get stuck at the high OPP. It'd be nice if somebody else could confirm (or refute) this behaviour. Regards, Amit
Re: [PATCH v3 16/16] arm64: dts: sdm845: enable tsens thermal zones
On Fri, Oct 26, 2018 at 12:55 AM Matthias Kaehlcke wrote: > > Hi Amit, > > vaguely related question, since you are working on SDM845 thermal > stuff: Do you have plans to add CPU cooling devices? I raised the > point during the review of the CPUfreq HW, however there was no > clear answer: https://lore.kernel.org/patchwork/patch/966833/#1164748 > The driver is still under development/review, but I wonder what the > path forward is. > Hi Matthias, I plan to but the OSM driver doesn't work well enough for me to send out that patch yet. I responded with my findings on the v9 posting where it seems to get stuck at the high OPP. It'd be nice if somebody else could confirm (or refute) this behaviour. Regards, Amit
Re: [PATCH v3 16/16] arm64: dts: sdm845: enable tsens thermal zones
Hi Amit,
vaguely related question, since you are working on SDM845 thermal
stuff: Do you have plans to add CPU cooling devices? I raised the
point during the review of the CPUfreq HW, however there was no
clear answer: https://lore.kernel.org/patchwork/patch/966833/#1164748
The driver is still under development/review, but I wonder what the
path forward is.
Cheers
Matthias
On Wed, Sep 12, 2018 at 03:23:01PM +0530, Amit Kucheria wrote:
> One thermal zone per cpu is defined
>
> Signed-off-by: Amit Kucheria
> Reviewed-by: Matthias Kaehlcke
> Tested-by: Matthias Kaehlcke
> ---
> arch/arm64/boot/dts/qcom/sdm845.dtsi | 170 +++
> 1 file changed, 170 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> index 0c9a2aa6a1b5..eb801922f6bb 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -1104,4 +1104,174 @@
> };
> };
> };
> +
> + thermal-zones {
> + cpu0-thermal {
> + polling-delay-passive = <250>;
> + polling-delay = <1000>;
> +
> + thermal-sensors = < 1>;
> +
> + trips {
> + cpu_alert0: trip0 {
> + temperature = <75000>;
> + hysteresis = <2000>;
> + type = "passive";
> + };
> +
> + cpu_crit0: trip1 {
> + temperature = <11>;
> + hysteresis = <1000>;
> + type = "critical";
> + };
> + };
> + };
> +
> + cpu1-thermal {
> + polling-delay-passive = <250>;
> + polling-delay = <1000>;
> +
> + thermal-sensors = < 2>;
> +
> + trips {
> + cpu_alert1: trip0 {
> + temperature = <75000>;
> + hysteresis = <2000>;
> + type = "passive";
> + };
> +
> + cpu_crit1: trip1 {
> + temperature = <11>;
> + hysteresis = <1000>;
> + type = "critical";
> + };
> + };
> + };
> +
> + cpu2-thermal {
> + polling-delay-passive = <250>;
> + polling-delay = <1000>;
> +
> + thermal-sensors = < 3>;
> +
> + trips {
> + cpu_alert2: trip0 {
> + temperature = <75000>;
> + hysteresis = <2000>;
> + type = "passive";
> + };
> +
> + cpu_crit2: trip1 {
> + temperature = <11>;
> + hysteresis = <1000>;
> + type = "critical";
> + };
> + };
> + };
> +
> + cpu3-thermal {
> + polling-delay-passive = <250>;
> + polling-delay = <1000>;
> +
> + thermal-sensors = < 4>;
> +
> + trips {
> + cpu_alert3: trip0 {
> + temperature = <75000>;
> + hysteresis = <2000>;
> + type = "passive";
> + };
> +
> + cpu_crit3: trip1 {
> + temperature = <11>;
> + hysteresis = <1000>;
> + type = "critical";
> + };
> + };
> + };
> +
> + cpu4-thermal {
> + polling-delay-passive = <250>;
> + polling-delay = <1000>;
> +
> + thermal-sensors = < 7>;
> +
> + trips {
> + cpu_alert4: trip0 {
> + temperature = <75000>;
> + hysteresis = <2000>;
> + type = "passive";
> + };
> +
> + cpu_crit4: trip1 {
> + temperature = <11>;
> + hysteresis = <1000>;
> +
Re: [PATCH v3 16/16] arm64: dts: sdm845: enable tsens thermal zones
Hi Amit,
vaguely related question, since you are working on SDM845 thermal
stuff: Do you have plans to add CPU cooling devices? I raised the
point during the review of the CPUfreq HW, however there was no
clear answer: https://lore.kernel.org/patchwork/patch/966833/#1164748
The driver is still under development/review, but I wonder what the
path forward is.
Cheers
Matthias
On Wed, Sep 12, 2018 at 03:23:01PM +0530, Amit Kucheria wrote:
> One thermal zone per cpu is defined
>
> Signed-off-by: Amit Kucheria
> Reviewed-by: Matthias Kaehlcke
> Tested-by: Matthias Kaehlcke
> ---
> arch/arm64/boot/dts/qcom/sdm845.dtsi | 170 +++
> 1 file changed, 170 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> index 0c9a2aa6a1b5..eb801922f6bb 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -1104,4 +1104,174 @@
> };
> };
> };
> +
> + thermal-zones {
> + cpu0-thermal {
> + polling-delay-passive = <250>;
> + polling-delay = <1000>;
> +
> + thermal-sensors = < 1>;
> +
> + trips {
> + cpu_alert0: trip0 {
> + temperature = <75000>;
> + hysteresis = <2000>;
> + type = "passive";
> + };
> +
> + cpu_crit0: trip1 {
> + temperature = <11>;
> + hysteresis = <1000>;
> + type = "critical";
> + };
> + };
> + };
> +
> + cpu1-thermal {
> + polling-delay-passive = <250>;
> + polling-delay = <1000>;
> +
> + thermal-sensors = < 2>;
> +
> + trips {
> + cpu_alert1: trip0 {
> + temperature = <75000>;
> + hysteresis = <2000>;
> + type = "passive";
> + };
> +
> + cpu_crit1: trip1 {
> + temperature = <11>;
> + hysteresis = <1000>;
> + type = "critical";
> + };
> + };
> + };
> +
> + cpu2-thermal {
> + polling-delay-passive = <250>;
> + polling-delay = <1000>;
> +
> + thermal-sensors = < 3>;
> +
> + trips {
> + cpu_alert2: trip0 {
> + temperature = <75000>;
> + hysteresis = <2000>;
> + type = "passive";
> + };
> +
> + cpu_crit2: trip1 {
> + temperature = <11>;
> + hysteresis = <1000>;
> + type = "critical";
> + };
> + };
> + };
> +
> + cpu3-thermal {
> + polling-delay-passive = <250>;
> + polling-delay = <1000>;
> +
> + thermal-sensors = < 4>;
> +
> + trips {
> + cpu_alert3: trip0 {
> + temperature = <75000>;
> + hysteresis = <2000>;
> + type = "passive";
> + };
> +
> + cpu_crit3: trip1 {
> + temperature = <11>;
> + hysteresis = <1000>;
> + type = "critical";
> + };
> + };
> + };
> +
> + cpu4-thermal {
> + polling-delay-passive = <250>;
> + polling-delay = <1000>;
> +
> + thermal-sensors = < 7>;
> +
> + trips {
> + cpu_alert4: trip0 {
> + temperature = <75000>;
> + hysteresis = <2000>;
> + type = "passive";
> + };
> +
> + cpu_crit4: trip1 {
> + temperature = <11>;
> + hysteresis = <1000>;
> +
Re: [PATCH v3 16/16] arm64: dts: sdm845: enable tsens thermal zones
On Wed, Sep 12, 2018 at 03:23:01PM +0530, Amit Kucheria wrote: > One thermal zone per cpu is defined > > Signed-off-by: Amit Kucheria > Reviewed-by: Matthias Kaehlcke > Tested-by: Matthias Kaehlcke > --- > arch/arm64/boot/dts/qcom/sdm845.dtsi | 170 +++ > 1 file changed, 170 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi > b/arch/arm64/boot/dts/qcom/sdm845.dtsi > index 0c9a2aa6a1b5..eb801922f6bb 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi Acked-by: Andy Gross
Re: [PATCH v3 16/16] arm64: dts: sdm845: enable tsens thermal zones
On Wed, Sep 12, 2018 at 03:23:01PM +0530, Amit Kucheria wrote: > One thermal zone per cpu is defined > > Signed-off-by: Amit Kucheria > Reviewed-by: Matthias Kaehlcke > Tested-by: Matthias Kaehlcke > --- > arch/arm64/boot/dts/qcom/sdm845.dtsi | 170 +++ > 1 file changed, 170 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi > b/arch/arm64/boot/dts/qcom/sdm845.dtsi > index 0c9a2aa6a1b5..eb801922f6bb 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi Acked-by: Andy Gross
