Re: [PATCH v3 2/2] nvmem: Add RAVE SP EEPROM driver

2018-05-02 Thread Srinivas Kandagatla 



On 01/05/18 19:35, Andrey Smirnov wrote:

On Tue, May 1, 2018 at 8:33 AM, Srinivas Kandagatla
 wrote:



On 01/05/18 06:29, Andrey Smirnov wrote:


+// SPDX-License-Identifier: GPL-2.0+


...


+MODULE_LICENSE("GPL");


I think this should be
MODULE_LICENSE("GPL v2");


With that change the two statements would contradict each other. "GPL"
means "GNU Public License v2 or later", whereas "GPL v2" means "GNU
Public License v2" as per
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/linux/module.h#n175


Yep, You are correct, I missed the +.
I will send these patches to Greg during rc4-rc5 time.

thanks,
srini

Re: [PATCH v3 2/2] nvmem: Add RAVE SP EEPROM driver

2018-05-01 Thread Andrey Smirnov 
On Tue, May 1, 2018 at 8:33 AM, Srinivas Kandagatla
 wrote:
>
>
> On 01/05/18 06:29, Andrey Smirnov wrote:
>>
>> +// SPDX-License-Identifier: GPL-2.0+
>
> ...
>>
>> +MODULE_LICENSE("GPL");
>
> I think this should be
> MODULE_LICENSE("GPL v2");

With that change the two statements would contradict each other. "GPL"
means "GNU Public License v2 or later", whereas "GPL v2" means "GNU
Public License v2" as per
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/linux/module.h#n175

Thanks,
Andrey Smirnov

Re: [PATCH v3 2/2] nvmem: Add RAVE SP EEPROM driver

2018-05-01 Thread Srinivas Kandagatla 



On 01/05/18 06:29, Andrey Smirnov wrote:

+// SPDX-License-Identifier: GPL-2.0+

...

+MODULE_LICENSE("GPL");

I think this should be
MODULE_LICENSE("GPL v2");

--srini