Re: [PATCH v3 4/4] ARM: BCM: Add SMP support for Broadcom 4708
On Sat, Nov 07, 2015 at 12:41:21AM +0100, Hauke Mehrtens wrote: > On 11/07/2015 12:27 AM, Hauke Mehrtens wrote: > > On 11/06/2015 11:54 PM, Jon Mason wrote: > >> On Fri, Nov 06, 2015 at 10:42:41PM +0100, Hauke Mehrtens wrote: > >>> On 11/06/2015 10:11 PM, Kapil Hali wrote: > From: Jon Mason > > Add SMP support for Broadcom's 4708 SoCs. > > Signed-off-by: Jon Mason > Acked-by: Hauke Mehrtens > Tested-by: Hauke Mehrtens > Signed-off-by: Kapil Hali > >>> > >>> I tested this on a Netgear R6250 V1 (BCM4708) and SMP worked. > >>> > --- > arch/arm/boot/dts/bcm4708.dtsi | 2 ++ > arch/arm/mach-bcm/Kconfig | 1 + > arch/arm/mach-bcm/Makefile | 3 +++ > 3 files changed, 6 insertions(+) > > >>> > >>> ... > >>> > --- a/arch/arm/mach-bcm/Kconfig > +++ b/arch/arm/mach-bcm/Kconfig > @@ -54,6 +54,7 @@ config ARCH_BCM_NSP > config ARCH_BCM_5301X > bool "Broadcom BCM470X / BCM5301X ARM SoC" if ARCH_MULTI_V7 > select ARCH_BCM_IPROC > >>> > >>> You activated ARM_ERRATA_764369 for NSP is this not needed for NS? > >> > >> I'm not certain the CPU version, and without that it is difficult to > >> know what errata's are present in the underlying hardware. My guess > >> is that all present in NSP are present in NS (for UP and SMP). This > >> would put it as: > >> select ARM_ERRATA_754322 > >> select ARM_ERRATA_775420 > >> select ARM_ERRATA_764369 if SMP > >> > >> Would you like me to have them added? > >> > > > > I will send a separate patch adding all the workarounds for erratas in > > the CPU core and the cache controller. > > > > Hauke > > > > > Hi, > > BCM4708 uses a Cortex-A9 rev r3p0 and a L2C-310 rev r3p2. For this CPU > and cache controller the same workaround are needed as for NSP, if you > will resend this patch, please add all of them. Agreed. Kapil or I will mod the patch. Thanks, Jon > > Hauke -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v3 4/4] ARM: BCM: Add SMP support for Broadcom 4708
On 11/07/2015 12:27 AM, Hauke Mehrtens wrote: > On 11/06/2015 11:54 PM, Jon Mason wrote: >> On Fri, Nov 06, 2015 at 10:42:41PM +0100, Hauke Mehrtens wrote: >>> On 11/06/2015 10:11 PM, Kapil Hali wrote: From: Jon Mason Add SMP support for Broadcom's 4708 SoCs. Signed-off-by: Jon Mason Acked-by: Hauke Mehrtens Tested-by: Hauke Mehrtens Signed-off-by: Kapil Hali >>> >>> I tested this on a Netgear R6250 V1 (BCM4708) and SMP worked. >>> --- arch/arm/boot/dts/bcm4708.dtsi | 2 ++ arch/arm/mach-bcm/Kconfig | 1 + arch/arm/mach-bcm/Makefile | 3 +++ 3 files changed, 6 insertions(+) >>> >>> ... >>> --- a/arch/arm/mach-bcm/Kconfig +++ b/arch/arm/mach-bcm/Kconfig @@ -54,6 +54,7 @@ config ARCH_BCM_NSP config ARCH_BCM_5301X bool "Broadcom BCM470X / BCM5301X ARM SoC" if ARCH_MULTI_V7 select ARCH_BCM_IPROC >>> >>> You activated ARM_ERRATA_764369 for NSP is this not needed for NS? >> >> I'm not certain the CPU version, and without that it is difficult to >> know what errata's are present in the underlying hardware. My guess >> is that all present in NSP are present in NS (for UP and SMP). This >> would put it as: >> select ARM_ERRATA_754322 >> select ARM_ERRATA_775420 >> select ARM_ERRATA_764369 if SMP >> >> Would you like me to have them added? >> > > I will send a separate patch adding all the workarounds for erratas in > the CPU core and the cache controller. > > Hauke > > Hi, BCM4708 uses a Cortex-A9 rev r3p0 and a L2C-310 rev r3p2. For this CPU and cache controller the same workaround are needed as for NSP, if you will resend this patch, please add all of them. Hauke -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v3 4/4] ARM: BCM: Add SMP support for Broadcom 4708
On 11/06/2015 11:54 PM, Jon Mason wrote: > On Fri, Nov 06, 2015 at 10:42:41PM +0100, Hauke Mehrtens wrote: >> On 11/06/2015 10:11 PM, Kapil Hali wrote: >>> From: Jon Mason >>> >>> Add SMP support for Broadcom's 4708 SoCs. >>> >>> Signed-off-by: Jon Mason >>> Acked-by: Hauke Mehrtens >>> Tested-by: Hauke Mehrtens >>> Signed-off-by: Kapil Hali >> >> I tested this on a Netgear R6250 V1 (BCM4708) and SMP worked. >> >>> --- >>> arch/arm/boot/dts/bcm4708.dtsi | 2 ++ >>> arch/arm/mach-bcm/Kconfig | 1 + >>> arch/arm/mach-bcm/Makefile | 3 +++ >>> 3 files changed, 6 insertions(+) >>> >> >> ... >> >>> --- a/arch/arm/mach-bcm/Kconfig >>> +++ b/arch/arm/mach-bcm/Kconfig >>> @@ -54,6 +54,7 @@ config ARCH_BCM_NSP >>> config ARCH_BCM_5301X >>> bool "Broadcom BCM470X / BCM5301X ARM SoC" if ARCH_MULTI_V7 >>> select ARCH_BCM_IPROC >> >> You activated ARM_ERRATA_764369 for NSP is this not needed for NS? > > I'm not certain the CPU version, and without that it is difficult to > know what errata's are present in the underlying hardware. My guess > is that all present in NSP are present in NS (for UP and SMP). This > would put it as: > select ARM_ERRATA_754322 > select ARM_ERRATA_775420 > select ARM_ERRATA_764369 if SMP > > Would you like me to have them added? > I will send a separate patch adding all the workarounds for erratas in the CPU core and the cache controller. Hauke -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v3 4/4] ARM: BCM: Add SMP support for Broadcom 4708
Hi Hauke, On 15-11-06 01:42 PM, Hauke Mehrtens wrote: On 11/06/2015 10:11 PM, Kapil Hali wrote: From: Jon Mason Add SMP support for Broadcom's 4708 SoCs. Signed-off-by: Jon Mason Acked-by: Hauke Mehrtens Tested-by: Hauke Mehrtens Signed-off-by: Kapil Hali I tested this on a Netgear R6250 V1 (BCM4708) and SMP worked. --- arch/arm/boot/dts/bcm4708.dtsi | 2 ++ arch/arm/mach-bcm/Kconfig | 1 + arch/arm/mach-bcm/Makefile | 3 +++ 3 files changed, 6 insertions(+) ... --- a/arch/arm/mach-bcm/Kconfig +++ b/arch/arm/mach-bcm/Kconfig @@ -54,6 +54,7 @@ config ARCH_BCM_NSP config ARCH_BCM_5301X bool "Broadcom BCM470X / BCM5301X ARM SoC" if ARCH_MULTI_V7 select ARCH_BCM_IPROC You activated ARM_ERRATA_764369 for NSP is this not needed for NS? You would have to read the ARM CPU register and then compare to ARM Errata to see whether the Errata affects NS or not. + select HAVE_SMP help Support for Broadcom BCM470X and BCM5301X SoCs with ARM CPU cores. ... Regards, Scott -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v3 4/4] ARM: BCM: Add SMP support for Broadcom 4708
On Fri, Nov 06, 2015 at 10:42:41PM +0100, Hauke Mehrtens wrote: > On 11/06/2015 10:11 PM, Kapil Hali wrote: > > From: Jon Mason > > > > Add SMP support for Broadcom's 4708 SoCs. > > > > Signed-off-by: Jon Mason > > Acked-by: Hauke Mehrtens > > Tested-by: Hauke Mehrtens > > Signed-off-by: Kapil Hali > > I tested this on a Netgear R6250 V1 (BCM4708) and SMP worked. > > > --- > > arch/arm/boot/dts/bcm4708.dtsi | 2 ++ > > arch/arm/mach-bcm/Kconfig | 1 + > > arch/arm/mach-bcm/Makefile | 3 +++ > > 3 files changed, 6 insertions(+) > > > > ... > > > --- a/arch/arm/mach-bcm/Kconfig > > +++ b/arch/arm/mach-bcm/Kconfig > > @@ -54,6 +54,7 @@ config ARCH_BCM_NSP > > config ARCH_BCM_5301X > > bool "Broadcom BCM470X / BCM5301X ARM SoC" if ARCH_MULTI_V7 > > select ARCH_BCM_IPROC > > You activated ARM_ERRATA_764369 for NSP is this not needed for NS? I'm not certain the CPU version, and without that it is difficult to know what errata's are present in the underlying hardware. My guess is that all present in NSP are present in NS (for UP and SMP). This would put it as: select ARM_ERRATA_754322 select ARM_ERRATA_775420 select ARM_ERRATA_764369 if SMP Would you like me to have them added? Thanks, Jon > > > > + select HAVE_SMP > > help > > Support for Broadcom BCM470X and BCM5301X SoCs with ARM CPU cores. > > > > ... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v3 4/4] ARM: BCM: Add SMP support for Broadcom 4708
On 11/06/2015 10:11 PM, Kapil Hali wrote: > From: Jon Mason > > Add SMP support for Broadcom's 4708 SoCs. > > Signed-off-by: Jon Mason > Acked-by: Hauke Mehrtens > Tested-by: Hauke Mehrtens > Signed-off-by: Kapil Hali I tested this on a Netgear R6250 V1 (BCM4708) and SMP worked. > --- > arch/arm/boot/dts/bcm4708.dtsi | 2 ++ > arch/arm/mach-bcm/Kconfig | 1 + > arch/arm/mach-bcm/Makefile | 3 +++ > 3 files changed, 6 insertions(+) > ... > --- a/arch/arm/mach-bcm/Kconfig > +++ b/arch/arm/mach-bcm/Kconfig > @@ -54,6 +54,7 @@ config ARCH_BCM_NSP > config ARCH_BCM_5301X > bool "Broadcom BCM470X / BCM5301X ARM SoC" if ARCH_MULTI_V7 > select ARCH_BCM_IPROC You activated ARM_ERRATA_764369 for NSP is this not needed for NS? > + select HAVE_SMP > help > Support for Broadcom BCM470X and BCM5301X SoCs with ARM CPU cores. > ... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/