Re: [PATCH v3 4/8] gpio: dt-bindings: Add documentation for Aspeed GPIO controllers

[Andrew Jeffery]

On Wed, 2016-09-07 at 16:43 +0200, Linus Walleij wrote:
> On Tue, Aug 30, 2016 at 9:54 AM, Andrew Jeffery  wrote:
> 
> > 
> > Signed-off-by: Andrew Jeffery 
> > Acked-by: Joel Stanley 
> Patch applied to the GPIO tree with Rob's ACK and moved the compatible
> to the first line in the process.

Thanks for applying the fixup.

Andrew

signature.asc
Description: This is a digitally signed message part

Re: [PATCH v3 4/8] gpio: dt-bindings: Add documentation for Aspeed GPIO controllers

[Andrew Jeffery]

On Wed, 2016-09-07 at 16:43 +0200, Linus Walleij wrote:
> On Tue, Aug 30, 2016 at 9:54 AM, Andrew Jeffery  wrote:
> 
> > 
> > Signed-off-by: Andrew Jeffery 
> > Acked-by: Joel Stanley 
> Patch applied to the GPIO tree with Rob's ACK and moved the compatible
> to the first line in the process.

Thanks for applying the fixup.

Andrew

signature.asc
Description: This is a digitally signed message part

Re: [PATCH v3 4/8] gpio: dt-bindings: Add documentation for Aspeed GPIO controllers

[Linus Walleij]

On Tue, Aug 30, 2016 at 9:54 AM, Andrew Jeffery  wrote:

> Signed-off-by: Andrew Jeffery 
> Acked-by: Joel Stanley 

Patch applied to the GPIO tree with Rob's ACK and moved the compatible
to the first line in the process.

Yours,
Linus Walleij

Re: [PATCH v3 4/8] gpio: dt-bindings: Add documentation for Aspeed GPIO controllers

[Linus Walleij]

On Tue, Aug 30, 2016 at 9:54 AM, Andrew Jeffery  wrote:

> Signed-off-by: Andrew Jeffery 
> Acked-by: Joel Stanley 

Patch applied to the GPIO tree with Rob's ACK and moved the compatible
to the first line in the process.

Yours,
Linus Walleij

Re: [PATCH v3 4/8] gpio: dt-bindings: Add documentation for Aspeed GPIO controllers

[Rob Herring]

On Tue, Aug 30, 2016 at 05:24:23PM +0930, Andrew Jeffery wrote:
> Signed-off-by: Andrew Jeffery 
> Acked-by: Joel Stanley 
> ---
>  .../devicetree/bindings/gpio/gpio-aspeed.txt   | 36 
> ++
>  1 file changed, 36 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/gpio/gpio-aspeed.txt

Acked-by: Rob Herring 

> 
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-aspeed.txt 
> b/Documentation/devicetree/bindings/gpio/gpio-aspeed.txt
> new file mode 100644
> index ..09f26cac18d1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpio/gpio-aspeed.txt
> @@ -0,0 +1,36 @@
> +Aspeed GPIO controller Device Tree Bindings
> +---
> +
> +Required properties:
> +- #gpio-cells: Should be two
> +   - First cell is the GPIO line number
> +   - Second cell is used to specify optional
> + parameters (unused)
> +
> +- compatible : Either "aspeed,ast2400-gpio" or "aspeed,ast2500-gpio"

I'd prefer this be listed first if you respin this.

> +
> +- reg: Address and length of the register set for 
> the device
> +- gpio-controller: Marks the device node as a GPIO controller.
> +- interrupts : Interrupt specifier (see interrupt bindings for
> +   details)
> +- interrupt-controller   : Mark the GPIO controller as an 
> interrupt-controller
> +
> +Optional properties:
> +
> +- interrupt-parent : The parent interrupt controller, optional if 
> inherited
> +
> +The gpio and interrupt properties are further described in their respective
> +bindings documentation:
> +
> +- Documentation/devicetree/bindings/gpio/gpio.txt
> +- Documentation/devicetree/bindings/interrupt-controller/interrupts.txt
> +
> +  Example:
> + gpio@1e78 {
> + #gpio-cells = <2>;
> + compatible = "aspeed,ast2400-gpio";
> + gpio-controller;
> + interrupts = <20>;
> + reg = <0x1e78 0x1000>;
> + interrupt-controller;
> + };
> -- 
> 2.9.3.1.g0db844e
> 

Re: [PATCH v3 4/8] gpio: dt-bindings: Add documentation for Aspeed GPIO controllers

[Rob Herring]

On Tue, Aug 30, 2016 at 05:24:23PM +0930, Andrew Jeffery wrote:
> Signed-off-by: Andrew Jeffery 
> Acked-by: Joel Stanley 
> ---
>  .../devicetree/bindings/gpio/gpio-aspeed.txt   | 36 
> ++
>  1 file changed, 36 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/gpio/gpio-aspeed.txt

Acked-by: Rob Herring 

> 
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-aspeed.txt 
> b/Documentation/devicetree/bindings/gpio/gpio-aspeed.txt
> new file mode 100644
> index ..09f26cac18d1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpio/gpio-aspeed.txt
> @@ -0,0 +1,36 @@
> +Aspeed GPIO controller Device Tree Bindings
> +---
> +
> +Required properties:
> +- #gpio-cells: Should be two
> +   - First cell is the GPIO line number
> +   - Second cell is used to specify optional
> + parameters (unused)
> +
> +- compatible : Either "aspeed,ast2400-gpio" or "aspeed,ast2500-gpio"

I'd prefer this be listed first if you respin this.

> +
> +- reg: Address and length of the register set for 
> the device
> +- gpio-controller: Marks the device node as a GPIO controller.
> +- interrupts : Interrupt specifier (see interrupt bindings for
> +   details)
> +- interrupt-controller   : Mark the GPIO controller as an 
> interrupt-controller
> +
> +Optional properties:
> +
> +- interrupt-parent : The parent interrupt controller, optional if 
> inherited
> +
> +The gpio and interrupt properties are further described in their respective
> +bindings documentation:
> +
> +- Documentation/devicetree/bindings/gpio/gpio.txt
> +- Documentation/devicetree/bindings/interrupt-controller/interrupts.txt
> +
> +  Example:
> + gpio@1e78 {
> + #gpio-cells = <2>;
> + compatible = "aspeed,ast2400-gpio";
> + gpio-controller;
> + interrupts = <20>;
> + reg = <0x1e78 0x1000>;
> + interrupt-controller;
> + };
> -- 
> 2.9.3.1.g0db844e
>