Re: [PATCH v4] f2fs: compress: add compress_inode to cache compressed blockst

2021-02-27 Thread Jaegeuk Kim
On 02/04, Chao Yu wrote:
> Jaegeuk,
> 
> On 2021/2/2 16:00, Chao Yu wrote:
> > -   for (i = 0; i < dic->nr_cpages; i++) {
> > +   for (i = 0; i < cc->nr_cpages; i++) {
> > struct page *page = dic->cpages[i];
> 
> por_fsstress still hang in this line?

I'm stuck on testing the patches, since the latest kernel is panicking somehow.
Let me update later, once I can test a bit. :(

> 
> Thanks,
> 
> > block_t blkaddr;
> > struct bio_post_read_ctx *ctx;
> > @@ -2201,6 +2207,14 @@ int f2fs_read_multi_pages(struct compress_ctx *cc, 
> > struct bio **bio_ret,
> > blkaddr = data_blkaddr(dn.inode, dn.node_page,
> > dn.ofs_in_node + i + 1);
> > +   f2fs_wait_on_block_writeback(inode, blkaddr);
> > +
> > +   if (f2fs_load_compressed_page(sbi, page, blkaddr)) {
> > +   if (atomic_dec_and_test(>remaining_pages))
> > +   f2fs_decompress_cluster(dic);
> > +   continue;
> > +   }
> > +


Re: [PATCH v4] f2fs: compress: add compress_inode to cache compressed blockst

2021-02-03 Thread Chao Yu

Jaegeuk,

On 2021/2/2 16:00, Chao Yu wrote:

-   for (i = 0; i < dic->nr_cpages; i++) {
+   for (i = 0; i < cc->nr_cpages; i++) {
struct page *page = dic->cpages[i];


por_fsstress still hang in this line?

Thanks,


block_t blkaddr;
struct bio_post_read_ctx *ctx;
@@ -2201,6 +2207,14 @@ int f2fs_read_multi_pages(struct compress_ctx *cc, 
struct bio **bio_ret,
blkaddr = data_blkaddr(dn.inode, dn.node_page,
dn.ofs_in_node + i + 1);
  
+		f2fs_wait_on_block_writeback(inode, blkaddr);

+
+   if (f2fs_load_compressed_page(sbi, page, blkaddr)) {
+   if (atomic_dec_and_test(>remaining_pages))
+   f2fs_decompress_cluster(dic);
+   continue;
+   }
+