Re: [PATCH v4 07/11] kbuild: use 'include' directive to load auto.conf from top Makefile
2018-09-06 7:53 GMT+09:00 Segher Boessenkool : > On Mon, Sep 03, 2018 at 12:00:21PM +0200, Borislav Petkov wrote: >> On Mon, Sep 03, 2018 at 06:54:12PM +0900, Masahiro Yamada wrote: >> > You are right - I missed this usecase, >> > but I still want to excuse "it is rare enough". >> >> Isn't there a Makefile way to check file existence before including it? > > Sure there is, you can use $(wildcard ) . If you work around it by $(wildcard ), we need something else that terminates building in case auto.conf is really missing. I do not want to revert commit 2063945fdc3d4c0ac8f9319d942eda720d02aabe Author: Masahiro Yamada Date: Fri Jul 20 16:46:36 2018 +0900 kbuild: remove auto.conf from prerequisite of phony targets -- Best Regards Masahiro Yamada
Re: [PATCH v4 07/11] kbuild: use 'include' directive to load auto.conf from top Makefile
2018-09-06 7:53 GMT+09:00 Segher Boessenkool : > On Mon, Sep 03, 2018 at 12:00:21PM +0200, Borislav Petkov wrote: >> On Mon, Sep 03, 2018 at 06:54:12PM +0900, Masahiro Yamada wrote: >> > You are right - I missed this usecase, >> > but I still want to excuse "it is rare enough". >> >> Isn't there a Makefile way to check file existence before including it? > > Sure there is, you can use $(wildcard ) . If you work around it by $(wildcard ), we need something else that terminates building in case auto.conf is really missing. I do not want to revert commit 2063945fdc3d4c0ac8f9319d942eda720d02aabe Author: Masahiro Yamada Date: Fri Jul 20 16:46:36 2018 +0900 kbuild: remove auto.conf from prerequisite of phony targets -- Best Regards Masahiro Yamada
Re: [PATCH v4 07/11] kbuild: use 'include' directive to load auto.conf from top Makefile
On Mon, Sep 03, 2018 at 12:00:21PM +0200, Borislav Petkov wrote: > On Mon, Sep 03, 2018 at 06:54:12PM +0900, Masahiro Yamada wrote: > > You are right - I missed this usecase, > > but I still want to excuse "it is rare enough". > > Isn't there a Makefile way to check file existence before including it? Sure there is, you can use $(wildcard ) . Segher
Re: [PATCH v4 07/11] kbuild: use 'include' directive to load auto.conf from top Makefile
On Mon, Sep 03, 2018 at 12:00:21PM +0200, Borislav Petkov wrote: > On Mon, Sep 03, 2018 at 06:54:12PM +0900, Masahiro Yamada wrote: > > You are right - I missed this usecase, > > but I still want to excuse "it is rare enough". > > Isn't there a Makefile way to check file existence before including it? Sure there is, you can use $(wildcard ) . Segher
Re: [PATCH v4 07/11] kbuild: use 'include' directive to load auto.conf from top Makefile
On Mon, Sep 03, 2018 at 06:54:12PM +0900, Masahiro Yamada wrote: > You are right - I missed this usecase, > but I still want to excuse "it is rare enough". Isn't there a Makefile way to check file existence before including it? -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.
Re: [PATCH v4 07/11] kbuild: use 'include' directive to load auto.conf from top Makefile
On Mon, Sep 03, 2018 at 06:54:12PM +0900, Masahiro Yamada wrote: > You are right - I missed this usecase, > but I still want to excuse "it is rare enough". Isn't there a Makefile way to check file existence before including it? -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.
Re: [PATCH v4 07/11] kbuild: use 'include' directive to load auto.conf from top Makefile
Hi, 2018-09-03 18:39 GMT+09:00 Borislav Petkov : > Hey, > > On Fri, Jul 20, 2018 at 04:46:32PM +0900, Masahiro Yamada wrote: >> When you build targets that require the kernel configuration, dot-config >> is set to 1, then the top-level Makefile includes auto.conf. However, >> Make considers its inclusion is optional because the '-include' directive >> is used here. >> >> If a necessary configuration file is missing for the external module >> building, the following error message is displayed: >> >> ERROR: Kernel configuration is invalid. >> include/generated/autoconf.h or include/config/auto.conf are >> missing. >> Run 'make oldconfig && make prepare' on kernel src to fix it. >> >> However, Make still continues building; /bin/false let the creation of >> 'include/config/auto.config' fail, but Make can ignore the error since >> it is included by the '-include' directive. >> >> I guess the reason of using '-include' directive was to suppress >> the warning when you build the kernel from a pristine source tree: >> >> Makefile:605: include/config/auto.conf: No such file or directory >> >> The previous commit made sure include/config/auto.conf exists after >> the 'make *config' stage. Now, we can use the 'include' directive >> without showing the warning. >> >> Signed-off-by: Masahiro Yamada >> --- >> >> Changes in v4: None >> >> Makefile | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > This complains here: > > [boris@zn: ~/kernel/linux> git clean -dqfx > [boris@zn: ~/kernel/linux> cp ../configs/config-4.19-rc1 .config > '../configs/config-4.19-rc1' -> '.config' > [boris@zn: ~/kernel/linux> make > Makefile:605: include/config/auto.conf: No such file or directory > > I guess because I'm skipping the "make oldconfig" step but that should > not be necessary since it should do oldconfig automatically before > building... > > It still works - it is just the warning that is new. You are right - I missed this usecase, but I still want to excuse "it is rare enough". Thanks. -- Best Regards Masahiro Yamada
Re: [PATCH v4 07/11] kbuild: use 'include' directive to load auto.conf from top Makefile
Hi, 2018-09-03 18:39 GMT+09:00 Borislav Petkov : > Hey, > > On Fri, Jul 20, 2018 at 04:46:32PM +0900, Masahiro Yamada wrote: >> When you build targets that require the kernel configuration, dot-config >> is set to 1, then the top-level Makefile includes auto.conf. However, >> Make considers its inclusion is optional because the '-include' directive >> is used here. >> >> If a necessary configuration file is missing for the external module >> building, the following error message is displayed: >> >> ERROR: Kernel configuration is invalid. >> include/generated/autoconf.h or include/config/auto.conf are >> missing. >> Run 'make oldconfig && make prepare' on kernel src to fix it. >> >> However, Make still continues building; /bin/false let the creation of >> 'include/config/auto.config' fail, but Make can ignore the error since >> it is included by the '-include' directive. >> >> I guess the reason of using '-include' directive was to suppress >> the warning when you build the kernel from a pristine source tree: >> >> Makefile:605: include/config/auto.conf: No such file or directory >> >> The previous commit made sure include/config/auto.conf exists after >> the 'make *config' stage. Now, we can use the 'include' directive >> without showing the warning. >> >> Signed-off-by: Masahiro Yamada >> --- >> >> Changes in v4: None >> >> Makefile | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > This complains here: > > [boris@zn: ~/kernel/linux> git clean -dqfx > [boris@zn: ~/kernel/linux> cp ../configs/config-4.19-rc1 .config > '../configs/config-4.19-rc1' -> '.config' > [boris@zn: ~/kernel/linux> make > Makefile:605: include/config/auto.conf: No such file or directory > > I guess because I'm skipping the "make oldconfig" step but that should > not be necessary since it should do oldconfig automatically before > building... > > It still works - it is just the warning that is new. You are right - I missed this usecase, but I still want to excuse "it is rare enough". Thanks. -- Best Regards Masahiro Yamada
Re: [PATCH v4 07/11] kbuild: use 'include' directive to load auto.conf from top Makefile
Hey, On Fri, Jul 20, 2018 at 04:46:32PM +0900, Masahiro Yamada wrote: > When you build targets that require the kernel configuration, dot-config > is set to 1, then the top-level Makefile includes auto.conf. However, > Make considers its inclusion is optional because the '-include' directive > is used here. > > If a necessary configuration file is missing for the external module > building, the following error message is displayed: > > ERROR: Kernel configuration is invalid. > include/generated/autoconf.h or include/config/auto.conf are missing. > Run 'make oldconfig && make prepare' on kernel src to fix it. > > However, Make still continues building; /bin/false let the creation of > 'include/config/auto.config' fail, but Make can ignore the error since > it is included by the '-include' directive. > > I guess the reason of using '-include' directive was to suppress > the warning when you build the kernel from a pristine source tree: > > Makefile:605: include/config/auto.conf: No such file or directory > > The previous commit made sure include/config/auto.conf exists after > the 'make *config' stage. Now, we can use the 'include' directive > without showing the warning. > > Signed-off-by: Masahiro Yamada > --- > > Changes in v4: None > > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) This complains here: [boris@zn: ~/kernel/linux> git clean -dqfx [boris@zn: ~/kernel/linux> cp ../configs/config-4.19-rc1 .config '../configs/config-4.19-rc1' -> '.config' [boris@zn: ~/kernel/linux> make Makefile:605: include/config/auto.conf: No such file or directory I guess because I'm skipping the "make oldconfig" step but that should not be necessary since it should do oldconfig automatically before building... It still works - it is just the warning that is new. Thx. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.
Re: [PATCH v4 07/11] kbuild: use 'include' directive to load auto.conf from top Makefile
Hey, On Fri, Jul 20, 2018 at 04:46:32PM +0900, Masahiro Yamada wrote: > When you build targets that require the kernel configuration, dot-config > is set to 1, then the top-level Makefile includes auto.conf. However, > Make considers its inclusion is optional because the '-include' directive > is used here. > > If a necessary configuration file is missing for the external module > building, the following error message is displayed: > > ERROR: Kernel configuration is invalid. > include/generated/autoconf.h or include/config/auto.conf are missing. > Run 'make oldconfig && make prepare' on kernel src to fix it. > > However, Make still continues building; /bin/false let the creation of > 'include/config/auto.config' fail, but Make can ignore the error since > it is included by the '-include' directive. > > I guess the reason of using '-include' directive was to suppress > the warning when you build the kernel from a pristine source tree: > > Makefile:605: include/config/auto.conf: No such file or directory > > The previous commit made sure include/config/auto.conf exists after > the 'make *config' stage. Now, we can use the 'include' directive > without showing the warning. > > Signed-off-by: Masahiro Yamada > --- > > Changes in v4: None > > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) This complains here: [boris@zn: ~/kernel/linux> git clean -dqfx [boris@zn: ~/kernel/linux> cp ../configs/config-4.19-rc1 .config '../configs/config-4.19-rc1' -> '.config' [boris@zn: ~/kernel/linux> make Makefile:605: include/config/auto.conf: No such file or directory I guess because I'm skipping the "make oldconfig" step but that should not be necessary since it should do oldconfig automatically before building... It still works - it is just the warning that is new. Thx. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.
