Re: [PATCH v4 3/5] ARM: sunxi: dts: Add PS2 nodes to dtsi for A10 and A20
On Wed, Jan 21, 2015 at 04:40:28PM +0530, Vishnu Patekar wrote: > On Wed, Jan 21, 2015 at 1:32 AM, Maxime Ripard > wrote: > > Hi Vishnu, > > > > On Fri, Jan 16, 2015 at 07:33:39PM +0530, Vishnu Patekar wrote: > >> Signed-off-by: VishnuPatekar > >> Signed-off-by: Hans de Goede > > > > Why is there Hans Signed-off here? > Hans has modified the A10 dtsi and also tested on A10 board. > Shouldn't I add him as Signed-off? Yeah, you should :) Thanks, Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com signature.asc Description: Digital signature
Re: [PATCH v4 3/5] ARM: sunxi: dts: Add PS2 nodes to dtsi for A10 and A20
On Wed, Jan 21, 2015 at 1:32 AM, Maxime Ripard
wrote:
> Hi Vishnu,
>
> On Fri, Jan 16, 2015 at 07:33:39PM +0530, Vishnu Patekar wrote:
>> Signed-off-by: VishnuPatekar
>> Signed-off-by: Hans de Goede
>
> Why is there Hans Signed-off here?
Hans has modified the A10 dtsi and also tested on A10 board.
Shouldn't I add him as Signed-off?
>
>> ---
>> arch/arm/boot/dts/sun4i-a10.dtsi | 16
>> arch/arm/boot/dts/sun7i-a20.dtsi | 16
>> 2 files changed, 32 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi
>> b/arch/arm/boot/dts/sun4i-a10.dtsi
>> index 7b4099f..2c31242 100644
>> --- a/arch/arm/boot/dts/sun4i-a10.dtsi
>> +++ b/arch/arm/boot/dts/sun4i-a10.dtsi
>> @@ -795,5 +795,21 @@
>> #address-cells = <1>;
>> #size-cells = <0>;
>> };
>> +
>> + ps20: ps2@01c2a000 {
>> + compatible = "allwinner,sun4i-a10-ps2";
>> + reg = <0x01c2a000 0x400>;
>> + interrupts = <62>;
>> + clocks = <&apb1_gates 6>;
>> + status = "disabled";
>> + };
>> +
>> + ps21: ps2@01c2a400 {
>> + compatible = "allwinner,sun4i-a10-ps2";
>> + reg = <0x01c2a400 0x400>;
>> + interrupts = <63>;
>> + clocks = <&apb1_gates 7>;
>> + status = "disabled";
>> + };
>> };
>> };
>> diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi
>> b/arch/arm/boot/dts/sun7i-a20.dtsi
>> index e21ce59..f35c691 100644
>> --- a/arch/arm/boot/dts/sun7i-a20.dtsi
>> +++ b/arch/arm/boot/dts/sun7i-a20.dtsi
>> @@ -1093,5 +1093,21 @@
>> #interrupt-cells = <3>;
>> interrupts = <1 9 0xf04>;
>> };
>> +
>> + ps20: ps2@01c2a000 {
>> + compatible = "allwinner,sun4i-a10-ps2";
>> + reg = <0x01c2a000 0x400>;
>> + interrupts = <0 62 4>;
>> + clocks = <&apb1_gates 6>;
>> + status = "disabled";
>> + };
>> +
>> + ps21: ps2@01c2a400 {
>> + compatible = "allwinner,sun4i-a10-ps2";
>> + reg = <0x01c2a400 0x400>;
>> + interrupts = <0 63 4>;
>
> We recently switched to using includes and defines for these hardcoded
> values.
>
> Could you switch to it as well?
Okie, I did not notice that. Thanks for pointing out.
>
> Thanks,
> Maxime
>
> --
> Maxime Ripard, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v4 3/5] ARM: sunxi: dts: Add PS2 nodes to dtsi for A10 and A20
Hi Vishnu,
On Fri, Jan 16, 2015 at 07:33:39PM +0530, Vishnu Patekar wrote:
> Signed-off-by: VishnuPatekar
> Signed-off-by: Hans de Goede
Why is there Hans Signed-off here?
> ---
> arch/arm/boot/dts/sun4i-a10.dtsi | 16
> arch/arm/boot/dts/sun7i-a20.dtsi | 16
> 2 files changed, 32 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi
> b/arch/arm/boot/dts/sun4i-a10.dtsi
> index 7b4099f..2c31242 100644
> --- a/arch/arm/boot/dts/sun4i-a10.dtsi
> +++ b/arch/arm/boot/dts/sun4i-a10.dtsi
> @@ -795,5 +795,21 @@
> #address-cells = <1>;
> #size-cells = <0>;
> };
> +
> + ps20: ps2@01c2a000 {
> + compatible = "allwinner,sun4i-a10-ps2";
> + reg = <0x01c2a000 0x400>;
> + interrupts = <62>;
> + clocks = <&apb1_gates 6>;
> + status = "disabled";
> + };
> +
> + ps21: ps2@01c2a400 {
> + compatible = "allwinner,sun4i-a10-ps2";
> + reg = <0x01c2a400 0x400>;
> + interrupts = <63>;
> + clocks = <&apb1_gates 7>;
> + status = "disabled";
> + };
> };
> };
> diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi
> b/arch/arm/boot/dts/sun7i-a20.dtsi
> index e21ce59..f35c691 100644
> --- a/arch/arm/boot/dts/sun7i-a20.dtsi
> +++ b/arch/arm/boot/dts/sun7i-a20.dtsi
> @@ -1093,5 +1093,21 @@
> #interrupt-cells = <3>;
> interrupts = <1 9 0xf04>;
> };
> +
> + ps20: ps2@01c2a000 {
> + compatible = "allwinner,sun4i-a10-ps2";
> + reg = <0x01c2a000 0x400>;
> + interrupts = <0 62 4>;
> + clocks = <&apb1_gates 6>;
> + status = "disabled";
> + };
> +
> + ps21: ps2@01c2a400 {
> + compatible = "allwinner,sun4i-a10-ps2";
> + reg = <0x01c2a400 0x400>;
> + interrupts = <0 63 4>;
We recently switched to using includes and defines for these hardcoded
values.
Could you switch to it as well?
Thanks,
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
signature.asc
Description: Digital signature
