Re: [PATCH v5 1/2] pinctrl: use to octal permissions for debugfs files
On Tue, Mar 02, 2021 at 05:22:37PM +0100, Linus Walleij wrote: > On Tue, Mar 2, 2021 at 11:23 AM Andy Shevchenko > wrote: > > On Tue, Mar 2, 2021 at 10:36 AM Linus Walleij > > wrote: > > > > Patch applied, thanks for fixing this! > > > > I guess we are at v9 of this. > > Yeah I took it out again waiting for the waters to settle. > > Yours, > Linus Walleij Sorry for the confusion. "[PATCH v8 0/3] pinctrl: pinmux: Add pinmux-select debugfs file" [1] sent Feb. 20th was in my opinion ready to merge. However, it occured to me yesterday since there had been no replies to that thread, then it might be a good idea to add a 4th patch to rename pinctl.rst to pin-control.rst. I sent that yesterday as v9 [2] but I am fine with that being dropped as renaming pinctl.rst is unrelated to my actual goal of adding pinmux-select to debugfs. thanks, drew [1] https://lore.kernel.org/linux-gpio/20210220202750.117421-1-d...@beagleboard.org/ [2] https://lore.kernel.org/lkml/20210302053059.1049035-1-d...@beagleboard.org/
Re: [PATCH v5 1/2] pinctrl: use to octal permissions for debugfs files
On Tue, Mar 2, 2021 at 11:23 AM Andy Shevchenko wrote: > On Tue, Mar 2, 2021 at 10:36 AM Linus Walleij > wrote: > > Patch applied, thanks for fixing this! > > I guess we are at v9 of this. Yeah I took it out again waiting for the waters to settle. Yours, Linus Walleij
Re: [PATCH v5 1/2] pinctrl: use to octal permissions for debugfs files
On Tue, Mar 2, 2021 at 10:36 AM Linus Walleij wrote:
>
> On Fri, Feb 12, 2021 at 11:30 PM Drew Fustini wrote:
>
> > Switch over pinctrl debugfs files to use octal permissions as they are
> > preferred over symbolic permissions. Refer to commit f90774e1fd27
> > ("checkpatch: look for symbolic permissions and suggest octal instead").
> >
> > Note: S_IFREG flag is added to the mode by __debugfs_create_file()
> > in fs/debugfs/inode.c
> >
> > Suggested-by: Andy Shevchenko
> > Signed-off-by: Drew Fustini
>
> Patch applied, thanks for fixing this!
I guess we are at v9 of this.
--
With Best Regards,
Andy Shevchenko
Re: [PATCH v5 1/2] pinctrl: use to octal permissions for debugfs files
On Fri, Feb 12, 2021 at 11:30 PM Drew Fustini wrote:
> Switch over pinctrl debugfs files to use octal permissions as they are
> preferred over symbolic permissions. Refer to commit f90774e1fd27
> ("checkpatch: look for symbolic permissions and suggest octal instead").
>
> Note: S_IFREG flag is added to the mode by __debugfs_create_file()
> in fs/debugfs/inode.c
>
> Suggested-by: Andy Shevchenko
> Signed-off-by: Drew Fustini
Patch applied, thanks for fixing this!
Yours,
Linus Walleij
Re: [PATCH v5 1/2] pinctrl: use to octal permissions for debugfs files
On Fri, Feb 12, 2021 at 11:30 PM Drew Fustini wrote:
> Switch over pinctrl debugfs files to use octal permissions as they are
> preferred over symbolic permissions. Refer to commit f90774e1fd27
> ("checkpatch: look for symbolic permissions and suggest octal instead").
>
> Note: S_IFREG flag is added to the mode by __debugfs_create_file()
> in fs/debugfs/inode.c
>
> Suggested-by: Andy Shevchenko
> Signed-off-by: Drew Fustini
Reviewed-by: Geert Uytterhoeven
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Re: [PATCH v5 1/2] pinctrl: use to octal permissions for debugfs files
On Sat, Feb 13, 2021 at 12:30 AM Drew Fustini wrote:
>
> Switch over pinctrl debugfs files to use octal permissions as they are
> preferred over symbolic permissions. Refer to commit f90774e1fd27
> ("checkpatch: look for symbolic permissions and suggest octal instead").
>
> Note: S_IFREG flag is added to the mode by __debugfs_create_file()
> in fs/debugfs/inode.c
I guess it also needs Suggested-by: Joe (IIRC he proposed to convert the rest).
Nevertheless,
Reviewed-by: Andy Shevchenko
Thanks!
> Suggested-by: Andy Shevchenko
> Signed-off-by: Drew Fustini
> ---
> drivers/pinctrl/core.c| 12 ++--
> drivers/pinctrl/pinconf.c | 4 ++--
> drivers/pinctrl/pinmux.c | 4 ++--
> 3 files changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c
> index 3663d87f51a0..07458742bc0f 100644
> --- a/drivers/pinctrl/core.c
> +++ b/drivers/pinctrl/core.c
> @@ -1888,11 +1888,11 @@ static void pinctrl_init_device_debugfs(struct
> pinctrl_dev *pctldev)
> dev_name(pctldev->dev));
> return;
> }
> - debugfs_create_file("pins", S_IFREG | S_IRUGO,
> + debugfs_create_file("pins", 0444,
> device_root, pctldev, _pins_fops);
> - debugfs_create_file("pingroups", S_IFREG | S_IRUGO,
> + debugfs_create_file("pingroups", 0444,
> device_root, pctldev, _groups_fops);
> - debugfs_create_file("gpio-ranges", S_IFREG | S_IRUGO,
> + debugfs_create_file("gpio-ranges", 0444,
> device_root, pctldev, _gpioranges_fops);
> if (pctldev->desc->pmxops)
> pinmux_init_device_debugfs(device_root, pctldev);
> @@ -1914,11 +1914,11 @@ static void pinctrl_init_debugfs(void)
> return;
> }
>
> - debugfs_create_file("pinctrl-devices", S_IFREG | S_IRUGO,
> + debugfs_create_file("pinctrl-devices", 0444,
> debugfs_root, NULL, _devices_fops);
> - debugfs_create_file("pinctrl-maps", S_IFREG | S_IRUGO,
> + debugfs_create_file("pinctrl-maps", 0444,
> debugfs_root, NULL, _maps_fops);
> - debugfs_create_file("pinctrl-handles", S_IFREG | S_IRUGO,
> + debugfs_create_file("pinctrl-handles", 0444,
> debugfs_root, NULL, _fops);
> }
>
> diff --git a/drivers/pinctrl/pinconf.c b/drivers/pinctrl/pinconf.c
> index 02c075cc010b..d9d54065472e 100644
> --- a/drivers/pinctrl/pinconf.c
> +++ b/drivers/pinctrl/pinconf.c
> @@ -370,9 +370,9 @@ DEFINE_SHOW_ATTRIBUTE(pinconf_groups);
> void pinconf_init_device_debugfs(struct dentry *devroot,
> struct pinctrl_dev *pctldev)
> {
> - debugfs_create_file("pinconf-pins", S_IFREG | S_IRUGO,
> + debugfs_create_file("pinconf-pins", 0444,
> devroot, pctldev, _pins_fops);
> - debugfs_create_file("pinconf-groups", S_IFREG | S_IRUGO,
> + debugfs_create_file("pinconf-groups", 0444,
> devroot, pctldev, _groups_fops);
> }
>
> diff --git a/drivers/pinctrl/pinmux.c b/drivers/pinctrl/pinmux.c
> index bab888fe3f8e..c651b2db0925 100644
> --- a/drivers/pinctrl/pinmux.c
> +++ b/drivers/pinctrl/pinmux.c
> @@ -676,9 +676,9 @@ DEFINE_SHOW_ATTRIBUTE(pinmux_pins);
> void pinmux_init_device_debugfs(struct dentry *devroot,
> struct pinctrl_dev *pctldev)
> {
> - debugfs_create_file("pinmux-functions", S_IFREG | S_IRUGO,
> + debugfs_create_file("pinmux-functions", 0444,
> devroot, pctldev, _functions_fops);
> - debugfs_create_file("pinmux-pins", S_IFREG | S_IRUGO,
> + debugfs_create_file("pinmux-pins", 0444,
> devroot, pctldev, _pins_fops);
> }
>
> --
> 2.25.1
>
--
With Best Regards,
Andy Shevchenko
