Re: [PATCH v6 0/3] mailbox: Add APM X-Gene platform mailbox driver

2016-02-19 Thread Duc Dang
On Fri, Feb 12, 2016 at 7:39 PM, Duc Dang  wrote:
> APM X-Gene SoC has a mailbox controller that provides
> communication mechanism for X-Gene Arm64 cores to communicate
> with X-Gene SoC's Cortex M3 (SLIMpro) processor.
>
> X-Gene mailbox controller provides 8 mailbox channels, with
> each channel has a dedicated interrupt line.

Hi Jassi,

Are you fine with this version of the patch?

Regards,
Duc Dang.
>
> Changes since v5:
> - Add more description into SlimPRO
> mailbox data structure
>
> Changes since v4:
> - Rebase over v4.5-rc1
> - Fix section mismatch warning during compiling
> - Correctly print channel number when there is
> no IRQ for that channel
> - Change node name to mailbox@1054
> - Correct the number of IRQs in documentation
>
> Changes since v3:
> - Rebase over v4.4
> - Remove 'id' in slimpro_mbox_chan structure
> - Remove functions that are only called once
> and fold them into the other callers
> - Remove void* pointer type cast
> - Relax the number of mailbox IRQs condition
> - Fix error and address comment in documentation
> (xgene-slimpro-mailbox.txt)
>
> Changes since v2:
> - Rebase Feng's patch set over v4.3-rc5
> - Remove uneccessary 'inline' in function definition
> - Use module_platform_driver instead of subsys_initcall
> - Minor coding stype clean up
>
> Changes since v1:
> - Add ACPI support
> - Use defines for reg offset
>
> Duc Dang (3):
>   mailbox: Add support for APM X-Gene platform mailbox driver
>   Documentation: mailbox: Add APM X-Gene SLIMpro mailbox dts
> documentation
>   arm64: dts: mailbox device tree node for APM X-Gene platform.
>
>  .../bindings/mailbox/xgene-slimpro-mailbox.txt |  35 +++
>  arch/arm64/boot/dts/apm/apm-storm.dtsi |  14 +
>  drivers/mailbox/Kconfig|   9 +
>  drivers/mailbox/Makefile   |   2 +
>  drivers/mailbox/mailbox-xgene-slimpro.c| 284 
> +
>  5 files changed, 344 insertions(+)
>  create mode 100644 
> Documentation/devicetree/bindings/mailbox/xgene-slimpro-mailbox.txt
>  create mode 100644 drivers/mailbox/mailbox-xgene-slimpro.c
>
> --
> 1.9.1
>


Re: [PATCH v6 0/3] mailbox: Add APM X-Gene platform mailbox driver

2016-02-12 Thread Duc Dang
Hi Itaru,

On Friday, February 12, 2016, Itaru Kitayama  wrote:
>
> Hi Duc,
>
> I've been testing your patch set for v4.5-rc1 on Mustang, with ACPI, however 
> the boot hangs in the middle of it:
>
> EFI stub: Booting Linux Kernel...
> EFI stub: Using DTB from configuration table
> EFI stub: Exiting boot services and installing virtual address map...
> L3c Cache: 8MB
> Booting Linux on physical CPU 0x0
> Linux version 4.5.0-rc1+ (itaru.kitayama@r2-a21) (gcc version 5.3.1 20151207 
> (Red Hat 5.3.1-2) (GCC) ) #96 SMP PREEMPT Fri Feb 12 22:43:54 CST 2016
> Boot CPU: AArch64 Processor [500f0001]
> earlycon: Early serial console at MMIO32 0x1c02 (options '')
> bootconsole [uart0] enabled
> efi: Getting EFI parameters from FDT:
> EFI v2.40 by X-Gene Mustang Board EFI Nov 24 2015 13:22:41
> efi:  ACPI=0x47fa869000  ACPI 2.0=0x47fa869014  SMBIOS 3.0=0x47fa867000
> cma: Reserved 512 MiB at 0x0040e000
> ACPI: Early table checksum verification disabled
> ACPI: RSDP 0x0047FA869014 24 (v02 APM   )
> ACPI: XSDT 0x0047FA8680E8 6C (v01 APMXGENE0003 0113)
> ACPI: FACP 0x0047FA85F000 00010C (v05 APMXGENE0003 INTL 
> 20140724)
> ACPI: DSDT 0x0047FA86 00495F (v05 APMAPM88xxx 0001 INTL 
> 20140724)
> ACPI: DBG2 0x0047FA865000 AA (v00 APMC0D XGENEDBG  INTL 
> 20140724)
> ACPI: GTDT 0x0047FA85D000 E0 (v02 APMXGENE0001 INTL 
> 20140724)
> ACPI: MCFG 0x0047FA85C000 3C (v01 APMXGENE0002 INTL 
> 20140724)
> ACPI: SPCR 0x0047FA85B000 50 (v02 APMC0D XGENESPC  INTL 
> 20140724)
> ACPI: SSDT 0x0047FA85A000 2D (v02 APMXGENE0001 INTL 
> 20140724)
> ACPI: APIC 0x0047FA859000 0002A4 (v03 APMXGENE0003 0113)
> ACPI: SSDT 0x0047FA858000 78 (v02 REDHAT MACADDRS 0001 0113)
> ACPI: SSDT 0x0047FA857000 32 (v02 REDHAT UARTCLKS 0001 0113)
> psci: is not implemented in ACPI.
> Unsupported ACPI enable-method
> Unsupported ACPI enable-method
> Unsupported ACPI enable-method
> Unsupported ACPI enable-method
> Unsupported ACPI enable-method
> Unsupported ACPI enable-method
> Unsupported ACPI enable-method
> Unsupported ACPI enable-method
> PERCPU: Embedded 2 pages/cpu @fe07fff9 s41472 r8192 d81408 u131072
> Detected PIPT I-cache on CPU0
> Built 1 zonelists in Zone order, mobility grouping on.  Total pages: 523776
> Kernel command line: BOOT_IMAGE=/vmlinuz-4.5.0-rc1+ 
> root=UUID=0e305934-49d5-4f66-b10b-23ec6029fab9 ro acpi=force 
> earlycon=uart8250,mmio32,0x1c02 console=ttyS0,115200 LANG=en_US.UTF-8
> PID hash table entries: 4096 (order: -1, 32768 bytes)
> Dentry cache hash table entries: 4194304 (order: 9, 33554432 bytes)
> Inode-cache hash table entries: 2097152 (order: 8, 16777216 bytes)
> software IO TLB [mem 0x40dbff-0x40dfff] (64MB) mapped at 
> [fe00dbff-fe00dffe]
> Memory: 32856256K/33554432K available (6158K kernel code, 725K rwdata, 4032K 
> rodata, 768K init, 399K bss, 173888K reserved, 524288K cma-reserved)
> Virtual kernel memory layout:
> vmalloc : 0xfc00 - 0xfdfedfff   (  2043 GB)
> vmemmap : 0xfdfee000 - 0xfdffe000   ( 4 GB maximum)
>   0xfdfef000 - 0xfdfef200   (32 MB actual)
> fixed   : 0xfdfffa7d - 0xfdfffac0   (  4288 KB)
> PCI I/O : 0xfdfffae0 - 0xfdfffbe0   (16 MB)
> modules : 0xfdfffc00 - 0xfe00   (64 MB)
> memory  : 0xfe00 - 0xfe08   ( 32768 MB)
>   .init : 0xfea8 - 0xfeb4   (   768 KB)
>   .text : 0xfe08 - 0xfea75b44   ( 10199 KB)
>   .data : 0xfeb4 - 0xfebf5400   (   725 KB)
> SLUB: HWalign=64, Order=0-3, MinObjects=0, CPUs=1, Nodes=1
> Preemptible hierarchical RCU implementation.
> Build-time adjustment of leaf fanout to 64.
> RCU restricting CPUs from NR_CPUS=64 to nr_cpu_ids=1.
> RCU: Adjusting geometry for rcu_fanout_leaf=64, nr_cpu_ids=1
> NR_IRQS:64 nr_irqs:64 0
> GIC: Using split EOI/Deactivate mode
> Architected cp15 timer(s) running at 50.00MHz (phys).
> clocksource: arch_sys_counter: mask: 0xff max_cycles: 
> 0xb8812736b, max_idle_ns: 440795202655 ns
> sched_clock: 56 bits at 50MHz, resolution 20ns, wraps every 4398046511100ns
> Console: colour dummy device 80x25
> Calibrating delay loop (skipped), value calculated using timer frequency.. 
> 100.00 BogoMIPS (lpj=20)
> pid_max: default: 32768 minimum: 301
> ACPI: Core revision 20160108
> ACPI: 4 ACPI AML tables successfully acquired and loaded
>
> Security Framework initialized
> Mount-cache hash table entries: 65536 (order: 3, 524288 bytes)
> Mountpoint-cache hash table entries: 65536 (order: 3, 524288 bytes)
> ASID allocator initialised with 65536 entries
>
> Is the patch set supposed to be evaluated without ACPI?

The patch set is 

RE: [PATCH v6 0/3] mailbox: Add APM X-Gene platform mailbox driver

2016-02-12 Thread Itaru Kitayama

Hi Duc,

I've been testing your patch set for v4.5-rc1 on Mustang, with ACPI, 
however the boot hangs in the middle of it:


EFI stub: Booting Linux Kernel...
EFI stub: Using DTB from configuration table
EFI stub: Exiting boot services and installing virtual address map...
L3c Cache: 8MB
Booting Linux on physical CPU 0x0
Linux version 4.5.0-rc1+ (itaru.kitayama@r2-a21) (gcc version 5.3.1 
20151207 (Red Hat 5.3.1-2) (GCC) ) #96 SMP PREEMPT Fri Feb 12 22:43:54 
CST 2016

Boot CPU: AArch64 Processor [500f0001]
earlycon: Early serial console at MMIO32 0x1c02 (options '')
bootconsole [uart0] enabled
efi: Getting EFI parameters from FDT:
EFI v2.40 by X-Gene Mustang Board EFI Nov 24 2015 13:22:41
efi:  ACPI=0x47fa869000  ACPI 2.0=0x47fa869014  SMBIOS 3.0=0x47fa867000
cma: Reserved 512 MiB at 0x0040e000
ACPI: Early table checksum verification disabled
ACPI: RSDP 0x0047FA869014 24 (v02 APM   )
ACPI: XSDT 0x0047FA8680E8 6C (v01 APMXGENE0003 
0113)
ACPI: FACP 0x0047FA85F000 00010C (v05 APMXGENE0003 INTL 
20140724)
ACPI: DSDT 0x0047FA86 00495F (v05 APMAPM88xxx 0001 INTL 
20140724)
ACPI: DBG2 0x0047FA865000 AA (v00 APMC0D XGENEDBG  INTL 
20140724)
ACPI: GTDT 0x0047FA85D000 E0 (v02 APMXGENE0001 INTL 
20140724)
ACPI: MCFG 0x0047FA85C000 3C (v01 APMXGENE0002 INTL 
20140724)
ACPI: SPCR 0x0047FA85B000 50 (v02 APMC0D XGENESPC  INTL 
20140724)
ACPI: SSDT 0x0047FA85A000 2D (v02 APMXGENE0001 INTL 
20140724)
ACPI: APIC 0x0047FA859000 0002A4 (v03 APMXGENE0003 
0113)
ACPI: SSDT 0x0047FA858000 78 (v02 REDHAT MACADDRS 0001 
0113)
ACPI: SSDT 0x0047FA857000 32 (v02 REDHAT UARTCLKS 0001 
0113)

psci: is not implemented in ACPI.
Unsupported ACPI enable-method
Unsupported ACPI enable-method
Unsupported ACPI enable-method
Unsupported ACPI enable-method
Unsupported ACPI enable-method
Unsupported ACPI enable-method
Unsupported ACPI enable-method
Unsupported ACPI enable-method
PERCPU: Embedded 2 pages/cpu @fe07fff9 s41472 r8192 d81408 u131072
Detected PIPT I-cache on CPU0
Built 1 zonelists in Zone order, mobility grouping on.  Total pages: 523776
Kernel command line: BOOT_IMAGE=/vmlinuz-4.5.0-rc1+ 
root=UUID=0e305934-49d5-4f66-b10b-23ec6029fab9 ro acpi=force 
earlycon=uart8250,mmio32,0x1c02 console=ttyS0,115200 LANG=en_US.UTF-8

PID hash table entries: 4096 (order: -1, 32768 bytes)
Dentry cache hash table entries: 4194304 (order: 9, 33554432 bytes)
Inode-cache hash table entries: 2097152 (order: 8, 16777216 bytes)
software IO TLB [mem 0x40dbff-0x40dfff] (64MB) mapped at 
[fe00dbff-fe00dffe]
Memory: 32856256K/33554432K available (6158K kernel code, 725K rwdata, 
4032K rodata, 768K init, 399K bss, 173888K reserved, 524288K cma-reserved)

Virtual kernel memory layout:
vmalloc : 0xfc00 - 0xfdfedfff   (  2043 GB)
vmemmap : 0xfdfee000 - 0xfdffe000   ( 4 GB maximum)
  0xfdfef000 - 0xfdfef200   (32 MB actual)
fixed   : 0xfdfffa7d - 0xfdfffac0   (  4288 KB)
PCI I/O : 0xfdfffae0 - 0xfdfffbe0   (16 MB)
modules : 0xfdfffc00 - 0xfe00   (64 MB)
memory  : 0xfe00 - 0xfe08   ( 32768 MB)
  .init : 0xfea8 - 0xfeb4   (   768 KB)
  .text : 0xfe08 - 0xfea75b44   ( 10199 KB)
  .data : 0xfeb4 - 0xfebf5400   (   725 KB)
SLUB: HWalign=64, Order=0-3, MinObjects=0, CPUs=1, Nodes=1
Preemptible hierarchical RCU implementation.
Build-time adjustment of leaf fanout to 64.
RCU restricting CPUs from NR_CPUS=64 to nr_cpu_ids=1.
RCU: Adjusting geometry for rcu_fanout_leaf=64, nr_cpu_ids=1
NR_IRQS:64 nr_irqs:64 0
GIC: Using split EOI/Deactivate mode
Architected cp15 timer(s) running at 50.00MHz (phys).
clocksource: arch_sys_counter: mask: 0xff max_cycles: 
0xb8812736b, max_idle_ns: 440795202655 ns

sched_clock: 56 bits at 50MHz, resolution 20ns, wraps every 4398046511100ns
Console: colour dummy device 80x25
Calibrating delay loop (skipped), value calculated using timer 
frequency.. 100.00 BogoMIPS (lpj=20)

pid_max: default: 32768 minimum: 301
ACPI: Core revision 20160108
ACPI: 4 ACPI AML tables successfully acquired and loaded

Security Framework initialized
Mount-cache hash table entries: 65536 (order: 3, 524288 bytes)
Mountpoint-cache hash table entries: 65536 (order: 3, 524288 bytes)
ASID allocator initialised with 65536 entries

Is the patch set supposed to be evaluated without ACPI?