Re: [PATCH v6 8/8] arm64: dts: mt6359: add PMIC MT6359 related nodes

[Hsin-hsiung Wang]

Hi,

On Mon, 2021-03-29 at 17:24 +0200, Matthias Brugger wrote:
> 
> On 15/03/2021 18:35, Hsin-Hsiung Wang wrote:
> > From: Wen Su 
> > 
> > add PMIC MT6359 related nodes which is for MT6779 platform
> > 
> > Signed-off-by: Wen Su 
> > Signed-off-by: Hsin-Hsiung Wang 
> > ---
> > changes since v5:
> > - update file date.
> > ---
> >  arch/arm64/boot/dts/mediatek/mt6359.dtsi| 298 
> >  arch/arm64/boot/dts/mediatek/mt8192-evb.dts |   1 +
> >  2 files changed, 299 insertions(+)
> >  create mode 100644 arch/arm64/boot/dts/mediatek/mt6359.dtsi
> > 
> > diff --git a/arch/arm64/boot/dts/mediatek/mt6359.dtsi 
> > b/arch/arm64/boot/dts/mediatek/mt6359.dtsi
> > new file mode 100644
> > index ..84235db460f8
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/mediatek/mt6359.dtsi
> > @@ -0,0 +1,298 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * Copyright (c) 2021 MediaTek Inc.
> > + */
> > +
> > +&pwrap {
> > +   pmic: pmic {
> > +   compatible = "mediatek,mt6359";
> > +   interrupt-controller;
> > +   #interrupt-cells = <2>;
> > +
> > +   mt6359codec: mt6359codec {
> > +   };
> > +
> > +   mt6359regulator: regulators {
> 
> should be just:
> regulators {
> 
> Other than that looks good to me.
> 

Thanks for the review.
I will update it in next patch.

> Regards,
> Matthias
> 
> > +   mt6359_vs1_buck_reg: buck_vs1 {
> > +   regulator-name = "vs1";
> > +   regulator-min-microvolt = <80>;
> > +   regulator-max-microvolt = <220>;
> > +   regulator-enable-ramp-delay = <0>;
> > +   regulator-always-on;
> > +   };
> > +   mt6359_vgpu11_buck_reg: buck_vgpu11 {
> > +   regulator-name = "vgpu11";
> > +   regulator-min-microvolt = <40>;
> > +   regulator-max-microvolt = <1193750>;
> > +   regulator-ramp-delay = <5000>;
> > +   regulator-enable-ramp-delay = <200>;
> > +   regulator-allowed-modes = <0 1 2>;
> > +   };
> > +   mt6359_vmodem_buck_reg: buck_vmodem {
> > +   regulator-name = "vmodem";
> > +   regulator-min-microvolt = <40>;
> > +   regulator-max-microvolt = <110>;
> > +   regulator-ramp-delay = <10760>;
> > +   regulator-enable-ramp-delay = <200>;
> > +   };
> > +   mt6359_vpu_buck_reg: buck_vpu {
> > +   regulator-name = "vpu";
> > +   regulator-min-microvolt = <40>;
> > +   regulator-max-microvolt = <1193750>;
> > +   regulator-ramp-delay = <5000>;
> > +   regulator-enable-ramp-delay = <200>;
> > +   regulator-allowed-modes = <0 1 2>;
> > +   };
> > +   mt6359_vcore_buck_reg: buck_vcore {
> > +   regulator-name = "vcore";
> > +   regulator-min-microvolt = <40>;
> > +   regulator-max-microvolt = <130>;
> > +   regulator-ramp-delay = <5000>;
> > +   regulator-enable-ramp-delay = <200>;
> > +   regulator-allowed-modes = <0 1 2>;
> > +   };
> > +   mt6359_vs2_buck_reg: buck_vs2 {
> > +   regulator-name = "vs2";
> > +   regulator-min-microvolt = <80>;
> > +   regulator-max-microvolt = <160>;
> > +   regulator-enable-ramp-delay = <0>;
> > +   regulator-always-on;
> > +   };
> > +   mt6359_vpa_buck_reg: buck_vpa {
> > +   regulator-name = "vpa";
> > +   regulator-min-microvolt = <50>;
> > +   regulator-max-microvolt = <365>;
> > +   regulator-enable-ramp-delay = <300>;
> > +   };
> > +   mt6359_vproc2_buck_reg: buck_vproc2 {
> > +   regulator-name = "vproc2";
> > +   regulator-min-microvolt = <40>;
> > +   regulator-max-microvolt = <1193750>;
> > +   regulator-ramp-delay = <7500>;
> > +   regulator-enable-ramp-delay = <200>;
> > +   regulator-allowed-modes = <0 1 2>;
> > +   };
> > +   mt6359_vproc1_buck_reg: buck_vproc1 {
> > +   regulator-name = "vproc1";
> > +   

Re: [PATCH v6 8/8] arm64: dts: mt6359: add PMIC MT6359 related nodes

[Matthias Brugger]

On 15/03/2021 18:35, Hsin-Hsiung Wang wrote:
> From: Wen Su 
> 
> add PMIC MT6359 related nodes which is for MT6779 platform
> 
> Signed-off-by: Wen Su 
> Signed-off-by: Hsin-Hsiung Wang 
> ---
> changes since v5:
> - update file date.
> ---
>  arch/arm64/boot/dts/mediatek/mt6359.dtsi| 298 
>  arch/arm64/boot/dts/mediatek/mt8192-evb.dts |   1 +
>  2 files changed, 299 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/mediatek/mt6359.dtsi
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt6359.dtsi 
> b/arch/arm64/boot/dts/mediatek/mt6359.dtsi
> new file mode 100644
> index ..84235db460f8
> --- /dev/null
> +++ b/arch/arm64/boot/dts/mediatek/mt6359.dtsi
> @@ -0,0 +1,298 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (c) 2021 MediaTek Inc.
> + */
> +
> +&pwrap {
> + pmic: pmic {
> + compatible = "mediatek,mt6359";
> + interrupt-controller;
> + #interrupt-cells = <2>;
> +
> + mt6359codec: mt6359codec {
> + };
> +
> + mt6359regulator: regulators {

should be just:
regulators {

Other than that looks good to me.

Regards,
Matthias

> + mt6359_vs1_buck_reg: buck_vs1 {
> + regulator-name = "vs1";
> + regulator-min-microvolt = <80>;
> + regulator-max-microvolt = <220>;
> + regulator-enable-ramp-delay = <0>;
> + regulator-always-on;
> + };
> + mt6359_vgpu11_buck_reg: buck_vgpu11 {
> + regulator-name = "vgpu11";
> + regulator-min-microvolt = <40>;
> + regulator-max-microvolt = <1193750>;
> + regulator-ramp-delay = <5000>;
> + regulator-enable-ramp-delay = <200>;
> + regulator-allowed-modes = <0 1 2>;
> + };
> + mt6359_vmodem_buck_reg: buck_vmodem {
> + regulator-name = "vmodem";
> + regulator-min-microvolt = <40>;
> + regulator-max-microvolt = <110>;
> + regulator-ramp-delay = <10760>;
> + regulator-enable-ramp-delay = <200>;
> + };
> + mt6359_vpu_buck_reg: buck_vpu {
> + regulator-name = "vpu";
> + regulator-min-microvolt = <40>;
> + regulator-max-microvolt = <1193750>;
> + regulator-ramp-delay = <5000>;
> + regulator-enable-ramp-delay = <200>;
> + regulator-allowed-modes = <0 1 2>;
> + };
> + mt6359_vcore_buck_reg: buck_vcore {
> + regulator-name = "vcore";
> + regulator-min-microvolt = <40>;
> + regulator-max-microvolt = <130>;
> + regulator-ramp-delay = <5000>;
> + regulator-enable-ramp-delay = <200>;
> + regulator-allowed-modes = <0 1 2>;
> + };
> + mt6359_vs2_buck_reg: buck_vs2 {
> + regulator-name = "vs2";
> + regulator-min-microvolt = <80>;
> + regulator-max-microvolt = <160>;
> + regulator-enable-ramp-delay = <0>;
> + regulator-always-on;
> + };
> + mt6359_vpa_buck_reg: buck_vpa {
> + regulator-name = "vpa";
> + regulator-min-microvolt = <50>;
> + regulator-max-microvolt = <365>;
> + regulator-enable-ramp-delay = <300>;
> + };
> + mt6359_vproc2_buck_reg: buck_vproc2 {
> + regulator-name = "vproc2";
> + regulator-min-microvolt = <40>;
> + regulator-max-microvolt = <1193750>;
> + regulator-ramp-delay = <7500>;
> + regulator-enable-ramp-delay = <200>;
> + regulator-allowed-modes = <0 1 2>;
> + };
> + mt6359_vproc1_buck_reg: buck_vproc1 {
> + regulator-name = "vproc1";
> + regulator-min-microvolt = <40>;
> + regulator-max-microvolt = <1193750>;
> + regulator-ramp-delay = <7500>;
> +