Re: [PATCH v7 15/15] RISC-V: Build Infastructure

[Masahiro Yamada]

Hi.

> diff --git a/arch/riscv/include/asm/Kbuild b/arch/riscv/include/asm/Kbuild
> new file mode 100644
> index ..18158be62a2b
> --- /dev/null
> +++ b/arch/riscv/include/asm/Kbuild
> @@ -0,0 +1,61 @@
> +generic-y += bugs.h
> +generic-y += cacheflush.h
> +generic-y += checksum.h
> +generic-y += clkdev.h
> +generic-y += cputime.h
> +generic-y += device.h
> +generic-y += div64.h
> +generic-y += dma.h
> +generic-y += dma-contiguous.h
> +generic-y += emergency-restart.h
> +generic-y += errno.h
> +generic-y += exec.h
> +generic-y += fb.h
> +generic-y += fcntl.h
> +generic-y += ftrace.h
> +generic-y += futex.h
> +generic-y += hardirq.h
> +generic-y += hash.h
> +generic-y += hw_irq.h
> +generic-y += ioctl.h
> +generic-y += ioctls.h
> +generic-y += ipcbuf.h
> +generic-y += irq_regs.h
> +generic-y += irq_work.h
> +generic-y += kdebug.h
> +generic-y += kmap_types.h
> +generic-y += kvm_para.h
> +generic-y += local.h
> +generic-y += mm-arch-hooks.h
> +generic-y += mman.h
> +generic-y += module.h
> +generic-y += msgbuf.h
> +generic-y += mutex.h
> +generic-y += param.h
> +generic-y += percpu.h
> +generic-y += poll.h
> +generic-y += posix_types.h
> +generic-y += preempt.h
> +generic-y += resource.h
> +generic-y += scatterlist.h
> +generic-y += sections.h
> +generic-y += sembuf.h
> +generic-y += setup.h
> +generic-y += shmbuf.h
> +generic-y += shmparam.h
> +generic-y += signal.h
> +generic-y += socket.h
> +generic-y += sockios.h
> +generic-y += stat.h
> +generic-y += statfs.h
> +generic-y += swab.h
> +generic-y += termbits.h
> +generic-y += termios.h
> +generic-y += topology.h
> +generic-y += trace_clock.h
> +generic-y += types.h
> +generic-y += unaligned.h
> +generic-y += user.h
> +generic-y += vga.h
> +generic-y += vmlinux.lds.h
> +generic-y += xor.h


Please split exported headers to arch/riscv/include/uapi/asm/Kbuild.

Otherwise, "make headers_install" will not work.

Please check
git show a8ff49a1d..d1b32bac



-- 
Best Regards
Masahiro Yamada

Re: [PATCH v7 15/15] RISC-V: Build Infastructure

[Masahiro Yamada]

Hi.

> diff --git a/arch/riscv/include/asm/Kbuild b/arch/riscv/include/asm/Kbuild
> new file mode 100644
> index ..18158be62a2b
> --- /dev/null
> +++ b/arch/riscv/include/asm/Kbuild
> @@ -0,0 +1,61 @@
> +generic-y += bugs.h
> +generic-y += cacheflush.h
> +generic-y += checksum.h
> +generic-y += clkdev.h
> +generic-y += cputime.h
> +generic-y += device.h
> +generic-y += div64.h
> +generic-y += dma.h
> +generic-y += dma-contiguous.h
> +generic-y += emergency-restart.h
> +generic-y += errno.h
> +generic-y += exec.h
> +generic-y += fb.h
> +generic-y += fcntl.h
> +generic-y += ftrace.h
> +generic-y += futex.h
> +generic-y += hardirq.h
> +generic-y += hash.h
> +generic-y += hw_irq.h
> +generic-y += ioctl.h
> +generic-y += ioctls.h
> +generic-y += ipcbuf.h
> +generic-y += irq_regs.h
> +generic-y += irq_work.h
> +generic-y += kdebug.h
> +generic-y += kmap_types.h
> +generic-y += kvm_para.h
> +generic-y += local.h
> +generic-y += mm-arch-hooks.h
> +generic-y += mman.h
> +generic-y += module.h
> +generic-y += msgbuf.h
> +generic-y += mutex.h
> +generic-y += param.h
> +generic-y += percpu.h
> +generic-y += poll.h
> +generic-y += posix_types.h
> +generic-y += preempt.h
> +generic-y += resource.h
> +generic-y += scatterlist.h
> +generic-y += sections.h
> +generic-y += sembuf.h
> +generic-y += setup.h
> +generic-y += shmbuf.h
> +generic-y += shmparam.h
> +generic-y += signal.h
> +generic-y += socket.h
> +generic-y += sockios.h
> +generic-y += stat.h
> +generic-y += statfs.h
> +generic-y += swab.h
> +generic-y += termbits.h
> +generic-y += termios.h
> +generic-y += topology.h
> +generic-y += trace_clock.h
> +generic-y += types.h
> +generic-y += unaligned.h
> +generic-y += user.h
> +generic-y += vga.h
> +generic-y += vmlinux.lds.h
> +generic-y += xor.h


Please split exported headers to arch/riscv/include/uapi/asm/Kbuild.

Otherwise, "make headers_install" will not work.

Please check
git show a8ff49a1d..d1b32bac



-- 
Best Regards
Masahiro Yamada

Re: [PATCH v7 15/15] RISC-V: Build Infastructure

[Randy Dunlap]

On 07/31/2017 06:00 PM, Palmer Dabbelt wrote:
> This patch contains all the build infastructure that actually enables
> the RISC-V port.  This includes Makefiles, linker scripts, and Kconfig
> files.  It also contains the only top-level change, which adds RISC-V to
> the list of architectures that need a sed run to produce the ARCH
> variable when building locally.
> 
> Signed-off-by: Palmer Dabbelt 
> ---
> 
> diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
> new file mode 100644
> index ..9b7d077f40af
> --- /dev/null
> +++ b/arch/riscv/Kconfig
> @@ -0,0 +1,275 @@
> +#
> +# For a description of the syntax of this configuration file,
> +# see Documentation/kbuild/kconfig-language.txt.
> +#

[]

drop the "default n" lines below:

> +config CMDLINE_BOOL
> + bool "Built-in kernel command line"
> + default n
> + help
> +   For most platforms, it is firmware or second stage bootloader
> +   that by default specifies the kernel command line options.
> +   However, it might be necessary or advantageous to either override
> +   the default kernel command line or add a few extra options to it.
> +   For such cases, this option allows hardcoding command line options
> +   directly into the kernel.
> +
> +   For that, choose 'Y' here and fill in the extra boot parameters
> +   in CONFIG_CMDLINE.
> +
> +   The built-in options will be concatenated to the default command
> +   line if CMDLINE_OVERRIDE is set to 'N'. Otherwise, the default
> +   command line will be ignored and replaced by the built-in string.
> +
> +config CMDLINE
> + string "Built-in kernel command string"
> + depends on CMDLINE_BOOL
> + default ""
> + help
> +   Supply command-line options at build time by entering them here.
> +
> +config CMDLINE_OVERRIDE
> + bool "Built-in command line overrides bootloader arguments"
> + default n
> + depends on CMDLINE_BOOL
> + help
> +   Set this option to 'Y' to have the kernel ignore the bootloader
> +   or firmware command line.  Instead, the built-in command line
> +   will be used exclusively.
> +
> +   If you don't know what to do here, say N.



-- 
~Randy

Re: [PATCH v7 15/15] RISC-V: Build Infastructure

[Randy Dunlap]

On 07/31/2017 06:00 PM, Palmer Dabbelt wrote:
> This patch contains all the build infastructure that actually enables
> the RISC-V port.  This includes Makefiles, linker scripts, and Kconfig
> files.  It also contains the only top-level change, which adds RISC-V to
> the list of architectures that need a sed run to produce the ARCH
> variable when building locally.
> 
> Signed-off-by: Palmer Dabbelt 
> ---
> 
> diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
> new file mode 100644
> index ..9b7d077f40af
> --- /dev/null
> +++ b/arch/riscv/Kconfig
> @@ -0,0 +1,275 @@
> +#
> +# For a description of the syntax of this configuration file,
> +# see Documentation/kbuild/kconfig-language.txt.
> +#

[]

drop the "default n" lines below:

> +config CMDLINE_BOOL
> + bool "Built-in kernel command line"
> + default n
> + help
> +   For most platforms, it is firmware or second stage bootloader
> +   that by default specifies the kernel command line options.
> +   However, it might be necessary or advantageous to either override
> +   the default kernel command line or add a few extra options to it.
> +   For such cases, this option allows hardcoding command line options
> +   directly into the kernel.
> +
> +   For that, choose 'Y' here and fill in the extra boot parameters
> +   in CONFIG_CMDLINE.
> +
> +   The built-in options will be concatenated to the default command
> +   line if CMDLINE_OVERRIDE is set to 'N'. Otherwise, the default
> +   command line will be ignored and replaced by the built-in string.
> +
> +config CMDLINE
> + string "Built-in kernel command string"
> + depends on CMDLINE_BOOL
> + default ""
> + help
> +   Supply command-line options at build time by entering them here.
> +
> +config CMDLINE_OVERRIDE
> + bool "Built-in command line overrides bootloader arguments"
> + default n
> + depends on CMDLINE_BOOL
> + help
> +   Set this option to 'Y' to have the kernel ignore the bootloader
> +   or firmware command line.  Instead, the built-in command line
> +   will be used exclusively.
> +
> +   If you don't know what to do here, say N.



-- 
~Randy