Re: [PATCH v9 9/9] certs: Add support for using elliptic curve keys for signing modules

2021-03-01 Thread Stefan Berger

On 2/26/21 10:35 PM, yumeng wrote:


在 2021/2/26 0:08, Stefan Berger 写道:

From: Stefan Berger 




diff --git a/certs/Makefile b/certs/Makefile
index 3fe6b73786fa..c487d7021c54 100644
--- a/certs/Makefile
+++ b/certs/Makefile
@@ -69,6 +69,18 @@ else
  SIGNER = -signkey $(obj)/signing_key.key
  endif # CONFIG_IMA_APPRAISE_MODSIG


Is there anything wrong in this patch?
I can't apply it when I use 'git am '.
errors like below:


This patch builds on top Nayna's series for 'kernel build support for
loading the kernel module signing key'.
-https://lkml.org/lkml/2021/2/18/856

 Stefan




Re: [PATCH v9 9/9] certs: Add support for using elliptic curve keys for signing modules

2021-03-01 Thread Mimi Zohar
On Sat, 2021-02-27 at 11:35 +0800, yumeng wrote:
> 在 2021/2/26 0:08, Stefan Berger 写道:
> > From: Stefan Berger 
> > 
> 
> > diff --git a/certs/Makefile b/certs/Makefile
> > index 3fe6b73786fa..c487d7021c54 100644
> > --- a/certs/Makefile
> > +++ b/certs/Makefile
> > @@ -69,6 +69,18 @@ else
> >   SIGNER = -signkey $(obj)/signing_key.key
> >   endif # CONFIG_IMA_APPRAISE_MODSIG
> >   
> 
> Is there anything wrong in this patch?
> I can't apply it when I use 'git am '.
> errors like below:
> 
> error: certs/Kconfig: does not match index
> error: patch failed: certs/Makefile:69
> error: certs/Makefile: patch does not apply
> 
> Thanks

Nothing wrong with the patch, just a dependency.  From the Change log:
   - This patch builds on top Nayna's series for 'kernel build support
   for loading the kernel module signing key'.
   - https://lkml.org/lkml/2021/2/18/856

thanks,

Mimi




Re: [PATCH v9 9/9] certs: Add support for using elliptic curve keys for signing modules

2021-02-26 Thread yumeng



在 2021/2/26 0:08, Stefan Berger 写道:

From: Stefan Berger 




diff --git a/certs/Makefile b/certs/Makefile
index 3fe6b73786fa..c487d7021c54 100644
--- a/certs/Makefile
+++ b/certs/Makefile
@@ -69,6 +69,18 @@ else
  SIGNER = -signkey $(obj)/signing_key.key
  endif # CONFIG_IMA_APPRAISE_MODSIG
  


Is there anything wrong in this patch?
I can't apply it when I use 'git am '.
errors like below:

error: certs/Kconfig: does not match index
error: patch failed: certs/Makefile:69
error: certs/Makefile: patch does not apply

Thanks