Re: [PATCHSET 00/17] tracing/uprobes: Add support for more fetch methods (v9)
Hi Oleg, On Mon, 23 Dec 2013 19:00:26 +0100, Oleg Nesterov wrote: > On 12/16, Namhyung Kim wrote: >> >> This patchset implements memory (address), stack[N], deference, >> bitfield, retval (it needs uretprobe tho) and file_offset fetch >> methods for uprobes. It's based on the previous work [1] done by >> Hyeoncheol Lee. > > I can't say I understand every change in details, but everything looks > fine to me. And this series addresses all my previous comments. > > FWIW, > > Acked-by: Oleg Nesterov Thank you so much for your review!! :) Namhyung -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCHSET 00/17] tracing/uprobes: Add support for more fetch methods (v9)
On 12/16, Namhyung Kim wrote: > > This patchset implements memory (address), stack[N], deference, > bitfield, retval (it needs uretprobe tho) and file_offset fetch > methods for uprobes. It's based on the previous work [1] done by > Hyeoncheol Lee. I can't say I understand every change in details, but everything looks fine to me. And this series addresses all my previous comments. FWIW, Acked-by: Oleg Nesterov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCHSET 00/17] tracing/uprobes: Add support for more fetch methods (v9)
Hi Steve, 2013-12-21 (토), 00:22 -0500, Steven Rostedt: > I applied all the patches and started testing and it failed to build, > with this error: > > > /home/rostedt/work/git/linux-trace.git/kernel/trace/trace_kprobe.c: In > function ‘kprobe_trace_self_tests_init’: > /home/rostedt/work/git/linux-trace.git/kernel/trace/trace_kprobe.c:1400:7: > error: ‘create_trace_probe’ undeclared (first use in this function) > /home/rostedt/work/git/linux-trace.git/kernel/trace/trace_kprobe.c:1400:7: > note: each undeclared identifier is reported only once for each function it > appears in > /home/rostedt/work/git/linux-trace.git/kernel/trace/trace_kprobe.c:1406:3: > error: implicit declaration of function ‘find_trace_probe’ > [-Werror=implicit-function-declaration] > /home/rostedt/work/git/linux-trace.git/kernel/trace/trace_kprobe.c:1406:6: > warning: assignment makes pointer from integer without a cast [enabled by > default] > /home/rostedt/work/git/linux-trace.git/kernel/trace/trace_kprobe.c:1416:5: > error: implicit declaration of function ‘enable_trace_probe’ > [-Werror=implicit-function-declaration] > /home/rostedt/work/git/linux-trace.git/kernel/trace/trace_kprobe.c:1427:6: > warning: assignment makes pointer from integer without a cast [enabled by > default] > /home/rostedt/work/git/linux-trace.git/kernel/trace/trace_kprobe.c:1447:5: > warning: assignment makes pointer from integer without a cast [enabled by > default] > /home/rostedt/work/git/linux-trace.git/kernel/trace/trace_kprobe.c:1457:4: > error: implicit declaration of function ‘disable_trace_probe’ > [-Werror=implicit-function-declaration] > /home/rostedt/work/git/linux-trace.git/kernel/trace/trace_kprobe.c:1460:5: > warning: assignment makes pointer from integer without a cast [enabled by > default] > /home/rostedt/work/git/linux-trace.git/kernel/trace/trace_kprobe.c:1486:2: > error: implicit declaration of function ‘release_all_trace_probes’ > [-Werror=implicit-function-declaration > ] > cc1: some warnings being treated as errors > distcc[17703] ERROR: compile > /home/rostedt/work/git/linux-trace.git/kernel/trace/trace_kprobe.c on > localhost failed > make[3]: *** [kernel/trace/trace_kprobe.o] Error 1 > make[3]: *** Waiting for unfinished jobs > > I applied it to my "ftrace/core" branch. > > I attached my config. Oops, sorry. I forgot to enable FTRACE_STARTUP_TEST. I've fixed it, rebased it onto ftrace/core and pushed to my "uprobe/fetch-v10" branch. Please test it again when you have time. :) Thanks, Namhyung -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/