Re: [PATCHv2] Bluetooth: trivial: tidy up printk message output from btrtl.
Hi, Marcel, On Thu, 26 Sep 2019 at 07:34, Marcel Holtmann wrote: > > Hi Rui, [patch snipped] > I have some similar patch in my tree. Can you check what is still missing and > send a new version. Thanks. Yeah, from a cursory look at your tree, it seems about the same as mine. I'll take a deeper look later on (can't access the laptops to test, ATM) and send a patch with any missing stuff, if needed. Thanks, Rui
Re: [PATCHv2] Bluetooth: trivial: tidy up printk message output from btrtl.
Hi Rui, > v2: also remove new line from hci_h5.c > > The rtl_dev_* calls in the Realtek USB Bluetooth driver add unnecessary > device prefixes and new lines at the end of most messages, which make the > dmesg output look like this: > > [5.667121] sd 0:0:0:0: [sda] Attached SCSI disk > [5.736869] Bluetooth: hci0: RTL: rtl: examining hci_ver=06 hci_rev=000a > lmp_ver=06 lmp_subver=8821 > > [5.737853] Bluetooth: hci0: RTL: rom_version status=0 version=1 > > [5.737857] Bluetooth: hci0: RTL: rtl: loading rtl_bt/rtl8821a_fw.bin > > [5.737946] Bluetooth: hci0: RTL: rtl: loading rtl_bt/rtl8821a_config.bin > > [5.737965] bluetooth hci0: Direct firmware load for > rtl_bt/rtl8821a_config.bin failed with error -2 > [5.737972] Bluetooth: hci0: RTL: cfg_sz -2, total sz 17428 > > [5.997375] ata2: SATA link up 1.5 Gbps (SStatus 113 SControl 300) > > Clean this up by removing extraneous new lines and redundant device prefixes, > with the following result: > > [5.667008] sd 0:0:0:0: [sda] Attached SCSI disk > [5.716945] Bluetooth: hci0: rtl: examining hci_ver=06 hci_rev=000a > lmp_ver=06 lmp_subver=8821 > [5.718745] Bluetooth: hci0: rtl: rom_version status=0 version=1 > [5.718749] Bluetooth: hci0: rtl: loading rtl_bt/rtl8821a_fw.bin > [5.718830] Bluetooth: hci0: rtl: loading rtl_bt/rtl8821a_config.bin > [5.718849] bluetooth hci0: Direct firmware load for > rtl_bt/rtl8821a_config.bin failed with error -2 > [5.718858] Bluetooth: hci0: rtl: cfg_sz -2, total sz 17428 > [5.997400] ata2: SATA link up 1.5 Gbps (SStatus 113 SControl 300) > > Signed-off-by: Rui Salvaterra > --- > drivers/bluetooth/btrtl.c | 62 +++--- > drivers/bluetooth/btrtl.h | 8 ++--- > drivers/bluetooth/hci_h5.c | 2 +- > 3 files changed, 36 insertions(+), 36 deletions(-) I have some similar patch in my tree. Can you check what is still missing and send a new version. Thanks. Regards Marcel
