Re: [PATCHv2 57/59] x86/mktme: Document the MKTME Key Service API

[Ben Boeckel]

On Mon, Aug 05, 2019 at 13:44:53 -0700, Alison Schofield wrote:
> Yes. Fixed up as follows:
> 
>   Add a "no-encrypt' type key::
> 
> char \*options_NOENCRYPT = "type=no-encrypt";
> 
> key = add_key("mktme", "name", options_NOENCRYPT,
>   strlen(options_NOENCRYPT), KEY_SPEC_THREAD_KEYRING);

Thanks. Looks good to me.

Reviewed-by: Ben Boeckel 

--Ben

Re: [PATCHv2 57/59] x86/mktme: Document the MKTME Key Service API

[Alison Schofield]

On Mon, Aug 05, 2019 at 07:58:37AM -0400, Ben Boeckel wrote:
> On Wed, Jul 31, 2019 at 18:08:11 +0300, Kirill A. Shutemov wrote:
> > +   key = add_key("mktme", "name", "no-encrypt", strlen(options_CPU),
> > + KEY_SPEC_THREAD_KEYRING);
> 
> Should this be `type=no-encrypt` here? Also, seems like copy/paste from
> the `type=cpu` case for the `strlen` call.
> 
> --Ben

Yes. Fixed up as follows:

Add a "no-encrypt' type key::

char \*options_NOENCRYPT = "type=no-encrypt";

key = add_key("mktme", "name", options_NOENCRYPT,
  strlen(options_NOENCRYPT), KEY_SPEC_THREAD_KEYRING);

Thanks for the review,
Alison

Re: [PATCHv2 57/59] x86/mktme: Document the MKTME Key Service API

[Ben Boeckel]

On Wed, Jul 31, 2019 at 18:08:11 +0300, Kirill A. Shutemov wrote:
> + key = add_key("mktme", "name", "no-encrypt", strlen(options_CPU),
> +   KEY_SPEC_THREAD_KEYRING);

Should this be `type=no-encrypt` here? Also, seems like copy/paste from
the `type=cpu` case for the `strlen` call.

--Ben