Re: [PATCHv6 6/6] coresight: debug: Add Unique Component Identifier (UCI) table
On 2/1/2019 6:17 AM, Sai Prakash Ranjan wrote:
On 1/31/2019 11:31 PM, Suzuki K Poulose wrote:
On 31/01/2019 14:22, Sai Prakash Ranjan wrote:
Add UCI table for coresight CPU debug module. This patch adds
the UCI entries for Kryo CPUs found on MSM8996 which shares
the same PIDs as ETMs.
Without this, below error is observed on MSM8996:
nit: Subject doesn't match the patch contents. You could simply say :
coresight: cpu-debug: Add support for Qualcomm Kryo
Done.
diff --git a/drivers/hwtracing/coresight/coresight-cpu-debug.c
b/drivers/hwtracing/coresight/coresight-cpu-debug.c
index e8819d750938..915d86a39cee 100644
--- a/drivers/hwtracing/coresight/coresight-cpu-debug.c
+++ b/drivers/hwtracing/coresight/coresight-cpu-debug.c
@@ -655,24 +655,23 @@ static int debug_remove(struct amba_device *adev)
return 0;
}
+static struct amba_cs_uci_id uci_id_debug[] = {
As Stephen mentioned, this must be "const".
Rest looks fine.
Done.
Also it should be changed in Mike's patch I suppose or else:
In file included from
drivers/hwtracing/coresight/coresight-cpu-debug.c:26:0:
drivers/hwtracing/coresight/coresight-cpu-debug.c:672:29: warning:
initialization discards ‘const’ qualifier from pointer target type
[-Wdiscarded-qualifiers]
CS_AMBA_UCI_ID(0x000f0205, uci_id_debug), /* Qualcomm Kryo */
^
drivers/hwtracing/coresight/coresight-priv.h:192:11: note: in definition
of macro ‘CS_AMBA_UCI_ID’
.data = uci_ptr \
^~~
drivers/hwtracing/coresight/coresight-cpu-debug.c:673:29: warning:
initialization discards ‘const’ qualifier from pointer target type
[-Wdiscarded-qualifiers]
CS_AMBA_UCI_ID(0x000f0211, uci_id_debug), /* Qualcomm Kryo */
^
drivers/hwtracing/coresight/coresight-priv.h:192:11: note: in definition
of macro ‘CS_AMBA_UCI_ID’
.data = uci_ptr \
^~~
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
Re: [PATCHv6 6/6] coresight: debug: Add Unique Component Identifier (UCI) table
On 1/31/2019 11:31 PM, Suzuki K Poulose wrote:
On 31/01/2019 14:22, Sai Prakash Ranjan wrote:
Add UCI table for coresight CPU debug module. This patch adds
the UCI entries for Kryo CPUs found on MSM8996 which shares
the same PIDs as ETMs.
Without this, below error is observed on MSM8996:
nit: Subject doesn't match the patch contents. You could simply say :
coresight: cpu-debug: Add support for Qualcomm Kryo
Done.
diff --git a/drivers/hwtracing/coresight/coresight-cpu-debug.c
b/drivers/hwtracing/coresight/coresight-cpu-debug.c
index e8819d750938..915d86a39cee 100644
--- a/drivers/hwtracing/coresight/coresight-cpu-debug.c
+++ b/drivers/hwtracing/coresight/coresight-cpu-debug.c
@@ -655,24 +655,23 @@ static int debug_remove(struct amba_device *adev)
return 0;
}
+static struct amba_cs_uci_id uci_id_debug[] = {
As Stephen mentioned, this must be "const".
Rest looks fine.
Done.
Thanks,
Sai
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
Re: [PATCHv6 6/6] coresight: debug: Add Unique Component Identifier (UCI) table
On 1/31/2019 10:01 PM, Stephen Boyd wrote:
Quoting Sai Prakash Ranjan (2019-01-31 06:22:24)
diff --git a/drivers/hwtracing/coresight/coresight-cpu-debug.c
b/drivers/hwtracing/coresight/coresight-cpu-debug.c
index e8819d750938..915d86a39cee 100644
--- a/drivers/hwtracing/coresight/coresight-cpu-debug.c
+++ b/drivers/hwtracing/coresight/coresight-cpu-debug.c
@@ -655,24 +655,23 @@ static int debug_remove(struct amba_device *adev)
return 0;
}
+static struct amba_cs_uci_id uci_id_debug[] = {
Can this be const?
+ {
+ /* CPU Debug UCI data */
+ .devarch= 0x47706a15,
+ .devarch_mask = 0xfff0,
+ .devtype= 0x0015,
+ }
+};
Yes and done in next version, thanks.
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
Re: [PATCHv6 6/6] coresight: debug: Add Unique Component Identifier (UCI) table
On 31/01/2019 14:22, Sai Prakash Ranjan wrote:
Add UCI table for coresight CPU debug module. This patch adds
the UCI entries for Kryo CPUs found on MSM8996 which shares
the same PIDs as ETMs.
Without this, below error is observed on MSM8996:
nit: Subject doesn't match the patch contents. You could simply say :
coresight: cpu-debug: Add support for Qualcomm Kryo
[5.429867] OF: graph: no port node found in /soc/debug@381
[5.429938] coresight-etm4x: probe of 381.debug failed with error -22
[5.435415] coresight-cpu-debug 381.debug: Coresight debug-CPU0
initialized
[5.446474] OF: graph: no port node found in /soc/debug@391
[5.448927] coresight-etm4x: probe of 391.debug failed with error -22
[5.454681] coresight-cpu-debug 391.debug: Coresight debug-CPU1
initialized
[5.487765] OF: graph: no port node found in /soc/debug@3a1
[5.488007] coresight-etm4x: probe of 3a1.debug failed with error -22
[5.493024] coresight-cpu-debug 3a1.debug: Coresight debug-CPU2
initialized
[5.501802] OF: graph: no port node found in /soc/debug@3b1
[5.512901] coresight-etm4x: probe of 3b1.debug failed with error -22
[5.513192] coresight-cpu-debug 3b1.debug: Coresight debug-CPU3
initialized
Signed-off-by: Sai Prakash Ranjan
---
For testing, all dependent patches are in below tree:
* https://github.com/saiprakash-ranjan/linux/tree/coresight-next
This patch depends on UCI support by Mike Leach in below link:
* https://lore.kernel.org/lkml/20190130234051.2294-1-mike.le...@linaro.org/
---
.../hwtracing/coresight/coresight-cpu-debug.c | 33 +--
1 file changed, 16 insertions(+), 17 deletions(-)
diff --git a/drivers/hwtracing/coresight/coresight-cpu-debug.c
b/drivers/hwtracing/coresight/coresight-cpu-debug.c
index e8819d750938..915d86a39cee 100644
--- a/drivers/hwtracing/coresight/coresight-cpu-debug.c
+++ b/drivers/hwtracing/coresight/coresight-cpu-debug.c
@@ -655,24 +655,23 @@ static int debug_remove(struct amba_device *adev)
return 0;
}
+static struct amba_cs_uci_id uci_id_debug[] = {
As Stephen mentioned, this must be "const".
Rest looks fine.
Suzuki
Re: [PATCHv6 6/6] coresight: debug: Add Unique Component Identifier (UCI) table
Quoting Sai Prakash Ranjan (2019-01-31 06:22:24)
> diff --git a/drivers/hwtracing/coresight/coresight-cpu-debug.c
> b/drivers/hwtracing/coresight/coresight-cpu-debug.c
> index e8819d750938..915d86a39cee 100644
> --- a/drivers/hwtracing/coresight/coresight-cpu-debug.c
> +++ b/drivers/hwtracing/coresight/coresight-cpu-debug.c
> @@ -655,24 +655,23 @@ static int debug_remove(struct amba_device *adev)
> return 0;
> }
>
> +static struct amba_cs_uci_id uci_id_debug[] = {
Can this be const?
> + {
> + /* CPU Debug UCI data */
> + .devarch= 0x47706a15,
> + .devarch_mask = 0xfff0,
> + .devtype= 0x0015,
> + }
> +};
