Re: [RESEND PATCH v6 02/11] dt-bindings: power: supply: add DT bindings for max77650
pt., 22 mar 2019 o 10:00 Pavel Machek napisał(a): > > On Mon 2019-03-18 18:40:31, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > > > Add the DT binding document for the battery charger module of max77650. > > > > Signed-off-by: Bartosz Golaszewski > > --- > > .../power/supply/max77650-charger.txt | 27 +++ > > 1 file changed, 27 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/power/supply/max77650-charger.txt > > > > diff --git > > a/Documentation/devicetree/bindings/power/supply/max77650-charger.txt > > b/Documentation/devicetree/bindings/power/supply/max77650-charger.txt > > new file mode 100644 > > index ..d25c95369616 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/power/supply/max77650-charger.txt > > @@ -0,0 +1,27 @@ > > +Battery charger driver for MAX77650 PMIC from Maxim Integrated. > > + > > +This module is part of the MAX77650 MFD device. For more details > > +see Documentation/devicetree/bindings/mfd/max77650.txt. > > + > > +The charger is represented as a sub-node of the PMIC node on the device > > tree. > > + > > +Required properties: > > + > > +- compatible:Must be "maxim,max77650-charger" > > + > > +Optional properties: > > + > > +- min-microvolt: Minimum CHGIN regulation voltage (in microvolts). > > Must be > > + one of: 400, 410, 420, 430, 440, > > + 450, 460, 470. > > Probably needs "max," prefix. And .. what does this mean? Will charger > shutdown if input is less than this? > The charger will enter the undervoltage lockout state and stop charging, this is explained in the manual, so I don't think the bindings are the right place to add this information. Bart > > +- curr-lim-microamp: CHGIN input current limit (in microamps). Must be one > > of: > > + 95000, 19, 285000, 38, 475000. > > "current-limit-microamp", I guess. And probably "max,current-limit-microamp". > > -- > (english) http://www.livejournal.com/~pavelmachek > (cesky, pictures) > http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Re: [RESEND PATCH v6 02/11] dt-bindings: power: supply: add DT bindings for max77650
On Mon, Mar 18, 2019 at 06:42:19PM +0100, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Add the DT binding document for the battery charger module of max77650. > > Signed-off-by: Bartosz Golaszewski > --- > .../power/supply/max77650-charger.txt | 27 +++ > 1 file changed, 27 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/power/supply/max77650-charger.txt > > diff --git > a/Documentation/devicetree/bindings/power/supply/max77650-charger.txt > b/Documentation/devicetree/bindings/power/supply/max77650-charger.txt > new file mode 100644 > index ..d25c95369616 > --- /dev/null > +++ b/Documentation/devicetree/bindings/power/supply/max77650-charger.txt > @@ -0,0 +1,27 @@ > +Battery charger driver for MAX77650 PMIC from Maxim Integrated. > + > +This module is part of the MAX77650 MFD device. For more details > +see Documentation/devicetree/bindings/mfd/max77650.txt. > + > +The charger is represented as a sub-node of the PMIC node on the device tree. > + > +Required properties: > + > +- compatible:Must be "maxim,max77650-charger" > + > +Optional properties: > + > +- min-microvolt: Minimum CHGIN regulation voltage (in microvolts). Must > be > + one of: 400, 410, 420, 430, 440, > + 450, 460, 470. > +- curr-lim-microamp: CHGIN input current limit (in microamps). Must be one > of: > + 95000, 19, 285000, 38, 475000. These should be common charger properties IMO. Rob
Re: [RESEND PATCH v6 02/11] dt-bindings: power: supply: add DT bindings for max77650
On Mon 2019-03-18 18:40:31, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Add the DT binding document for the battery charger module of max77650. > > Signed-off-by: Bartosz Golaszewski > --- > .../power/supply/max77650-charger.txt | 27 +++ > 1 file changed, 27 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/power/supply/max77650-charger.txt > > diff --git > a/Documentation/devicetree/bindings/power/supply/max77650-charger.txt > b/Documentation/devicetree/bindings/power/supply/max77650-charger.txt > new file mode 100644 > index ..d25c95369616 > --- /dev/null > +++ b/Documentation/devicetree/bindings/power/supply/max77650-charger.txt > @@ -0,0 +1,27 @@ > +Battery charger driver for MAX77650 PMIC from Maxim Integrated. > + > +This module is part of the MAX77650 MFD device. For more details > +see Documentation/devicetree/bindings/mfd/max77650.txt. > + > +The charger is represented as a sub-node of the PMIC node on the device tree. > + > +Required properties: > + > +- compatible:Must be "maxim,max77650-charger" > + > +Optional properties: > + > +- min-microvolt: Minimum CHGIN regulation voltage (in microvolts). Must > be > + one of: 400, 410, 420, 430, 440, > + 450, 460, 470. Probably needs "max," prefix. And .. what does this mean? Will charger shutdown if input is less than this? > +- curr-lim-microamp: CHGIN input current limit (in microamps). Must be one > of: > + 95000, 19, 285000, 38, 475000. "current-limit-microamp", I guess. And probably "max,current-limit-microamp". -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html signature.asc Description: Digital signature
