Re: [RFC/PATCH] Use kernel supplied MMU info for kvm tool
On Wed, 18 Jul 2012, Michael Ellerman wrote: > It occurred to me overnight that I forgot to mention that in order to > build the new code you need the headers from a 3.5-rc1 era kernel (for > the ioctl & KVM_CAP definitions). > > The easiest way to do that is to merge linus' tree into kvmtool. > > Are you planning on doing that in the master kvmtool tree anytime soon? > It's still based on 3.4-rc1 it seems. Done. Sorry for the delay! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RFC/PATCH] Use kernel supplied MMU info for kvm tool
On Wed, 18 Jul 2012, Michael Ellerman wrote: It occurred to me overnight that I forgot to mention that in order to build the new code you need the headers from a 3.5-rc1 era kernel (for the ioctl KVM_CAP definitions). The easiest way to do that is to merge linus' tree into kvmtool. Are you planning on doing that in the master kvmtool tree anytime soon? It's still based on 3.4-rc1 it seems. Done. Sorry for the delay! -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RFC/PATCH] Use kernel supplied MMU info for kvm tool
On Tue, 2012-07-17 at 17:09 +0300, Pekka Enberg wrote: > On Tue, Jul 17, 2012 at 12:33 PM, Matt Evans wrote: > > Just had a look, all good. Thanks for tidying some old FIXMEs, especially > > the page/segment DT props encoding grot -- and the designated inits in the > > cpuinfo struct, whew, I heard the scream on IRC. Sorry. ;-) > > > > Acked-by: Matt Evans > > Applied, thanks guys! Thanks Pekka. It occurred to me overnight that I forgot to mention that in order to build the new code you need the headers from a 3.5-rc1 era kernel (for the ioctl & KVM_CAP definitions). The easiest way to do that is to merge linus' tree into kvmtool. Are you planning on doing that in the master kvmtool tree anytime soon? It's still based on 3.4-rc1 it seems. cheers -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RFC/PATCH] Use kernel supplied MMU info for kvm tool
On Tue, 2012-07-17 at 10:33 +0100, Matt Evans wrote: > Hi Michael, > > On 2012-07-17 06:00, Michael Ellerman wrote: > > > This is a series for kvmtool that uses a newish kernel API to get > > MMU info, which is then fed to the guest. > > > > Currently we just make a good guess based on the PVR, but that is > > potentially flakey in a few ways. The most notable is that if you > > don't > > specify hugepages we don't boot - because the guest is told we > > support > > 16M pages, but we don't really (on HV). > > Just had a look, all good. Thanks for tidying some old FIXMEs, > especially the page/segment DT props encoding grot -- and the designated > inits in the cpuinfo struct, whew, I heard the scream on IRC. Sorry. > ;-) Thanks Matt, no worries about the grot, there was no better way when you wrote the original code. The lack of designated inits did bite me quite well, while bisecting I accidentally dropped the hunk that updated the struct definition but kept the hunk that changed the initialisation - leading to a VM with a slb size of 51200 (tb_freq) etc. :) cheers -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RFC/PATCH] Use kernel supplied MMU info for kvm tool
On Tue, Jul 17, 2012 at 12:33 PM, Matt Evans wrote: > Just had a look, all good. Thanks for tidying some old FIXMEs, especially > the page/segment DT props encoding grot -- and the designated inits in the > cpuinfo struct, whew, I heard the scream on IRC. Sorry. ;-) > > Acked-by: Matt Evans Applied, thanks guys! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RFC/PATCH] Use kernel supplied MMU info for kvm tool
Hi Michael, On 2012-07-17 06:00, Michael Ellerman wrote: This is a series for kvmtool that uses a newish kernel API to get MMU info, which is then fed to the guest. Currently we just make a good guess based on the PVR, but that is potentially flakey in a few ways. The most notable is that if you don't specify hugepages we don't boot - because the guest is told we support 16M pages, but we don't really (on HV). Just had a look, all good. Thanks for tidying some old FIXMEs, especially the page/segment DT props encoding grot -- and the designated inits in the cpuinfo struct, whew, I heard the scream on IRC. Sorry. ;-) Acked-by: Matt Evans Matt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RFC/PATCH] Use kernel supplied MMU info for kvm tool
Hi Michael, On 2012-07-17 06:00, Michael Ellerman wrote: This is a series for kvmtool that uses a newish kernel API to get MMU info, which is then fed to the guest. Currently we just make a good guess based on the PVR, but that is potentially flakey in a few ways. The most notable is that if you don't specify hugepages we don't boot - because the guest is told we support 16M pages, but we don't really (on HV). Just had a look, all good. Thanks for tidying some old FIXMEs, especially the page/segment DT props encoding grot -- and the designated inits in the cpuinfo struct, whew, I heard the scream on IRC. Sorry. ;-) Acked-by: Matt Evans m...@ozlabs.org Matt -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RFC/PATCH] Use kernel supplied MMU info for kvm tool
On Tue, Jul 17, 2012 at 12:33 PM, Matt Evans m...@ozlabs.org wrote: Just had a look, all good. Thanks for tidying some old FIXMEs, especially the page/segment DT props encoding grot -- and the designated inits in the cpuinfo struct, whew, I heard the scream on IRC. Sorry. ;-) Acked-by: Matt Evans m...@ozlabs.org Applied, thanks guys! -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RFC/PATCH] Use kernel supplied MMU info for kvm tool
On Tue, 2012-07-17 at 10:33 +0100, Matt Evans wrote: Hi Michael, On 2012-07-17 06:00, Michael Ellerman wrote: This is a series for kvmtool that uses a newish kernel API to get MMU info, which is then fed to the guest. Currently we just make a good guess based on the PVR, but that is potentially flakey in a few ways. The most notable is that if you don't specify hugepages we don't boot - because the guest is told we support 16M pages, but we don't really (on HV). Just had a look, all good. Thanks for tidying some old FIXMEs, especially the page/segment DT props encoding grot -- and the designated inits in the cpuinfo struct, whew, I heard the scream on IRC. Sorry. ;-) Thanks Matt, no worries about the grot, there was no better way when you wrote the original code. The lack of designated inits did bite me quite well, while bisecting I accidentally dropped the hunk that updated the struct definition but kept the hunk that changed the initialisation - leading to a VM with a slb size of 51200 (tb_freq) etc. :) cheers -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RFC/PATCH] Use kernel supplied MMU info for kvm tool
On Tue, 2012-07-17 at 17:09 +0300, Pekka Enberg wrote: On Tue, Jul 17, 2012 at 12:33 PM, Matt Evans m...@ozlabs.org wrote: Just had a look, all good. Thanks for tidying some old FIXMEs, especially the page/segment DT props encoding grot -- and the designated inits in the cpuinfo struct, whew, I heard the scream on IRC. Sorry. ;-) Acked-by: Matt Evans m...@ozlabs.org Applied, thanks guys! Thanks Pekka. It occurred to me overnight that I forgot to mention that in order to build the new code you need the headers from a 3.5-rc1 era kernel (for the ioctl KVM_CAP definitions). The easiest way to do that is to merge linus' tree into kvmtool. Are you planning on doing that in the master kvmtool tree anytime soon? It's still based on 3.4-rc1 it seems. cheers -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
