Re: [RFC][PATCH 01/17 v2] tracing: Add TRACE_SYSTEM_VAR to intel-sst
On Thu, Apr 02, 2015 at 10:03:24AM -0400, Steven Rostedt wrote: > So that's an Acked-by then? :-) Sure. signature.asc Description: Digital signature
Re: [RFC][PATCH 01/17 v2] tracing: Add TRACE_SYSTEM_VAR to intel-sst
On Thu, 2 Apr 2015 14:59:33 +0100 Mark Brown wrote: > On Thu, Apr 02, 2015 at 09:49:34AM -0400, Steven Rostedt wrote: > > Mark Brown wrote: > > > > I guess, you probably want to ping the Intel guys though since it's them > > > that would be affected by the interface change. > > > Actually, there's no interface change. This is the work-around patch to > > that. It's only internal to the kernel and userspace does not see any > > difference. > > Ah, OK - that's definitely not an issue then. So that's an Acked-by then? :-) -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RFC][PATCH 01/17 v2] tracing: Add TRACE_SYSTEM_VAR to intel-sst
On Thu, Apr 02, 2015 at 09:49:34AM -0400, Steven Rostedt wrote: > Mark Brown wrote: > > I guess, you probably want to ping the Intel guys though since it's them > > that would be affected by the interface change. > Actually, there's no interface change. This is the work-around patch to > that. It's only internal to the kernel and userspace does not see any > difference. Ah, OK - that's definitely not an issue then. signature.asc Description: Digital signature
Re: [RFC][PATCH 01/17 v2] tracing: Add TRACE_SYSTEM_VAR to intel-sst
On Thu, 2 Apr 2015 14:40:33 +0100 Mark Brown wrote: > On Thu, Apr 02, 2015 at 09:33:41AM -0400, Steven Rostedt wrote: > > Steven Rostedt wrote: > > > > I couldn't find anything in MAINTAINERS about that file, but I didn't > > > look for your name though. > > > BTW, was that considered an Acked-by? > > I guess, you probably want to ping the Intel guys though since it's them > that would be affected by the interface change. Actually, there's no interface change. This is the work-around patch to that. It's only internal to the kernel and userspace does not see any difference. I just needed a unique TRACE_SYSTEM name that was also a valid C variable, and now use TRACE_SYSTEM_VAR. The ftrace code now has: #ifndef TRACE_SYSTEM_VAR #define TRACE_SYSTEM_VAR TRACE_SYSTEM #endif And this allows trace headers (like intel-sst.h) to have a different VAR variable from the TRACE_SYSTEM name: #define TRACE_SYSTEM intel-ssl #define TRACE_SYSTEM_VAR intel_ssl This lets me use something that will work and not need to change what the user space sees. -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RFC][PATCH 01/17 v2] tracing: Add TRACE_SYSTEM_VAR to intel-sst
On Thu, Apr 02, 2015 at 09:33:41AM -0400, Steven Rostedt wrote: > Steven Rostedt wrote: > > I couldn't find anything in MAINTAINERS about that file, but I didn't > > look for your name though. > BTW, was that considered an Acked-by? I guess, you probably want to ping the Intel guys though since it's them that would be affected by the interface change. signature.asc Description: Digital signature
Re: [RFC][PATCH 01/17 v2] tracing: Add TRACE_SYSTEM_VAR to intel-sst
On Thu, 2 Apr 2015 10:16:22 +0100 Mark Brown wrote: > On 2 April 2015 at 02:56, Steven Rostedt wrote: > > > From: "Steven Rostedt (Red Hat)" > > > > New code will require TRACE_SYSTEM to be a valid C variable name, > > but some tracepoints have TRACE_SYSTEM with '-' and not '_', so > > it can not be used. Instead, add a TRACE_SYSTEM_VAR that can > > give the tracing infrastructure a unique name for the trace system. > > > > Cc: Mark Brown > > > > I'm not sure why you're sending this to my work address but please use > broo...@kernel.org for anything upstream (it's what's in MAINTAINERS and > what I've been using pretty consistently for e-mail). > Sorry, I got that from git log include/trace/events/intel-sst.h I couldn't find anything in MAINTAINERS about that file, but I didn't look for your name though. -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RFC][PATCH 01/17 v2] tracing: Add TRACE_SYSTEM_VAR to intel-sst
On Thu, 2 Apr 2015 09:32:49 -0400 Steven Rostedt wrote: > On Thu, 2 Apr 2015 10:16:22 +0100 > Mark Brown wrote: > > > On 2 April 2015 at 02:56, Steven Rostedt wrote: > > > > > From: "Steven Rostedt (Red Hat)" > > > > > > New code will require TRACE_SYSTEM to be a valid C variable name, > > > but some tracepoints have TRACE_SYSTEM with '-' and not '_', so > > > it can not be used. Instead, add a TRACE_SYSTEM_VAR that can > > > give the tracing infrastructure a unique name for the trace system. > > > > > > Cc: Mark Brown > > > > > > > I'm not sure why you're sending this to my work address but please use > > broo...@kernel.org for anything upstream (it's what's in MAINTAINERS and > > what I've been using pretty consistently for e-mail). > > > > Sorry, I got that from git log include/trace/events/intel-sst.h > > I couldn't find anything in MAINTAINERS about that file, but I didn't > look for your name though. > BTW, was that considered an Acked-by? -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
