Re: [RFC 0/4] perf tools: Remove event types data
Em Wed, Jul 10, 2013 at 09:49:40AM +0200, Jiri Olsa escreveu: > On Wed, Jul 10, 2013 at 08:11:48AM +0200, Thomas Renninger wrote: > > On Tuesday, July 09, 2013 06:48:55 PM Jiri Olsa wrote: > > > hi, > > > following up on the 'perf timechart' FIXME note and changing > > > its tracepoint match not to use event types data. > > > > Looks sane and pretty straight forward. > > Still I am not that deep involved in perf to give a Reviewed-by: quickly... In such cases an "Acked-by:" seems adequate enough, right? I'm merging this now, so will not add it, but please let us know if that would be ok, I may go thru some rebase and then would add that line. > thanks, I saw your name in changelog.. wanted to include > someone who probably uses timechart command ;-) > > > > > #define SUPPORT_OLD_POWER_EVENTS > > could also vanish, maybe with the next round. > > ok > > jirka > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RFC 0/4] perf tools: Remove event types data
Em Wed, Jul 10, 2013 at 09:49:40AM +0200, Jiri Olsa escreveu: On Wed, Jul 10, 2013 at 08:11:48AM +0200, Thomas Renninger wrote: On Tuesday, July 09, 2013 06:48:55 PM Jiri Olsa wrote: hi, following up on the 'perf timechart' FIXME note and changing its tracepoint match not to use event types data. Looks sane and pretty straight forward. Still I am not that deep involved in perf to give a Reviewed-by: quickly... In such cases an Acked-by: seems adequate enough, right? I'm merging this now, so will not add it, but please let us know if that would be ok, I may go thru some rebase and then would add that line. thanks, I saw your name in changelog.. wanted to include someone who probably uses timechart command ;-) #define SUPPORT_OLD_POWER_EVENTS could also vanish, maybe with the next round. ok jirka -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RFC 0/4] perf tools: Remove event types data
On Tue, 9 Jul 2013 18:48:55 +0200, Jiri Olsa wrote: > hi, > following up on the 'perf timechart' FIXME note and changing > its tracepoint match not to use event types data. > > In my tests the old and new timechart outputs look the same, > so.. any other tester would be appreciated ;-) > > Also as this was the only user of the event types data > the rest of the patchset is removing it out of the perf. > > The event types data are referenced from the perf data > file header. The reference (offset & size) stays in the > header with 0s. > > Also the event types data is already duplicated via the > event_desc FEATURE, so there's no information loss. I generally agree on removing the event_types but have a couple of issues on patch 1. Please see my comments on it. Thanks, Namhyung -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RFC 0/4] perf tools: Remove event types data
On Tue, 9 Jul 2013 18:48:55 +0200, Jiri Olsa wrote: hi, following up on the 'perf timechart' FIXME note and changing its tracepoint match not to use event types data. In my tests the old and new timechart outputs look the same, so.. any other tester would be appreciated ;-) Also as this was the only user of the event types data the rest of the patchset is removing it out of the perf. The event types data are referenced from the perf data file header. The reference (offset size) stays in the header with 0s. Also the event types data is already duplicated via the event_desc FEATURE, so there's no information loss. I generally agree on removing the event_types but have a couple of issues on patch 1. Please see my comments on it. Thanks, Namhyung -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RFC 0/4] perf tools: Remove event types data
On Wed, Jul 10, 2013 at 08:11:48AM +0200, Thomas Renninger wrote: > On Tuesday, July 09, 2013 06:48:55 PM Jiri Olsa wrote: > > hi, > > following up on the 'perf timechart' FIXME note and changing > > its tracepoint match not to use event types data. > > Looks sane and pretty straight forward. > Still I am not that deep involved in perf to give a Reviewed-by: quickly... thanks, I saw your name in changelog.. wanted to include someone who probably uses timechart command ;-) > > #define SUPPORT_OLD_POWER_EVENTS > could also vanish, maybe with the next round. ok jirka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RFC 0/4] perf tools: Remove event types data
On Tuesday, July 09, 2013 06:48:55 PM Jiri Olsa wrote: > hi, > following up on the 'perf timechart' FIXME note and changing > its tracepoint match not to use event types data. Looks sane and pretty straight forward. Still I am not that deep involved in perf to give a Reviewed-by: quickly... #define SUPPORT_OLD_POWER_EVENTS could also vanish, maybe with the next round. Thomas -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RFC 0/4] perf tools: Remove event types data
On Tuesday, July 09, 2013 06:48:55 PM Jiri Olsa wrote: hi, following up on the 'perf timechart' FIXME note and changing its tracepoint match not to use event types data. Looks sane and pretty straight forward. Still I am not that deep involved in perf to give a Reviewed-by: quickly... #define SUPPORT_OLD_POWER_EVENTS could also vanish, maybe with the next round. Thomas -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RFC 0/4] perf tools: Remove event types data
On Wed, Jul 10, 2013 at 08:11:48AM +0200, Thomas Renninger wrote: On Tuesday, July 09, 2013 06:48:55 PM Jiri Olsa wrote: hi, following up on the 'perf timechart' FIXME note and changing its tracepoint match not to use event types data. Looks sane and pretty straight forward. Still I am not that deep involved in perf to give a Reviewed-by: quickly... thanks, I saw your name in changelog.. wanted to include someone who probably uses timechart command ;-) #define SUPPORT_OLD_POWER_EVENTS could also vanish, maybe with the next round. ok jirka -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RFC 0/4] perf tools: Remove event types data
On Tue, Jul 09, 2013 at 06:48:55PM +0200, Jiri Olsa wrote: > hi, > following up on the 'perf timechart' FIXME note and changing > its tracepoint match not to use event types data. > > In my tests the old and new timechart outputs look the same, > so.. any other tester would be appreciated ;-) > > Also as this was the only user of the event types data > the rest of the patchset is removing it out of the perf. > > The event types data are referenced from the perf data > file header. The reference (offset & size) stays in the > header with 0s. > > Also the event types data is already duplicated via the > event_desc FEATURE, so there's no information loss. > > thanks for comments, > jirka forgot to mention, it's available at: git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git perf/et1 jirka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RFC 0/4] perf tools: Remove event types data
On Tue, Jul 09, 2013 at 06:48:55PM +0200, Jiri Olsa wrote: hi, following up on the 'perf timechart' FIXME note and changing its tracepoint match not to use event types data. In my tests the old and new timechart outputs look the same, so.. any other tester would be appreciated ;-) Also as this was the only user of the event types data the rest of the patchset is removing it out of the perf. The event types data are referenced from the perf data file header. The reference (offset size) stays in the header with 0s. Also the event types data is already duplicated via the event_desc FEATURE, so there's no information loss. thanks for comments, jirka forgot to mention, it's available at: git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git perf/et1 jirka -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
