Re: [RFC 06/10] thermal: samsung: Remove support for Exynos5440
On Thu, Apr 26, 2018 at 3:41 AM, Chanwoo Choi wrote: > Hi Krzysztof, > > On 2018년 04월 25일 05:32, Krzysztof Kozlowski wrote: >> The Exynos5440 is not actively developed, there are no development >> boards available and probably there are no real products with it. >> Remove wide-tree support for Exynos5440. >> >> Signed-off-by: Krzysztof Kozlowski >> --- >> .../devicetree/bindings/thermal/exynos-thermal.txt | 14 +- >> drivers/thermal/samsung/exynos_tmu.c | 155 >> + >> drivers/thermal/samsung/exynos_tmu.h | 1 - >> 3 files changed, 4 insertions(+), 166 deletions(-) > > > After applied this patch, I tested the build and found out > 'exynos5440' keyword. There is one comment including 'exynos5440' as > following: > > diff --git a/drivers/thermal/samsung/exynos_tmu.c > b/drivers/thermal/samsung/exynos_tmu.c > index f92f470bce21..cb525228cfe1 100644 > --- a/drivers/thermal/samsung/exynos_tmu.c > +++ b/drivers/thermal/samsung/exynos_tmu.c > @@ -943,7 +943,7 @@ static void exynos4210_tmu_clear_irqs(struct > exynos_tmu_data *data) > * Exynos3250, Exynos4412, Exynos5250 and Exynos5260 incorrectly > * states that INTCLEAR register has a different placing of bits > * responsible for FALL IRQs than INTSTAT register. Exynos5420 > -* and Exynos5440 documentation is correct (Exynos4210 doesn't > +* documentation is correct (Exynos4210 doesn't > * support FALL IRQs at all). > */ > writel(val_irq, data->base + tmu_intclear); > > After removing it, looks good to me. > Reviewed-by: Chanwoo Choi Thanks, I left this comment intentionally as it has some meaning even when Exynos5440 is not supported. Best regards, Krzysztof
Re: [RFC 06/10] thermal: samsung: Remove support for Exynos5440
Hi Krzysztof, On 2018년 04월 25일 05:32, Krzysztof Kozlowski wrote: > The Exynos5440 is not actively developed, there are no development > boards available and probably there are no real products with it. > Remove wide-tree support for Exynos5440. > > Signed-off-by: Krzysztof Kozlowski > --- > .../devicetree/bindings/thermal/exynos-thermal.txt | 14 +- > drivers/thermal/samsung/exynos_tmu.c | 155 > + > drivers/thermal/samsung/exynos_tmu.h | 1 - > 3 files changed, 4 insertions(+), 166 deletions(-) After applied this patch, I tested the build and found out 'exynos5440' keyword. There is one comment including 'exynos5440' as following: diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c index f92f470bce21..cb525228cfe1 100644 --- a/drivers/thermal/samsung/exynos_tmu.c +++ b/drivers/thermal/samsung/exynos_tmu.c @@ -943,7 +943,7 @@ static void exynos4210_tmu_clear_irqs(struct exynos_tmu_data *data) * Exynos3250, Exynos4412, Exynos5250 and Exynos5260 incorrectly * states that INTCLEAR register has a different placing of bits * responsible for FALL IRQs than INTSTAT register. Exynos5420 -* and Exynos5440 documentation is correct (Exynos4210 doesn't +* documentation is correct (Exynos4210 doesn't * support FALL IRQs at all). */ writel(val_irq, data->base + tmu_intclear); After removing it, looks good to me. Reviewed-by: Chanwoo Choi -- Best Regards, Chanwoo Choi Samsung Electronics
Re: [RFC 06/10] thermal: samsung: Remove support for Exynos5440
On Tuesday, April 24, 2018 10:32:35 PM Krzysztof Kozlowski wrote: > The Exynos5440 is not actively developed, there are no development > boards available and probably there are no real products with it. > Remove wide-tree support for Exynos5440. Thanks for doing this. > Signed-off-by: Krzysztof Kozlowski Acked-by: Bartlomiej Zolnierkiewicz Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics
