Re: [RFC PATCH 01/16] PM / hibernate: define HMAC algorithm and digest size of swsusp
On Fri, Jul 31, 2015 at 02:49:36PM +0200, Pavel Machek wrote:
> On Fri 2015-07-31 18:08:12, joeyli wrote:
> > On Tue, Jul 28, 2015 at 02:01:56PM +0200, Pavel Machek wrote:
> > > On Thu 2015-07-16 22:25:15, Lee, Chun-Yi wrote:
> > > > Using HMAC-SHA1 to be the HMAC algorithm of signing hibernate
> > > > snapshot image. The digest size of HMAC-SHA1 is 160 bits (20 bytes),
> > > > this size will be also applied to the length of HMAC key.
> > > >
> > > > In addition, add HIBERNATE_VERIFICATION kernel config.
> > > >
> > > > Signed-off-by: Lee, Chun-Yi
> > > > ---
> > > > include/linux/suspend.h | 5 +
> > > > kernel/power/Kconfig| 13 +
> > > > kernel/power/power.h| 1 +
> > > > 3 files changed, 19 insertions(+)
> > > >
> > > > diff --git a/include/linux/suspend.h b/include/linux/suspend.h
> > > > index 5efe743..6cd2a48 100644
> > > > --- a/include/linux/suspend.h
> > > > +++ b/include/linux/suspend.h
> > > > @@ -327,6 +327,11 @@ struct platform_hibernation_ops {
> > > > };
> > > >
> > > > #ifdef CONFIG_HIBERNATION
> > > > +
> > > > +/* HMAC Algorithm of Hibernate Signature */
> > > > +#define SWSUSP_HMAC"hmac(sha1)"
> > > > +#define SWSUSP_DIGEST_SIZE 20
> > >
> > > I'd replace SWSUSP with HIBERNATION here, and pretty much everywhere.
> > >
> >
> > SWSUSP is shorter than HIBERNATION, and there have some codes in hibernate
> > are also using swsusp. I still want to use it.
>
> Yes, its shorter, but its old name we are trying to move away
> from. Please do the same.
> Pavel
OK~ I will rename.
Thanks
Joey Lee
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [RFC PATCH 01/16] PM / hibernate: define HMAC algorithm and digest size of swsusp
On Fri 2015-07-31 18:08:12, joeyli wrote:
> On Tue, Jul 28, 2015 at 02:01:56PM +0200, Pavel Machek wrote:
> > On Thu 2015-07-16 22:25:15, Lee, Chun-Yi wrote:
> > > Using HMAC-SHA1 to be the HMAC algorithm of signing hibernate
> > > snapshot image. The digest size of HMAC-SHA1 is 160 bits (20 bytes),
> > > this size will be also applied to the length of HMAC key.
> > >
> > > In addition, add HIBERNATE_VERIFICATION kernel config.
> > >
> > > Signed-off-by: Lee, Chun-Yi
> > > ---
> > > include/linux/suspend.h | 5 +
> > > kernel/power/Kconfig| 13 +
> > > kernel/power/power.h| 1 +
> > > 3 files changed, 19 insertions(+)
> > >
> > > diff --git a/include/linux/suspend.h b/include/linux/suspend.h
> > > index 5efe743..6cd2a48 100644
> > > --- a/include/linux/suspend.h
> > > +++ b/include/linux/suspend.h
> > > @@ -327,6 +327,11 @@ struct platform_hibernation_ops {
> > > };
> > >
> > > #ifdef CONFIG_HIBERNATION
> > > +
> > > +/* HMAC Algorithm of Hibernate Signature */
> > > +#define SWSUSP_HMAC "hmac(sha1)"
> > > +#define SWSUSP_DIGEST_SIZE 20
> >
> > I'd replace SWSUSP with HIBERNATION here, and pretty much everywhere.
> >
>
> SWSUSP is shorter than HIBERNATION, and there have some codes in hibernate
> are also using swsusp. I still want to use it.
Yes, its shorter, but its old name we are trying to move away
from. Please do the same.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures)
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [RFC PATCH 01/16] PM / hibernate: define HMAC algorithm and digest size of swsusp
On Tue, Jul 28, 2015 at 02:01:56PM +0200, Pavel Machek wrote:
> On Thu 2015-07-16 22:25:15, Lee, Chun-Yi wrote:
> > Using HMAC-SHA1 to be the HMAC algorithm of signing hibernate
> > snapshot image. The digest size of HMAC-SHA1 is 160 bits (20 bytes),
> > this size will be also applied to the length of HMAC key.
> >
> > In addition, add HIBERNATE_VERIFICATION kernel config.
> >
> > Signed-off-by: Lee, Chun-Yi
> > ---
> > include/linux/suspend.h | 5 +
> > kernel/power/Kconfig| 13 +
> > kernel/power/power.h| 1 +
> > 3 files changed, 19 insertions(+)
> >
> > diff --git a/include/linux/suspend.h b/include/linux/suspend.h
> > index 5efe743..6cd2a48 100644
> > --- a/include/linux/suspend.h
> > +++ b/include/linux/suspend.h
> > @@ -327,6 +327,11 @@ struct platform_hibernation_ops {
> > };
> >
> > #ifdef CONFIG_HIBERNATION
> > +
> > +/* HMAC Algorithm of Hibernate Signature */
> > +#define SWSUSP_HMAC"hmac(sha1)"
> > +#define SWSUSP_DIGEST_SIZE 20
>
> I'd replace SWSUSP with HIBERNATION here, and pretty much everywhere.
>
SWSUSP is shorter than HIBERNATION, and there have some codes in hibernate
are also using swsusp. I still want to use it.
Thanks a lot!
Joey Lee
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [RFC PATCH 01/16] PM / hibernate: define HMAC algorithm and digest size of swsusp
On Thu 2015-07-16 22:25:15, Lee, Chun-Yi wrote:
> Using HMAC-SHA1 to be the HMAC algorithm of signing hibernate
> snapshot image. The digest size of HMAC-SHA1 is 160 bits (20 bytes),
> this size will be also applied to the length of HMAC key.
>
> In addition, add HIBERNATE_VERIFICATION kernel config.
>
> Signed-off-by: Lee, Chun-Yi
> ---
> include/linux/suspend.h | 5 +
> kernel/power/Kconfig| 13 +
> kernel/power/power.h| 1 +
> 3 files changed, 19 insertions(+)
>
> diff --git a/include/linux/suspend.h b/include/linux/suspend.h
> index 5efe743..6cd2a48 100644
> --- a/include/linux/suspend.h
> +++ b/include/linux/suspend.h
> @@ -327,6 +327,11 @@ struct platform_hibernation_ops {
> };
>
> #ifdef CONFIG_HIBERNATION
> +
> +/* HMAC Algorithm of Hibernate Signature */
> +#define SWSUSP_HMAC "hmac(sha1)"
> +#define SWSUSP_DIGEST_SIZE 20
I'd replace SWSUSP with HIBERNATION here, and pretty much everywhere.
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures)
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
