Re: [RFC PATCH V6 04/19] memory-hotplug: offline and remove memory when removing the memory device

2012-08-09 Thread Vasilis Liaskovitis 
Hi,

> We should offline and remove memory when removing the memory device.
> The memory device can be removed by 2 ways:
> 1. send eject request by SCI
> 2. echo 1 >/sys/bus/pci/devices/PNP0C80:XX/eject
>

[snip]

> +
> +static int acpi_memory_disable_device(struct acpi_memory_device *mem_device)
> +{
> +   int result;
> +
> +   /*
> +* Ask the VM to offline this memory range.
> +* Note: Assume that this function returns zero on success
> +*/
> +   result = acpi_memory_device_remove_memory(mem_device);
> +

here we should check the result of acpi_memory_device_remove_memory()
and not continue if it failed.

> /* Power-off and eject the device */
> result = acpi_memory_powerdown_device(mem_device);
> if (result) {

thanks,

- Vasilis
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [RFC PATCH V6 04/19] memory-hotplug: offline and remove memory when removing the memory device

2012-08-09 Thread Vasilis Liaskovitis 
Hi,

 We should offline and remove memory when removing the memory device.
 The memory device can be removed by 2 ways:
 1. send eject request by SCI
 2. echo 1 /sys/bus/pci/devices/PNP0C80:XX/eject


[snip]

 +
 +static int acpi_memory_disable_device(struct acpi_memory_device *mem_device)
 +{
 +   int result;
 +
 +   /*
 +* Ask the VM to offline this memory range.
 +* Note: Assume that this function returns zero on success
 +*/
 +   result = acpi_memory_device_remove_memory(mem_device);
 +

here we should check the result of acpi_memory_device_remove_memory()
and not continue if it failed.

 /* Power-off and eject the device */
 result = acpi_memory_powerdown_device(mem_device);
 if (result) {

thanks,

- Vasilis
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/