Re: [Revert "ppdev] 1701f68040: genirq: Flags mismatch irq 4. 00000000 (serial) vs. 00000080 (goldfish_pdev_bus)

[Fengguang Wu]

Hi Alan,

On Tue, May 31, 2016 at 11:11:55AM +0100, Alan wrote:
> On Sun, 29 May 2016 23:28:41 +0800
> kernel test robot  wrote:
> 
> > Greetings,
> > 
> > 0day kernel testing robot got the below dmesg and the first bad
> > commit is
> > 
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> 
> No.. it just happens to look different. It's an ancient ancient clash
> between Goldfish and standard PC over IRQ4. Unfortunately Goldfish
> doesn't provide a sane detection mechanism.

Got it, I'll blacklist this error, thank you for the info!

Thanks,
Fengguang

Re: [Revert "ppdev] 1701f68040: genirq: Flags mismatch irq 4. 00000000 (serial) vs. 00000080 (goldfish_pdev_bus)

[Fengguang Wu]

Hi Alan,

On Tue, May 31, 2016 at 11:11:55AM +0100, Alan wrote:
> On Sun, 29 May 2016 23:28:41 +0800
> kernel test robot  wrote:
> 
> > Greetings,
> > 
> > 0day kernel testing robot got the below dmesg and the first bad
> > commit is
> > 
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> 
> No.. it just happens to look different. It's an ancient ancient clash
> between Goldfish and standard PC over IRQ4. Unfortunately Goldfish
> doesn't provide a sane detection mechanism.

Got it, I'll blacklist this error, thank you for the info!

Thanks,
Fengguang

Re: [Revert "ppdev] 1701f68040: genirq: Flags mismatch irq 4. 00000000 (serial) vs. 00000080 (goldfish_pdev_bus)

[Alan]

On Sun, 29 May 2016 23:28:41 +0800
kernel test robot  wrote:

> Greetings,
> 
> 0day kernel testing robot got the below dmesg and the first bad
> commit is
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git

No.. it just happens to look different. It's an ancient ancient clash
between Goldfish and standard PC over IRQ4. Unfortunately Goldfish
doesn't provide a sane detection mechanism.

Alan

Re: [Revert "ppdev] 1701f68040: genirq: Flags mismatch irq 4. 00000000 (serial) vs. 00000080 (goldfish_pdev_bus)

[Alan]

On Sun, 29 May 2016 23:28:41 +0800
kernel test robot  wrote:

> Greetings,
> 
> 0day kernel testing robot got the below dmesg and the first bad
> commit is
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git

No.. it just happens to look different. It's an ancient ancient clash
between Goldfish and standard PC over IRQ4. Unfortunately Goldfish
doesn't provide a sane detection mechanism.

Alan

Re: [Revert "ppdev] 1701f68040: genirq: Flags mismatch irq 4. 00000000 (serial) vs. 00000080 (goldfish_pdev_bus)

[Fengguang Wu]

On Sun, May 29, 2016 at 09:25:28AM -0700, Linus Torvalds wrote:
> On Sun, May 29, 2016 at 8:28 AM, kernel test robot
>  wrote:
> >
> > 0day kernel testing robot got the below dmesg and the first bad commit is
> 
> This bisection seems unlikely.
> 
> I *think* what is going on is that the previous kernels ended up with
> boot failures:
> 
> > ++++-+
> > || 3b3b3bd977 | 
> > 1701f68040 | v4.6_052910 |
> > ++++-+
> > | kernel_BUG_at_drivers/base/driver.c| 92 | 
> >| |
> 
> and then when that went away (thanks to the commit you bisected to),
> the "genirq: Flags mismatch" warning showed up because it now got past
> that original bug.

That's right. It's a bug fix that discloses a less serious warning.

> I'm not sure what the fix to the 0day bisection should be. Maybe add
> some test that the last "good" kernel actually booted?

Yes, we do have tests on whether the parent boots fine or has more
serious boot errors, however they are wrongly bypassed when we
recently try to add a new test to report out errors which look
relevant to the code change.

I'll fix it up, sorry for the noise!

Boot tests are pretty noisy and often a commit and its parent commit
both have error/warnings. A better long term solution would be to
compare their time stamps to get the clue whether it's a bug fix that
makes the kernel live longer to produce another warning.

Thanks,
Fengguang

Re: [Revert "ppdev] 1701f68040: genirq: Flags mismatch irq 4. 00000000 (serial) vs. 00000080 (goldfish_pdev_bus)

[Fengguang Wu]

On Sun, May 29, 2016 at 09:25:28AM -0700, Linus Torvalds wrote:
> On Sun, May 29, 2016 at 8:28 AM, kernel test robot
>  wrote:
> >
> > 0day kernel testing robot got the below dmesg and the first bad commit is
> 
> This bisection seems unlikely.
> 
> I *think* what is going on is that the previous kernels ended up with
> boot failures:
> 
> > ++++-+
> > || 3b3b3bd977 | 
> > 1701f68040 | v4.6_052910 |
> > ++++-+
> > | kernel_BUG_at_drivers/base/driver.c| 92 | 
> >| |
> 
> and then when that went away (thanks to the commit you bisected to),
> the "genirq: Flags mismatch" warning showed up because it now got past
> that original bug.

That's right. It's a bug fix that discloses a less serious warning.

> I'm not sure what the fix to the 0day bisection should be. Maybe add
> some test that the last "good" kernel actually booted?

Yes, we do have tests on whether the parent boots fine or has more
serious boot errors, however they are wrongly bypassed when we
recently try to add a new test to report out errors which look
relevant to the code change.

I'll fix it up, sorry for the noise!

Boot tests are pretty noisy and often a commit and its parent commit
both have error/warnings. A better long term solution would be to
compare their time stamps to get the clue whether it's a bug fix that
makes the kernel live longer to produce another warning.

Thanks,
Fengguang

Re: [Revert "ppdev] 1701f68040: genirq: Flags mismatch irq 4. 00000000 (serial) vs. 00000080 (goldfish_pdev_bus)

[Linus Torvalds]

On Sun, May 29, 2016 at 8:28 AM, kernel test robot
 wrote:
>
> 0day kernel testing robot got the below dmesg and the first bad commit is

This bisection seems unlikely.

I *think* what is going on is that the previous kernels ended up with
boot failures:

> ++++-+
> || 3b3b3bd977 | 
> 1701f68040 | v4.6_052910 |
> ++++-+
> | kernel_BUG_at_drivers/base/driver.c| 92 |   
>  | |

and then when that went away (thanks to the commit you bisected to),
the "genirq: Flags mismatch" warning showed up because it now got past
that original bug.

I'm not sure what the fix to the 0day bisection should be. Maybe add
some test that the last "good" kernel actually booted?

   Linus

Re: [Revert "ppdev] 1701f68040: genirq: Flags mismatch irq 4. 00000000 (serial) vs. 00000080 (goldfish_pdev_bus)

[Linus Torvalds]

On Sun, May 29, 2016 at 8:28 AM, kernel test robot
 wrote:
>
> 0day kernel testing robot got the below dmesg and the first bad commit is

This bisection seems unlikely.

I *think* what is going on is that the previous kernels ended up with
boot failures:

> ++++-+
> || 3b3b3bd977 | 
> 1701f68040 | v4.6_052910 |
> ++++-+
> | kernel_BUG_at_drivers/base/driver.c| 92 |   
>  | |

and then when that went away (thanks to the commit you bisected to),
the "genirq: Flags mismatch" warning showed up because it now got past
that original bug.

I'm not sure what the fix to the 0day bisection should be. Maybe add
some test that the last "good" kernel actually booted?

   Linus