Re: [V4 PATCH 00/26] memory,numa: introduce MOVABLE-dedicated node and online_movable for hotplug

2012-09-10 Thread Lai Jiangshan
On 09/11/2012 09:37 AM, Yasuaki Ishimatsu wrote:
> Hi Lai,
> 
> 2012/09/11 10:22, Lai Jiangshan wrote:
>> On 09/11/2012 08:40 AM, Yasuaki Ishimatsu wrote:
>>> Hi Lai,
>>>
>>> Using memory_online to hot-added node's memory, the following kernel 
>>> messages
>>> were shown. Is this a known issue?
>>
>> Thank you for your report.
>>
>> What operations did you have performed ?
> 
> My operations are as follows:
> 
> 1. Hot-add a new node by container driver.
>In my system, container driver hot-addes a new nodes which includes CPUs 
> and
>memorys.
> 
> 2. echo online_movable to hot-added nodes's memory
>When container driver hot-adds a new nodes, my system creates node2 sysfs.
>And the sysfs has memory768-memory1023 sysfs. So I echo "online_movable"
>to memory1023/state file.
># echo online_movable > memory1023/state
> 


I can't reproduce the bug. and my system is a little different from you.
could you show me the /proc/zoneinfo?

also, could you add following patch, it will help me know which constraint I 
have broken.

Thanks,
Lai

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 3878170..68302ef 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -549,6 +549,9 @@ static inline void __free_one_page(struct page *page,
 
page_idx = page_to_pfn(page) & ((1 << MAX_ORDER) - 1);
 
+   VM_BUG_ON(page_outside_zone_boundaries(zone, page));
+   VM_BUG_ON(!pfn_valid_within(page_to_pfn(page)));
+   VM_BUG_ON(zone != page_zone(page));
VM_BUG_ON(page_idx & ((1 << order) - 1));
VM_BUG_ON(bad_range(zone, page));
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [V4 PATCH 00/26] memory,numa: introduce MOVABLE-dedicated node and online_movable for hotplug

2012-09-10 Thread Yasuaki Ishimatsu

Hi Lai,

2012/09/11 10:22, Lai Jiangshan wrote:

On 09/11/2012 08:40 AM, Yasuaki Ishimatsu wrote:

Hi Lai,

Using memory_online to hot-added node's memory, the following kernel messages
were shown. Is this a known issue?


Thank you for your report.

What operations did you have performed ?


My operations are as follows:

1. Hot-add a new node by container driver.
   In my system, container driver hot-addes a new nodes which includes CPUs and
   memorys.

2. echo online_movable to hot-added nodes's memory
   When container driver hot-adds a new nodes, my system creates node2 sysfs.
   And the sysfs has memory768-memory1023 sysfs. So I echo "online_movable"
   to memory1023/state file.
   # echo online_movable > memory1023/state

Thanks,
Yasuaki Ishimatsu



Thanks.
Lai



[  327.837408] [ cut here ]
[  327.892556] kernel BUG at mm/page_alloc.c:553!
[  327.945621] invalid opcode:  [#1] SMP
[  327.994748] Modules linked in: sunrpc ipt_REJECT nf_conntrack_ipv4 
nf_defrag_ipv4 iptable_filter ip_tables ip6t_REJECT nf_conntrack_ipv6 
nf_defrag_ipv6 xt_state nf_conntrack ip6table_filter ip6_tables binfmt_misc 
vfat fat dm_mirror dm_region_hash dm_log dm_mod uinput iTCO_wdt 
iTCO_vendor_support coretemp kvm_intel kvm crc32c_intel microcode pcspkr 
i2c_i801 i2c_core lpc_ich mfd_core ioatdma i7core_edac edac_core sg e1000e igb 
dca sd_mod crc_t10dif lpfc scsi_transport_fc scsi_tgt mptsas mptscsih mptbase 
scsi_transport_sas scsi_mod
[  328.560103] CPU 0
[  328.582021] Pid: 2445, comm: bash Not tainted 3.6.0-rc5-removable-node+ #1 
FUJITSU-SV PRIMEQUEST 1800E/SB
[  328.698524] RIP: 0010:[]  [] 
free_pcppages_bulk+0x4ec/0x540
[  328.802580] RSP: 0018:8807875f9b88  EFLAGS: 00010002
[  328.866025] RAX: 0001 RBX: 0001 RCX: 0001
[  328.951273] RDX: 0002 RSI: ea007fe0 RDI: 880764801680
[  329.036522] RBP: 8807875f9c38 R08: 01ff8000 R09: 880764801740
[  329.121771] R10: 0180 R11: 0001 R12: 0002
[  329.207022] R13: ea007fe0 R14: 880764801680 R15: ea007fe00020
[  329.292270] FS:  7ff533e92700() GS:8807c180() 
knlGS:
[  329.388942] CS:  0010 DS:  ES:  CR0: 80050033
[  329.457575] CR2: ff600400 CR3: 0007b6826000 CR4: 07f0
[  329.542826] DR0:  DR1:  DR2: 
[  329.628075] DR3:  DR6: 0ff0 DR7: 0400
[  329.713326] Process bash (pid: 2445, threadinfo 8807875f8000, task 
8807b72ccca0)
[  329.809993] Stack:
[  329.833984]  881ff800   

[  329.922788]  81c3f160 8807875f9fd8 8807648016e8 
00010002
[  330.011593]  8807875f8000 8807875f8000 0030 
8807c19d0e18
[  330.100400] Call Trace:
[  330.129588]  [] free_hot_cold_page+0x187/0x1d0
[  330.201345]  [] __free_pages+0x35/0x50
[  330.264798]  [] __online_page_free+0x1c/0x20
[  330.334478]  [] generic_online_page+0x26/0x30
[  330.405197]  [] online_pages_range+0x61/0x90
[  330.474880]  [] walk_system_ram_range+0x140/0x150
[  330.549750]  [] ? 
__online_page_increment_counters+0x20/0x20
[  330.636050]  [] online_pages+0x22b/0x390
[  330.701584]  [] memory_block_action+0xbc/0x1a0
[  330.773347]  [] ? mutex_lock_nested+0x4a/0x60
[  330.844063]  [] memory_block_change_state+0x83/0xf0
[  330.921013]  [] ? might_fault+0x5c/0xb0
[  330.985502]  [] store_mem_state+0x137/0x180
[  331.054150]  [] ? sysfs_write_file+0x87/0x100
[  331.124867]  [] dev_attr_store+0x20/0x30
[  331.190392]  [] sysfs_write_file+0xa3/0x100
[  331.259038]  [] vfs_write+0xd0/0x1a0
[  331.320411]  [] sys_write+0x54/0xa0
[  331.380747]  [] system_call_fastpath+0x16/0x1b
[  331.452501] Code: ff ff 0f 0b eb fe 0f 0b 0f 1f 80 00 00 00 00 eb f7 0f 0b eb fe 
48 c7 c7 80 3b c3 81 e8 ae 6c f6 ff 85 c0 0f 85 cb fd ff ff eb 8f <0f> 0b 66 90 
eb fc 0f 0b eb fe 49 8b 47 e0 f6 c4 40 0f 1f 00 74
[  331.685087] RIP  [] free_pcppages_bulk+0x4ec/0x540
[  331.761102]  RSP 
[  331.802749] ---[ end trace f3112128f3ab7e75 ]---
[  331.859455] BUG: sleeping function called from invalid context at 
mm/slub.c:930
[  331.946779] in_atomic(): 1, irqs_disabled(): 1, pid: 2445, name: bash
[  332.023723] INFO: lockdep is turned off.
[  332.070554] irq event stamp: 301462
[  332.112196] hardirqs last  enabled at (301461): [] 
_raw_spin_unlock_irq+0x30/0x50
[  332.220397] hardirqs last disabled at (301462): [] 
_raw_spin_lock_irq+0x1f/0x90
[  332.326522] softirqs last  enabled at (301450): [] 
__do_softirq+0x18c/0x3e0
[  332.428493] softirqs last disabled at (301445): [] 
call_softirq+0x1c/0x30
[  332.528391] Pid: 2445, comm: bash Tainted: G  D  
3.6.0-rc5-removable-node+ #1
[  332.621944] Call Trace:
[  332.651131]  [] __might_sleep+0x18a/0x240
[  332.717699]  [] __kmalloc+0x6b/0x220
[  332.779079]  [] ? 

Re: [V4 PATCH 00/26] memory,numa: introduce MOVABLE-dedicated node and online_movable for hotplug

2012-09-10 Thread Lai Jiangshan
On 09/11/2012 08:40 AM, Yasuaki Ishimatsu wrote:
> Hi Lai,
> 
> Using memory_online to hot-added node's memory, the following kernel messages
> were shown. Is this a known issue?

Thank you for your report.

What operations did you have performed ?

Thanks.
Lai

> 
> [  327.837408] [ cut here ]
> [  327.892556] kernel BUG at mm/page_alloc.c:553!
> [  327.945621] invalid opcode:  [#1] SMP 
> [  327.994748] Modules linked in: sunrpc ipt_REJECT nf_conntrack_ipv4 
> nf_defrag_ipv4 iptable_filter ip_tables ip6t_REJECT nf_conntrack_ipv6 
> nf_defrag_ipv6 xt_state nf_conntrack ip6table_filter ip6_tables binfmt_misc 
> vfat fat dm_mirror dm_region_hash dm_log dm_mod uinput iTCO_wdt 
> iTCO_vendor_support coretemp kvm_intel kvm crc32c_intel microcode pcspkr 
> i2c_i801 i2c_core lpc_ich mfd_core ioatdma i7core_edac edac_core sg e1000e 
> igb dca sd_mod crc_t10dif lpfc scsi_transport_fc scsi_tgt mptsas mptscsih 
> mptbase scsi_transport_sas scsi_mod
> [  328.560103] CPU 0 
> [  328.582021] Pid: 2445, comm: bash Not tainted 3.6.0-rc5-removable-node+ #1 
> FUJITSU-SV PRIMEQUEST 1800E/SB
> [  328.698524] RIP: 0010:[]  [] 
> free_pcppages_bulk+0x4ec/0x540
> [  328.802580] RSP: 0018:8807875f9b88  EFLAGS: 00010002
> [  328.866025] RAX: 0001 RBX: 0001 RCX: 
> 0001
> [  328.951273] RDX: 0002 RSI: ea007fe0 RDI: 
> 880764801680
> [  329.036522] RBP: 8807875f9c38 R08: 01ff8000 R09: 
> 880764801740
> [  329.121771] R10: 0180 R11: 0001 R12: 
> 0002
> [  329.207022] R13: ea007fe0 R14: 880764801680 R15: 
> ea007fe00020
> [  329.292270] FS:  7ff533e92700() GS:8807c180() 
> knlGS:
> [  329.388942] CS:  0010 DS:  ES:  CR0: 80050033
> [  329.457575] CR2: ff600400 CR3: 0007b6826000 CR4: 
> 07f0
> [  329.542826] DR0:  DR1:  DR2: 
> 
> [  329.628075] DR3:  DR6: 0ff0 DR7: 
> 0400
> [  329.713326] Process bash (pid: 2445, threadinfo 8807875f8000, task 
> 8807b72ccca0)
> [  329.809993] Stack:
> [  329.833984]  881ff800   
> 
> [  329.922788]  81c3f160 8807875f9fd8 8807648016e8 
> 00010002
> [  330.011593]  8807875f8000 8807875f8000 0030 
> 8807c19d0e18
> [  330.100400] Call Trace:
> [  330.129588]  [] free_hot_cold_page+0x187/0x1d0
> [  330.201345]  [] __free_pages+0x35/0x50
> [  330.264798]  [] __online_page_free+0x1c/0x20
> [  330.334478]  [] generic_online_page+0x26/0x30
> [  330.405197]  [] online_pages_range+0x61/0x90
> [  330.474880]  [] walk_system_ram_range+0x140/0x150
> [  330.549750]  [] ? 
> __online_page_increment_counters+0x20/0x20
> [  330.636050]  [] online_pages+0x22b/0x390
> [  330.701584]  [] memory_block_action+0xbc/0x1a0
> [  330.773347]  [] ? mutex_lock_nested+0x4a/0x60
> [  330.844063]  [] memory_block_change_state+0x83/0xf0
> [  330.921013]  [] ? might_fault+0x5c/0xb0
> [  330.985502]  [] store_mem_state+0x137/0x180
> [  331.054150]  [] ? sysfs_write_file+0x87/0x100
> [  331.124867]  [] dev_attr_store+0x20/0x30
> [  331.190392]  [] sysfs_write_file+0xa3/0x100
> [  331.259038]  [] vfs_write+0xd0/0x1a0
> [  331.320411]  [] sys_write+0x54/0xa0
> [  331.380747]  [] system_call_fastpath+0x16/0x1b
> [  331.452501] Code: ff ff 0f 0b eb fe 0f 0b 0f 1f 80 00 00 00 00 eb f7 0f 0b 
> eb fe 48 c7 c7 80 3b c3 81 e8 ae 6c f6 ff 85 c0 0f 85 cb fd ff ff eb 8f <0f> 
> 0b 66 90 eb fc 0f 0b eb fe 49 8b 47 e0 f6 c4 40 0f 1f 00 74 
> [  331.685087] RIP  [] free_pcppages_bulk+0x4ec/0x540
> [  331.761102]  RSP 
> [  331.802749] ---[ end trace f3112128f3ab7e75 ]---
> [  331.859455] BUG: sleeping function called from invalid context at 
> mm/slub.c:930
> [  331.946779] in_atomic(): 1, irqs_disabled(): 1, pid: 2445, name: bash
> [  332.023723] INFO: lockdep is turned off.
> [  332.070554] irq event stamp: 301462
> [  332.112196] hardirqs last  enabled at (301461): [] 
> _raw_spin_unlock_irq+0x30/0x50
> [  332.220397] hardirqs last disabled at (301462): [] 
> _raw_spin_lock_irq+0x1f/0x90
> [  332.326522] softirqs last  enabled at (301450): [] 
> __do_softirq+0x18c/0x3e0
> [  332.428493] softirqs last disabled at (301445): [] 
> call_softirq+0x1c/0x30
> [  332.528391] Pid: 2445, comm: bash Tainted: G  D  
> 3.6.0-rc5-removable-node+ #1
> [  332.621944] Call Trace:
> [  332.651131]  [] __might_sleep+0x18a/0x240
> [  332.717699]  [] __kmalloc+0x6b/0x220
> [  332.779079]  [] ? efivar_create_sysfs_entry+0x41/0x1b0
> [  332.859144]  [] efivar_create_sysfs_entry+0x41/0x1b0
> [  332.937130]  [] efi_pstore_write+0x37b/0x3a0
> [  333.006812]  [] ? _raw_spin_unlock_irqrestore+0x77/0x80
> [  333.087916]  [] ? kmsg_dump_get_buffer+0x1e2/0x2c0
> [  333.163827]  [] ? pstore_dump+0x1b0/0x220
> [  333.230391]  [] 

Re: [V4 PATCH 00/26] memory,numa: introduce MOVABLE-dedicated node and online_movable for hotplug

2012-09-10 Thread Yasuaki Ishimatsu
Hi Lai,

Using memory_online to hot-added node's memory, the following kernel messages
were shown. Is this a known issue?

[  327.837408] [ cut here ]
[  327.892556] kernel BUG at mm/page_alloc.c:553!
[  327.945621] invalid opcode:  [#1] SMP 
[  327.994748] Modules linked in: sunrpc ipt_REJECT nf_conntrack_ipv4 
nf_defrag_ipv4 iptable_filter ip_tables ip6t_REJECT nf_conntrack_ipv6 
nf_defrag_ipv6 xt_state nf_conntrack ip6table_filter ip6_tables binfmt_misc 
vfat fat dm_mirror dm_region_hash dm_log dm_mod uinput iTCO_wdt 
iTCO_vendor_support coretemp kvm_intel kvm crc32c_intel microcode pcspkr 
i2c_i801 i2c_core lpc_ich mfd_core ioatdma i7core_edac edac_core sg e1000e igb 
dca sd_mod crc_t10dif lpfc scsi_transport_fc scsi_tgt mptsas mptscsih mptbase 
scsi_transport_sas scsi_mod
[  328.560103] CPU 0 
[  328.582021] Pid: 2445, comm: bash Not tainted 3.6.0-rc5-removable-node+ #1 
FUJITSU-SV PRIMEQUEST 1800E/SB
[  328.698524] RIP: 0010:[]  [] 
free_pcppages_bulk+0x4ec/0x540
[  328.802580] RSP: 0018:8807875f9b88  EFLAGS: 00010002
[  328.866025] RAX: 0001 RBX: 0001 RCX: 0001
[  328.951273] RDX: 0002 RSI: ea007fe0 RDI: 880764801680
[  329.036522] RBP: 8807875f9c38 R08: 01ff8000 R09: 880764801740
[  329.121771] R10: 0180 R11: 0001 R12: 0002
[  329.207022] R13: ea007fe0 R14: 880764801680 R15: ea007fe00020
[  329.292270] FS:  7ff533e92700() GS:8807c180() 
knlGS:
[  329.388942] CS:  0010 DS:  ES:  CR0: 80050033
[  329.457575] CR2: ff600400 CR3: 0007b6826000 CR4: 07f0
[  329.542826] DR0:  DR1:  DR2: 
[  329.628075] DR3:  DR6: 0ff0 DR7: 0400
[  329.713326] Process bash (pid: 2445, threadinfo 8807875f8000, task 
8807b72ccca0)
[  329.809993] Stack:
[  329.833984]  881ff800   

[  329.922788]  81c3f160 8807875f9fd8 8807648016e8 
00010002
[  330.011593]  8807875f8000 8807875f8000 0030 
8807c19d0e18
[  330.100400] Call Trace:
[  330.129588]  [] free_hot_cold_page+0x187/0x1d0
[  330.201345]  [] __free_pages+0x35/0x50
[  330.264798]  [] __online_page_free+0x1c/0x20
[  330.334478]  [] generic_online_page+0x26/0x30
[  330.405197]  [] online_pages_range+0x61/0x90
[  330.474880]  [] walk_system_ram_range+0x140/0x150
[  330.549750]  [] ? 
__online_page_increment_counters+0x20/0x20
[  330.636050]  [] online_pages+0x22b/0x390
[  330.701584]  [] memory_block_action+0xbc/0x1a0
[  330.773347]  [] ? mutex_lock_nested+0x4a/0x60
[  330.844063]  [] memory_block_change_state+0x83/0xf0
[  330.921013]  [] ? might_fault+0x5c/0xb0
[  330.985502]  [] store_mem_state+0x137/0x180
[  331.054150]  [] ? sysfs_write_file+0x87/0x100
[  331.124867]  [] dev_attr_store+0x20/0x30
[  331.190392]  [] sysfs_write_file+0xa3/0x100
[  331.259038]  [] vfs_write+0xd0/0x1a0
[  331.320411]  [] sys_write+0x54/0xa0
[  331.380747]  [] system_call_fastpath+0x16/0x1b
[  331.452501] Code: ff ff 0f 0b eb fe 0f 0b 0f 1f 80 00 00 00 00 eb f7 0f 0b 
eb fe 48 c7 c7 80 3b c3 81 e8 ae 6c f6 ff 85 c0 0f 85 cb fd ff ff eb 8f <0f> 0b 
66 90 eb fc 0f 0b eb fe 49 8b 47 e0 f6 c4 40 0f 1f 00 74 
[  331.685087] RIP  [] free_pcppages_bulk+0x4ec/0x540
[  331.761102]  RSP 
[  331.802749] ---[ end trace f3112128f3ab7e75 ]---
[  331.859455] BUG: sleeping function called from invalid context at 
mm/slub.c:930
[  331.946779] in_atomic(): 1, irqs_disabled(): 1, pid: 2445, name: bash
[  332.023723] INFO: lockdep is turned off.
[  332.070554] irq event stamp: 301462
[  332.112196] hardirqs last  enabled at (301461): [] 
_raw_spin_unlock_irq+0x30/0x50
[  332.220397] hardirqs last disabled at (301462): [] 
_raw_spin_lock_irq+0x1f/0x90
[  332.326522] softirqs last  enabled at (301450): [] 
__do_softirq+0x18c/0x3e0
[  332.428493] softirqs last disabled at (301445): [] 
call_softirq+0x1c/0x30
[  332.528391] Pid: 2445, comm: bash Tainted: G  D  
3.6.0-rc5-removable-node+ #1
[  332.621944] Call Trace:
[  332.651131]  [] __might_sleep+0x18a/0x240
[  332.717699]  [] __kmalloc+0x6b/0x220
[  332.779079]  [] ? efivar_create_sysfs_entry+0x41/0x1b0
[  332.859144]  [] efivar_create_sysfs_entry+0x41/0x1b0
[  332.937130]  [] efi_pstore_write+0x37b/0x3a0
[  333.006812]  [] ? _raw_spin_unlock_irqrestore+0x77/0x80
[  333.087916]  [] ? kmsg_dump_get_buffer+0x1e2/0x2c0
[  333.163827]  [] ? pstore_dump+0x1b0/0x220
[  333.230391]  [] pstore_dump+0x12f/0x220
[  333.294883]  [] kmsg_dump+0x11b/0x2a0
[  333.357294]  [] ? kmsg_dump+0x26/0x2a0
[  333.420746]  [] oops_exit+0x1d/0x20
[  333.481085]  [] oops_end+0x7e/0xf0
[  333.540386]  [] die+0x5b/0x90
[  333.594489]  [] do_trap+0xc4/0x170
[  333.653789]  [] do_invalid_op+0x95/0xb0
[  333.718278]  [] ? free_pcppages_bulk+0x4ec/0x540
[  

Re: [V4 PATCH 00/26] memory,numa: introduce MOVABLE-dedicated node and online_movable for hotplug

2012-09-10 Thread Yasuaki Ishimatsu
Hi Lai,

Using memory_online to hot-added node's memory, the following kernel messages
were shown. Is this a known issue?

[  327.837408] [ cut here ]
[  327.892556] kernel BUG at mm/page_alloc.c:553!
[  327.945621] invalid opcode:  [#1] SMP 
[  327.994748] Modules linked in: sunrpc ipt_REJECT nf_conntrack_ipv4 
nf_defrag_ipv4 iptable_filter ip_tables ip6t_REJECT nf_conntrack_ipv6 
nf_defrag_ipv6 xt_state nf_conntrack ip6table_filter ip6_tables binfmt_misc 
vfat fat dm_mirror dm_region_hash dm_log dm_mod uinput iTCO_wdt 
iTCO_vendor_support coretemp kvm_intel kvm crc32c_intel microcode pcspkr 
i2c_i801 i2c_core lpc_ich mfd_core ioatdma i7core_edac edac_core sg e1000e igb 
dca sd_mod crc_t10dif lpfc scsi_transport_fc scsi_tgt mptsas mptscsih mptbase 
scsi_transport_sas scsi_mod
[  328.560103] CPU 0 
[  328.582021] Pid: 2445, comm: bash Not tainted 3.6.0-rc5-removable-node+ #1 
FUJITSU-SV PRIMEQUEST 1800E/SB
[  328.698524] RIP: 0010:[8116ffdc]  [8116ffdc] 
free_pcppages_bulk+0x4ec/0x540
[  328.802580] RSP: 0018:8807875f9b88  EFLAGS: 00010002
[  328.866025] RAX: 0001 RBX: 0001 RCX: 0001
[  328.951273] RDX: 0002 RSI: ea007fe0 RDI: 880764801680
[  329.036522] RBP: 8807875f9c38 R08: 01ff8000 R09: 880764801740
[  329.121771] R10: 0180 R11: 0001 R12: 0002
[  329.207022] R13: ea007fe0 R14: 880764801680 R15: ea007fe00020
[  329.292270] FS:  7ff533e92700() GS:8807c180() 
knlGS:
[  329.388942] CS:  0010 DS:  ES:  CR0: 80050033
[  329.457575] CR2: ff600400 CR3: 0007b6826000 CR4: 07f0
[  329.542826] DR0:  DR1:  DR2: 
[  329.628075] DR3:  DR6: 0ff0 DR7: 0400
[  329.713326] Process bash (pid: 2445, threadinfo 8807875f8000, task 
8807b72ccca0)
[  329.809993] Stack:
[  329.833984]  881ff800   

[  329.922788]  81c3f160 8807875f9fd8 8807648016e8 
00010002
[  330.011593]  8807875f8000 8807875f8000 0030 
8807c19d0e18
[  330.100400] Call Trace:
[  330.129588]  [811703c7] free_hot_cold_page+0x187/0x1d0
[  330.201345]  [81170445] __free_pages+0x35/0x50
[  330.264798]  [811c05ec] __online_page_free+0x1c/0x20
[  330.334478]  [811c0616] generic_online_page+0x26/0x30
[  330.405197]  [811c0271] online_pages_range+0x61/0x90
[  330.474880]  [81078240] walk_system_ram_range+0x140/0x150
[  330.549750]  [811c0210] ? 
__online_page_increment_counters+0x20/0x20
[  330.636050]  [8165464b] online_pages+0x22b/0x390
[  330.701584]  [8144d2ec] memory_block_action+0xbc/0x1a0
[  330.773347]  [8166cbfa] ? mutex_lock_nested+0x4a/0x60
[  330.844063]  [8144d453] memory_block_change_state+0x83/0xf0
[  330.921013]  [8118ff9c] ? might_fault+0x5c/0xb0
[  330.985502]  [8144d5f7] store_mem_state+0x137/0x180
[  331.054150]  [8124a517] ? sysfs_write_file+0x87/0x100
[  331.124867]  [814375f0] dev_attr_store+0x20/0x30
[  331.190392]  [8124a533] sysfs_write_file+0xa3/0x100
[  331.259038]  [811cc6d0] vfs_write+0xd0/0x1a0
[  331.320411]  [811cc8a4] sys_write+0x54/0xa0
[  331.380747]  [81679bd9] system_call_fastpath+0x16/0x1b
[  331.452501] Code: ff ff 0f 0b eb fe 0f 0b 0f 1f 80 00 00 00 00 eb f7 0f 0b 
eb fe 48 c7 c7 80 3b c3 81 e8 ae 6c f6 ff 85 c0 0f 85 cb fd ff ff eb 8f 0f 0b 
66 90 eb fc 0f 0b eb fe 49 8b 47 e0 f6 c4 40 0f 1f 00 74 
[  331.685087] RIP  [8116ffdc] free_pcppages_bulk+0x4ec/0x540
[  331.761102]  RSP 8807875f9b88
[  331.802749] ---[ end trace f3112128f3ab7e75 ]---
[  331.859455] BUG: sleeping function called from invalid context at 
mm/slub.c:930
[  331.946779] in_atomic(): 1, irqs_disabled(): 1, pid: 2445, name: bash
[  332.023723] INFO: lockdep is turned off.
[  332.070554] irq event stamp: 301462
[  332.112196] hardirqs last  enabled at (301461): [816700f0] 
_raw_spin_unlock_irq+0x30/0x50
[  332.220397] hardirqs last disabled at (301462): [8166f5cf] 
_raw_spin_lock_irq+0x1f/0x90
[  332.326522] softirqs last  enabled at (301450): [81076a9c] 
__do_softirq+0x18c/0x3e0
[  332.428493] softirqs last disabled at (301445): [8167af3c] 
call_softirq+0x1c/0x30
[  332.528391] Pid: 2445, comm: bash Tainted: G  D  
3.6.0-rc5-removable-node+ #1
[  332.621944] Call Trace:
[  332.651131]  [810a943a] __might_sleep+0x18a/0x240
[  332.717699]  [811bddbb] __kmalloc+0x6b/0x220
[  332.779079]  [814f5ab1] ? efivar_create_sysfs_entry+0x41/0x1b0
[  332.859144]  [814f5ab1] efivar_create_sysfs_entry+0x41/0x1b0
[  332.937130]  [814f5f9b] efi_pstore_write+0x37b/0x3a0
[  333.006812]  

Re: [V4 PATCH 00/26] memory,numa: introduce MOVABLE-dedicated node and online_movable for hotplug

2012-09-10 Thread Lai Jiangshan
On 09/11/2012 08:40 AM, Yasuaki Ishimatsu wrote:
 Hi Lai,
 
 Using memory_online to hot-added node's memory, the following kernel messages
 were shown. Is this a known issue?

Thank you for your report.

What operations did you have performed ?

Thanks.
Lai

 
 [  327.837408] [ cut here ]
 [  327.892556] kernel BUG at mm/page_alloc.c:553!
 [  327.945621] invalid opcode:  [#1] SMP 
 [  327.994748] Modules linked in: sunrpc ipt_REJECT nf_conntrack_ipv4 
 nf_defrag_ipv4 iptable_filter ip_tables ip6t_REJECT nf_conntrack_ipv6 
 nf_defrag_ipv6 xt_state nf_conntrack ip6table_filter ip6_tables binfmt_misc 
 vfat fat dm_mirror dm_region_hash dm_log dm_mod uinput iTCO_wdt 
 iTCO_vendor_support coretemp kvm_intel kvm crc32c_intel microcode pcspkr 
 i2c_i801 i2c_core lpc_ich mfd_core ioatdma i7core_edac edac_core sg e1000e 
 igb dca sd_mod crc_t10dif lpfc scsi_transport_fc scsi_tgt mptsas mptscsih 
 mptbase scsi_transport_sas scsi_mod
 [  328.560103] CPU 0 
 [  328.582021] Pid: 2445, comm: bash Not tainted 3.6.0-rc5-removable-node+ #1 
 FUJITSU-SV PRIMEQUEST 1800E/SB
 [  328.698524] RIP: 0010:[8116ffdc]  [8116ffdc] 
 free_pcppages_bulk+0x4ec/0x540
 [  328.802580] RSP: 0018:8807875f9b88  EFLAGS: 00010002
 [  328.866025] RAX: 0001 RBX: 0001 RCX: 
 0001
 [  328.951273] RDX: 0002 RSI: ea007fe0 RDI: 
 880764801680
 [  329.036522] RBP: 8807875f9c38 R08: 01ff8000 R09: 
 880764801740
 [  329.121771] R10: 0180 R11: 0001 R12: 
 0002
 [  329.207022] R13: ea007fe0 R14: 880764801680 R15: 
 ea007fe00020
 [  329.292270] FS:  7ff533e92700() GS:8807c180() 
 knlGS:
 [  329.388942] CS:  0010 DS:  ES:  CR0: 80050033
 [  329.457575] CR2: ff600400 CR3: 0007b6826000 CR4: 
 07f0
 [  329.542826] DR0:  DR1:  DR2: 
 
 [  329.628075] DR3:  DR6: 0ff0 DR7: 
 0400
 [  329.713326] Process bash (pid: 2445, threadinfo 8807875f8000, task 
 8807b72ccca0)
 [  329.809993] Stack:
 [  329.833984]  881ff800   
 
 [  329.922788]  81c3f160 8807875f9fd8 8807648016e8 
 00010002
 [  330.011593]  8807875f8000 8807875f8000 0030 
 8807c19d0e18
 [  330.100400] Call Trace:
 [  330.129588]  [811703c7] free_hot_cold_page+0x187/0x1d0
 [  330.201345]  [81170445] __free_pages+0x35/0x50
 [  330.264798]  [811c05ec] __online_page_free+0x1c/0x20
 [  330.334478]  [811c0616] generic_online_page+0x26/0x30
 [  330.405197]  [811c0271] online_pages_range+0x61/0x90
 [  330.474880]  [81078240] walk_system_ram_range+0x140/0x150
 [  330.549750]  [811c0210] ? 
 __online_page_increment_counters+0x20/0x20
 [  330.636050]  [8165464b] online_pages+0x22b/0x390
 [  330.701584]  [8144d2ec] memory_block_action+0xbc/0x1a0
 [  330.773347]  [8166cbfa] ? mutex_lock_nested+0x4a/0x60
 [  330.844063]  [8144d453] memory_block_change_state+0x83/0xf0
 [  330.921013]  [8118ff9c] ? might_fault+0x5c/0xb0
 [  330.985502]  [8144d5f7] store_mem_state+0x137/0x180
 [  331.054150]  [8124a517] ? sysfs_write_file+0x87/0x100
 [  331.124867]  [814375f0] dev_attr_store+0x20/0x30
 [  331.190392]  [8124a533] sysfs_write_file+0xa3/0x100
 [  331.259038]  [811cc6d0] vfs_write+0xd0/0x1a0
 [  331.320411]  [811cc8a4] sys_write+0x54/0xa0
 [  331.380747]  [81679bd9] system_call_fastpath+0x16/0x1b
 [  331.452501] Code: ff ff 0f 0b eb fe 0f 0b 0f 1f 80 00 00 00 00 eb f7 0f 0b 
 eb fe 48 c7 c7 80 3b c3 81 e8 ae 6c f6 ff 85 c0 0f 85 cb fd ff ff eb 8f 0f 
 0b 66 90 eb fc 0f 0b eb fe 49 8b 47 e0 f6 c4 40 0f 1f 00 74 
 [  331.685087] RIP  [8116ffdc] free_pcppages_bulk+0x4ec/0x540
 [  331.761102]  RSP 8807875f9b88
 [  331.802749] ---[ end trace f3112128f3ab7e75 ]---
 [  331.859455] BUG: sleeping function called from invalid context at 
 mm/slub.c:930
 [  331.946779] in_atomic(): 1, irqs_disabled(): 1, pid: 2445, name: bash
 [  332.023723] INFO: lockdep is turned off.
 [  332.070554] irq event stamp: 301462
 [  332.112196] hardirqs last  enabled at (301461): [816700f0] 
 _raw_spin_unlock_irq+0x30/0x50
 [  332.220397] hardirqs last disabled at (301462): [8166f5cf] 
 _raw_spin_lock_irq+0x1f/0x90
 [  332.326522] softirqs last  enabled at (301450): [81076a9c] 
 __do_softirq+0x18c/0x3e0
 [  332.428493] softirqs last disabled at (301445): [8167af3c] 
 call_softirq+0x1c/0x30
 [  332.528391] Pid: 2445, comm: bash Tainted: G  D  
 3.6.0-rc5-removable-node+ #1
 [  332.621944] Call Trace:
 [  332.651131]  [810a943a] __might_sleep+0x18a/0x240
 [  332.717699]  [811bddbb] 

Re: [V4 PATCH 00/26] memory,numa: introduce MOVABLE-dedicated node and online_movable for hotplug

2012-09-10 Thread Yasuaki Ishimatsu

Hi Lai,

2012/09/11 10:22, Lai Jiangshan wrote:

On 09/11/2012 08:40 AM, Yasuaki Ishimatsu wrote:

Hi Lai,

Using memory_online to hot-added node's memory, the following kernel messages
were shown. Is this a known issue?


Thank you for your report.

What operations did you have performed ?


My operations are as follows:

1. Hot-add a new node by container driver.
   In my system, container driver hot-addes a new nodes which includes CPUs and
   memorys.

2. echo online_movable to hot-added nodes's memory
   When container driver hot-adds a new nodes, my system creates node2 sysfs.
   And the sysfs has memory768-memory1023 sysfs. So I echo online_movable
   to memory1023/state file.
   # echo online_movable  memory1023/state

Thanks,
Yasuaki Ishimatsu



Thanks.
Lai



[  327.837408] [ cut here ]
[  327.892556] kernel BUG at mm/page_alloc.c:553!
[  327.945621] invalid opcode:  [#1] SMP
[  327.994748] Modules linked in: sunrpc ipt_REJECT nf_conntrack_ipv4 
nf_defrag_ipv4 iptable_filter ip_tables ip6t_REJECT nf_conntrack_ipv6 
nf_defrag_ipv6 xt_state nf_conntrack ip6table_filter ip6_tables binfmt_misc 
vfat fat dm_mirror dm_region_hash dm_log dm_mod uinput iTCO_wdt 
iTCO_vendor_support coretemp kvm_intel kvm crc32c_intel microcode pcspkr 
i2c_i801 i2c_core lpc_ich mfd_core ioatdma i7core_edac edac_core sg e1000e igb 
dca sd_mod crc_t10dif lpfc scsi_transport_fc scsi_tgt mptsas mptscsih mptbase 
scsi_transport_sas scsi_mod
[  328.560103] CPU 0
[  328.582021] Pid: 2445, comm: bash Not tainted 3.6.0-rc5-removable-node+ #1 
FUJITSU-SV PRIMEQUEST 1800E/SB
[  328.698524] RIP: 0010:[8116ffdc]  [8116ffdc] 
free_pcppages_bulk+0x4ec/0x540
[  328.802580] RSP: 0018:8807875f9b88  EFLAGS: 00010002
[  328.866025] RAX: 0001 RBX: 0001 RCX: 0001
[  328.951273] RDX: 0002 RSI: ea007fe0 RDI: 880764801680
[  329.036522] RBP: 8807875f9c38 R08: 01ff8000 R09: 880764801740
[  329.121771] R10: 0180 R11: 0001 R12: 0002
[  329.207022] R13: ea007fe0 R14: 880764801680 R15: ea007fe00020
[  329.292270] FS:  7ff533e92700() GS:8807c180() 
knlGS:
[  329.388942] CS:  0010 DS:  ES:  CR0: 80050033
[  329.457575] CR2: ff600400 CR3: 0007b6826000 CR4: 07f0
[  329.542826] DR0:  DR1:  DR2: 
[  329.628075] DR3:  DR6: 0ff0 DR7: 0400
[  329.713326] Process bash (pid: 2445, threadinfo 8807875f8000, task 
8807b72ccca0)
[  329.809993] Stack:
[  329.833984]  881ff800   

[  329.922788]  81c3f160 8807875f9fd8 8807648016e8 
00010002
[  330.011593]  8807875f8000 8807875f8000 0030 
8807c19d0e18
[  330.100400] Call Trace:
[  330.129588]  [811703c7] free_hot_cold_page+0x187/0x1d0
[  330.201345]  [81170445] __free_pages+0x35/0x50
[  330.264798]  [811c05ec] __online_page_free+0x1c/0x20
[  330.334478]  [811c0616] generic_online_page+0x26/0x30
[  330.405197]  [811c0271] online_pages_range+0x61/0x90
[  330.474880]  [81078240] walk_system_ram_range+0x140/0x150
[  330.549750]  [811c0210] ? 
__online_page_increment_counters+0x20/0x20
[  330.636050]  [8165464b] online_pages+0x22b/0x390
[  330.701584]  [8144d2ec] memory_block_action+0xbc/0x1a0
[  330.773347]  [8166cbfa] ? mutex_lock_nested+0x4a/0x60
[  330.844063]  [8144d453] memory_block_change_state+0x83/0xf0
[  330.921013]  [8118ff9c] ? might_fault+0x5c/0xb0
[  330.985502]  [8144d5f7] store_mem_state+0x137/0x180
[  331.054150]  [8124a517] ? sysfs_write_file+0x87/0x100
[  331.124867]  [814375f0] dev_attr_store+0x20/0x30
[  331.190392]  [8124a533] sysfs_write_file+0xa3/0x100
[  331.259038]  [811cc6d0] vfs_write+0xd0/0x1a0
[  331.320411]  [811cc8a4] sys_write+0x54/0xa0
[  331.380747]  [81679bd9] system_call_fastpath+0x16/0x1b
[  331.452501] Code: ff ff 0f 0b eb fe 0f 0b 0f 1f 80 00 00 00 00 eb f7 0f 0b eb fe 
48 c7 c7 80 3b c3 81 e8 ae 6c f6 ff 85 c0 0f 85 cb fd ff ff eb 8f 0f 0b 66 90 
eb fc 0f 0b eb fe 49 8b 47 e0 f6 c4 40 0f 1f 00 74
[  331.685087] RIP  [8116ffdc] free_pcppages_bulk+0x4ec/0x540
[  331.761102]  RSP 8807875f9b88
[  331.802749] ---[ end trace f3112128f3ab7e75 ]---
[  331.859455] BUG: sleeping function called from invalid context at 
mm/slub.c:930
[  331.946779] in_atomic(): 1, irqs_disabled(): 1, pid: 2445, name: bash
[  332.023723] INFO: lockdep is turned off.
[  332.070554] irq event stamp: 301462
[  332.112196] hardirqs last  enabled at (301461): [816700f0] 
_raw_spin_unlock_irq+0x30/0x50
[  332.220397] hardirqs last disabled at (301462): [8166f5cf] 
_raw_spin_lock_irq+0x1f/0x90
[  

Re: [V4 PATCH 00/26] memory,numa: introduce MOVABLE-dedicated node and online_movable for hotplug

2012-09-10 Thread Lai Jiangshan
On 09/11/2012 09:37 AM, Yasuaki Ishimatsu wrote:
 Hi Lai,
 
 2012/09/11 10:22, Lai Jiangshan wrote:
 On 09/11/2012 08:40 AM, Yasuaki Ishimatsu wrote:
 Hi Lai,

 Using memory_online to hot-added node's memory, the following kernel 
 messages
 were shown. Is this a known issue?

 Thank you for your report.

 What operations did you have performed ?
 
 My operations are as follows:
 
 1. Hot-add a new node by container driver.
In my system, container driver hot-addes a new nodes which includes CPUs 
 and
memorys.
 
 2. echo online_movable to hot-added nodes's memory
When container driver hot-adds a new nodes, my system creates node2 sysfs.
And the sysfs has memory768-memory1023 sysfs. So I echo online_movable
to memory1023/state file.
# echo online_movable  memory1023/state
 


I can't reproduce the bug. and my system is a little different from you.
could you show me the /proc/zoneinfo?

also, could you add following patch, it will help me know which constraint I 
have broken.

Thanks,
Lai

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 3878170..68302ef 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -549,6 +549,9 @@ static inline void __free_one_page(struct page *page,
 
page_idx = page_to_pfn(page)  ((1  MAX_ORDER) - 1);
 
+   VM_BUG_ON(page_outside_zone_boundaries(zone, page));
+   VM_BUG_ON(!pfn_valid_within(page_to_pfn(page)));
+   VM_BUG_ON(zone != page_zone(page));
VM_BUG_ON(page_idx  ((1  order) - 1));
VM_BUG_ON(bad_range(zone, page));
 
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/