Re: [git pull] New firewire stack (updated)
Christoph Hellwig wrote: > ACK from me. I still have some comments but none of them is a merge > blocker. I put one small fix that Kristian sent on hold (const char * vs char * for shostt->proc_name) to let a related patch go to scsi-misc first. So this open item is my fault, not his. :-) -- Stefan Richter -=-=-=== -=-= -=-=- http://arcgraph.de/sr/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [git pull] New firewire stack (updated)
Christoph Hellwig wrote: > On Thu, May 10, 2007 at 07:26:56PM +0200, Stefan Richter wrote: >> - The drivers still live in drivers/firewire/, i.e. have not been put >> into mainline's drivers/ieee1394/. > > I don't quite like that. Then again git handles renames pretty nicely > and I hope we'll just shift the new drivers in place when the old code > goes away completely to give people a seamless migration. There were some comments in this and past reviews pro and contra the directory split. For me, it was easier to deal with patch handling that way since the stack went into -mm, but once the stack is in Linus' tree, my work will probably be easier anyway. -- Stefan Richter -=-=-=== -=-= -=-=- http://arcgraph.de/sr/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [git pull] New firewire stack (updated)
On Thu, May 10, 2007 at 06:38:50PM +0100, Christoph Hellwig wrote: > On Thu, May 10, 2007 at 07:26:56PM +0200, Stefan Richter wrote: > > Linus, please pull from the juju branch at > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394-2.6.git > > juju > > > > ACK from me. I still have some comments but none of them is a merge > blocker. > > > What did _not_ change: > > > > - The drivers are still named fw-core, fw-ohci, fw-sbp2 (but they > > feature conditional aliases sbp2 and ohci1394 now). Adrian > > suggested the prefix firewire- instead of fw-. > > > > - The drivers still live in drivers/firewire/, i.e. have not been put > > into mainline's drivers/ieee1394/. > > I don't quite like that. Then again git handles renames pretty nicely > and I hope we'll just shift the new drivers in place when the old code > goes away completely to give people a seamless migration. For users it shouldn't matter where the code is located in the kernel sources (and "firewire" is IMHO for many people more meaningful than "ieee1394"). cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [git pull] New firewire stack (updated)
On Thu, May 10, 2007 at 07:26:56PM +0200, Stefan Richter wrote: > Linus, please pull from the juju branch at > > git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394-2.6.git > juju > ACK from me. I still have some comments but none of them is a merge blocker. > What did _not_ change: > > - The drivers are still named fw-core, fw-ohci, fw-sbp2 (but they > feature conditional aliases sbp2 and ohci1394 now). Adrian > suggested the prefix firewire- instead of fw-. > > - The drivers still live in drivers/firewire/, i.e. have not been put > into mainline's drivers/ieee1394/. I don't quite like that. Then again git handles renames pretty nicely and I hope we'll just shift the new drivers in place when the old code goes away completely to give people a seamless migration. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
