Re: [ibm-acpi-devel] [PATCH v2] thinkpad_acpi: Add support for HKEY version 0x200

[Darren Hart]

On Thu, Jun 09, 2016 at 06:04:52PM -0300, Henrique de Moraes Holschuh wrote:
> On Thu, 09 Jun 2016, Darren Hart wrote:
> > On Thu, Jun 09, 2016 at 01:05:12AM -0400, Marco Trevisan (Treviño) wrote:
> > > 2016-06-08 10:54 GMT-04:00 Lyude :
> > > > From: Dennis Wassenberg 
> > > >
> > > > Lenovo Thinkpad devices T460, T460s, T460p, T560, X260 use
> > > > HKEY version 0x200 without adaptive keyboard.
> > > >
> > > > HKEY version 0x200 has method MHKA with one parameter value.
> > > > Passing parameter value 1 will get hotkey_all_mask (the same like
> > > > HKEY version 0x100 without parameter). Passing parameter value 2 to
> > > > MHKA method will retrieve hotkey_all_adaptive_mask. If 0 is returned in
> > > > that case there is no adaptive keyboard available.
> > > >
> > > > Signed-off-by: Dennis Wassenberg 
> > > > Signed-off-by: Lyude 
> > > > Tested-by: Lyude 
> > > > Tested-by: Marco Trevisan 
> > > > Acked-by: Henrique de Moraes Holschuh 
> > > 
> > > Can you also Cc: sta...@vger.kernel.org so that it can be imported
> > > there once merged?
> > 
> > It doesn't meet stable kernel rules unfortunately, with 143 lines diff.
> > 
> > Henrique, do you want to weigh in on whether this goes back to stable?
> 
> It should be in a bunch of -rc kernel releases before we even consider
> it.
> 
> > One thing I could do is include this in my 4.7-rc fixes branch instead of
> > waiting for 4.8.
> 
> If Linus will take it, I don't see a problem with that.

I'll do that.

-- 
Darren Hart
Intel Open Source Technology Center

Re: [ibm-acpi-devel] [PATCH v2] thinkpad_acpi: Add support for HKEY version 0x200

[Darren Hart]

On Thu, Jun 09, 2016 at 06:04:52PM -0300, Henrique de Moraes Holschuh wrote:
> On Thu, 09 Jun 2016, Darren Hart wrote:
> > On Thu, Jun 09, 2016 at 01:05:12AM -0400, Marco Trevisan (Treviño) wrote:
> > > 2016-06-08 10:54 GMT-04:00 Lyude :
> > > > From: Dennis Wassenberg 
> > > >
> > > > Lenovo Thinkpad devices T460, T460s, T460p, T560, X260 use
> > > > HKEY version 0x200 without adaptive keyboard.
> > > >
> > > > HKEY version 0x200 has method MHKA with one parameter value.
> > > > Passing parameter value 1 will get hotkey_all_mask (the same like
> > > > HKEY version 0x100 without parameter). Passing parameter value 2 to
> > > > MHKA method will retrieve hotkey_all_adaptive_mask. If 0 is returned in
> > > > that case there is no adaptive keyboard available.
> > > >
> > > > Signed-off-by: Dennis Wassenberg 
> > > > Signed-off-by: Lyude 
> > > > Tested-by: Lyude 
> > > > Tested-by: Marco Trevisan 
> > > > Acked-by: Henrique de Moraes Holschuh 
> > > 
> > > Can you also Cc: sta...@vger.kernel.org so that it can be imported
> > > there once merged?
> > 
> > It doesn't meet stable kernel rules unfortunately, with 143 lines diff.
> > 
> > Henrique, do you want to weigh in on whether this goes back to stable?
> 
> It should be in a bunch of -rc kernel releases before we even consider
> it.
> 
> > One thing I could do is include this in my 4.7-rc fixes branch instead of
> > waiting for 4.8.
> 
> If Linus will take it, I don't see a problem with that.

I'll do that.

-- 
Darren Hart
Intel Open Source Technology Center

Re: [ibm-acpi-devel] [PATCH v2] thinkpad_acpi: Add support for HKEY version 0x200

[Henrique de Moraes Holschuh]

On Thu, 09 Jun 2016, Darren Hart wrote:
> On Thu, Jun 09, 2016 at 01:05:12AM -0400, Marco Trevisan (Treviño) wrote:
> > 2016-06-08 10:54 GMT-04:00 Lyude :
> > > From: Dennis Wassenberg 
> > >
> > > Lenovo Thinkpad devices T460, T460s, T460p, T560, X260 use
> > > HKEY version 0x200 without adaptive keyboard.
> > >
> > > HKEY version 0x200 has method MHKA with one parameter value.
> > > Passing parameter value 1 will get hotkey_all_mask (the same like
> > > HKEY version 0x100 without parameter). Passing parameter value 2 to
> > > MHKA method will retrieve hotkey_all_adaptive_mask. If 0 is returned in
> > > that case there is no adaptive keyboard available.
> > >
> > > Signed-off-by: Dennis Wassenberg 
> > > Signed-off-by: Lyude 
> > > Tested-by: Lyude 
> > > Tested-by: Marco Trevisan 
> > > Acked-by: Henrique de Moraes Holschuh 
> > 
> > Can you also Cc: sta...@vger.kernel.org so that it can be imported
> > there once merged?
> 
> It doesn't meet stable kernel rules unfortunately, with 143 lines diff.
> 
> Henrique, do you want to weigh in on whether this goes back to stable?

It should be in a bunch of -rc kernel releases before we even consider
it.

> One thing I could do is include this in my 4.7-rc fixes branch instead of
> waiting for 4.8.

If Linus will take it, I don't see a problem with that.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

Re: [ibm-acpi-devel] [PATCH v2] thinkpad_acpi: Add support for HKEY version 0x200

[Henrique de Moraes Holschuh]

On Thu, 09 Jun 2016, Darren Hart wrote:
> On Thu, Jun 09, 2016 at 01:05:12AM -0400, Marco Trevisan (Treviño) wrote:
> > 2016-06-08 10:54 GMT-04:00 Lyude :
> > > From: Dennis Wassenberg 
> > >
> > > Lenovo Thinkpad devices T460, T460s, T460p, T560, X260 use
> > > HKEY version 0x200 without adaptive keyboard.
> > >
> > > HKEY version 0x200 has method MHKA with one parameter value.
> > > Passing parameter value 1 will get hotkey_all_mask (the same like
> > > HKEY version 0x100 without parameter). Passing parameter value 2 to
> > > MHKA method will retrieve hotkey_all_adaptive_mask. If 0 is returned in
> > > that case there is no adaptive keyboard available.
> > >
> > > Signed-off-by: Dennis Wassenberg 
> > > Signed-off-by: Lyude 
> > > Tested-by: Lyude 
> > > Tested-by: Marco Trevisan 
> > > Acked-by: Henrique de Moraes Holschuh 
> > 
> > Can you also Cc: sta...@vger.kernel.org so that it can be imported
> > there once merged?
> 
> It doesn't meet stable kernel rules unfortunately, with 143 lines diff.
> 
> Henrique, do you want to weigh in on whether this goes back to stable?

It should be in a bunch of -rc kernel releases before we even consider
it.

> One thing I could do is include this in my 4.7-rc fixes branch instead of
> waiting for 4.8.

If Linus will take it, I don't see a problem with that.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

Re: [ibm-acpi-devel] [PATCH v2] thinkpad_acpi: Add support for HKEY version 0x200

[Darren Hart]

On Thu, Jun 09, 2016 at 01:05:12AM -0400, Marco Trevisan (Treviño) wrote:
> 2016-06-08 10:54 GMT-04:00 Lyude :
> > From: Dennis Wassenberg 
> >
> > Lenovo Thinkpad devices T460, T460s, T460p, T560, X260 use
> > HKEY version 0x200 without adaptive keyboard.
> >
> > HKEY version 0x200 has method MHKA with one parameter value.
> > Passing parameter value 1 will get hotkey_all_mask (the same like
> > HKEY version 0x100 without parameter). Passing parameter value 2 to
> > MHKA method will retrieve hotkey_all_adaptive_mask. If 0 is returned in
> > that case there is no adaptive keyboard available.
> >
> > Signed-off-by: Dennis Wassenberg 
> > Signed-off-by: Lyude 
> > Tested-by: Lyude 
> > Tested-by: Marco Trevisan 
> > Acked-by: Henrique de Moraes Holschuh 
> 
> Can you also Cc: sta...@vger.kernel.org so that it can be imported
> there once merged?

It doesn't meet stable kernel rules unfortunately, with 143 lines diff.

Henrique, do you want to weigh in on whether this goes back to stable?

One thing I could do is include this in my 4.7-rc fixes branch instead of
waiting for 4.8.

-- 
Darren Hart
Intel Open Source Technology Center

Re: [ibm-acpi-devel] [PATCH v2] thinkpad_acpi: Add support for HKEY version 0x200

[Darren Hart]

On Thu, Jun 09, 2016 at 01:05:12AM -0400, Marco Trevisan (Treviño) wrote:
> 2016-06-08 10:54 GMT-04:00 Lyude :
> > From: Dennis Wassenberg 
> >
> > Lenovo Thinkpad devices T460, T460s, T460p, T560, X260 use
> > HKEY version 0x200 without adaptive keyboard.
> >
> > HKEY version 0x200 has method MHKA with one parameter value.
> > Passing parameter value 1 will get hotkey_all_mask (the same like
> > HKEY version 0x100 without parameter). Passing parameter value 2 to
> > MHKA method will retrieve hotkey_all_adaptive_mask. If 0 is returned in
> > that case there is no adaptive keyboard available.
> >
> > Signed-off-by: Dennis Wassenberg 
> > Signed-off-by: Lyude 
> > Tested-by: Lyude 
> > Tested-by: Marco Trevisan 
> > Acked-by: Henrique de Moraes Holschuh 
> 
> Can you also Cc: sta...@vger.kernel.org so that it can be imported
> there once merged?

It doesn't meet stable kernel rules unfortunately, with 143 lines diff.

Henrique, do you want to weigh in on whether this goes back to stable?

One thing I could do is include this in my 4.7-rc fixes branch instead of
waiting for 4.8.

-- 
Darren Hart
Intel Open Source Technology Center

Re: [ibm-acpi-devel] [PATCH v2] thinkpad_acpi: Add support for HKEY version 0x200

[Treviño]

2016-06-08 10:54 GMT-04:00 Lyude :
> From: Dennis Wassenberg 
>
> Lenovo Thinkpad devices T460, T460s, T460p, T560, X260 use
> HKEY version 0x200 without adaptive keyboard.
>
> HKEY version 0x200 has method MHKA with one parameter value.
> Passing parameter value 1 will get hotkey_all_mask (the same like
> HKEY version 0x100 without parameter). Passing parameter value 2 to
> MHKA method will retrieve hotkey_all_adaptive_mask. If 0 is returned in
> that case there is no adaptive keyboard available.
>
> Signed-off-by: Dennis Wassenberg 
> Signed-off-by: Lyude 
> Tested-by: Lyude 
> Tested-by: Marco Trevisan 
> Acked-by: Henrique de Moraes Holschuh 

Can you also Cc: sta...@vger.kernel.org so that it can be imported
there once merged?

Re: [ibm-acpi-devel] [PATCH v2] thinkpad_acpi: Add support for HKEY version 0x200

[Treviño]

2016-06-08 10:54 GMT-04:00 Lyude :
> From: Dennis Wassenberg 
>
> Lenovo Thinkpad devices T460, T460s, T460p, T560, X260 use
> HKEY version 0x200 without adaptive keyboard.
>
> HKEY version 0x200 has method MHKA with one parameter value.
> Passing parameter value 1 will get hotkey_all_mask (the same like
> HKEY version 0x100 without parameter). Passing parameter value 2 to
> MHKA method will retrieve hotkey_all_adaptive_mask. If 0 is returned in
> that case there is no adaptive keyboard available.
>
> Signed-off-by: Dennis Wassenberg 
> Signed-off-by: Lyude 
> Tested-by: Lyude 
> Tested-by: Marco Trevisan 
> Acked-by: Henrique de Moraes Holschuh 

Can you also Cc: sta...@vger.kernel.org so that it can be imported
there once merged?